From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88CFCC52D7F for ; Wed, 14 Aug 2024 20:48:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D49D6B00BF; Wed, 14 Aug 2024 16:48:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 185EC6B00C1; Wed, 14 Aug 2024 16:48:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04CD56B00C2; Wed, 14 Aug 2024 16:48:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DA9A26B00BF for ; Wed, 14 Aug 2024 16:48:53 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 62E7FA1187 for ; Wed, 14 Aug 2024 20:48:53 +0000 (UTC) X-FDA: 82452040146.13.963ED8F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id B14AAC0015 for ; Wed, 14 Aug 2024 20:48:50 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=LO88hM3L; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723668458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2vR5tB3EYG9yLed6UrjHAkmQB1nb8yokRgpGJxjJ1Ec=; b=5H/s2NyrlqoFqBqlqToxG2HOJGqfGPSJkd8qmCWrSmBc+RBNuPXWjpK3/ngQokB9xmt1Lg +rcQ/18ORlcETMvYjF28WdaEQ1Z02MlteO4nFCLc4w7uGfQH5HPNA0I2LRJ/iAFnzKfn68 xqiSgd7a0JG0MhRfm170D9vZsX+X5c8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723668458; a=rsa-sha256; cv=none; b=THvdg1mBK6u77/8CIWjEZvysXK3+29FXYOYMmC+6PL1gTQXVT9yy0ViJvdxATm+SoHQspS OlkzfIHJtvOvwjAqUPJqGUCLDBM44UndRDZPpNJLV6jo2zOuQHY7Wdj7qyRTioVLaAjtiq MlZEJllQCjiggVqqMdHhoH3lb4QRiwY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=LO88hM3L; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7781D61CC6; Wed, 14 Aug 2024 20:48:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8358C116B1; Wed, 14 Aug 2024 20:48:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1723668529; bh=Bh66MDLuw1yvnch9iVnkCZn0n83o3MMWU2nFRyqitdY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LO88hM3LOhPz6SYYPmi5fqPdVR1I1E9cOYrwECbZOtmhIxkng83sLvLrc/1b661lC YsD5e6FpNHZLJeHqZPaF8LpZCDKNQSoxPCwDMC4bNpsl3EIOhhoxNQPLagRhja4oPK DaYoO+7VrpxgQIXhj7M8lm/oHJapqQCEhRPhKgs4= Date: Wed, 14 Aug 2024 13:48:48 -0700 From: Andrew Morton To: Kaiyang Zhao Cc: David Rientjes , linux-mm@kvack.org, cgroups@vger.kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, mhocko@kernel.org, nehagholkar@meta.com, abhishekd@meta.com, hannes@cmpxchg.org Subject: Re: [PATCH] mm,memcg: provide per-cgroup counters for NUMA balancing operations Message-Id: <20240814134848.1c9d59bb03a524f8462eda3f@linux-foundation.org> In-Reply-To: References: <20240809212115.59291-1-kaiyang2@cs.cmu.edu> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B14AAC0015 X-Stat-Signature: 6hjo79u3w3wbnxkmcftnf9waj3xzm9qi X-HE-Tag: 1723668530-929543 X-HE-Meta: U2FsdGVkX18M4MPJT6PDaKTLv8zmAtSYA4DmLOVM5CaSiUlGwU++J5ofJWDwuGpHf2hIeHZZClXbVBA3AkHsot6OR+ATVwOQ39zxNBbHH51tKtl3iXrr0H95a1RK5cPZxgIOQtj5A0NSV5L5TKMbYIXQggJ1YvkcPBlO9tooYXP93nZKrcssgfPFUG8vUOUyHUkAFjonRqLiRZz/b9hkSIWBlfRPYszahZiLyfA5YBrHwJvqw2YPeJVvCAb6Hkk1LsfT/BEv8HhnXYXN5YYSUHRzSKjEVn0sulC7svDAwAjvkm+ZkAvm2umWrOIRec2gy01SjxnvrEPjT4ZaH7/R7X31qbxdlUHKNKqANrdZVL1flSeO1NdjE7StKvpB2J6FMTnoWGrfNvRh6p5IfhXjzvL5Si7HaxOp79cd3TbiacHkl4s2A2vTP8NiJBwlkiJQrjiQyNIZ4P3WpD3zKsW6630j8Ndjw0StVYIWTxnhuLKCSuOkQobb7qnGgiyAM5XzGJrj8JMYGfBRqQqSChjJGXC5UAJ2jXXiRR+M0stmFyQge1j9PEJeZ2vF3zjGynoPUeaOTIGxl+XjQwKtUPt5v/sB90NESOySLGFx0+1DPi3EcMJzrGkPkv8zD5joDGeKZJx+bvQC/LWte9Vin82DfXYsIQoy5luos0hyFSVCyikyFhvnJKqRBTUPBase9HPmHmAeX8ixw1oyOrW3Y3lpNa0dAct3xYBAmEbNI7o/nKmNZe0JT7LBvivUFQQQeZJwkNG/jm4uSVGD3r+ntrp6BS42kkrCKXXMyjLAmebuEG2MdRmWfPMjeBofBxSFT5fDiQv6sUMISN4S4UqH/k671MeT/u3+BZ+YBxE51QjSrIcMsyldo3TwMufbQ2jmToWyNaKM9e3294AzQZB2H2V99HgzUXT0oPOfZEQoJUHl027eX4MbpN4X08mCo+cTsKeXmo7jLx5qfW8UcNMqsqc ujxEoxpt I4UlqOejvuKld+b95B/ooVzEbgtpTuZs8lWTN1UMbAVhvKCeECelI3G/UJf45HCGOttXArJDdVnYm1z8GCXtbyswnT6YP2I9zUN0uBB8IXwAq1u7b5eb/BpHAmfSqLWXnK401JPzlfE5hfcsfEXfbXcK438XR1uf8S7V6IINYRADWPOYwJzkFcIqUxPBlDcmbxXxE5oEQo/7wly2nCd6bcZPEJHybV5Lwj9ip X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 12 Aug 2024 22:49:02 +0000 Kaiyang Zhao wrote: > On Sun, Aug 11, 2024 at 01:16:53PM -0700, David Rientjes wrote: > > Hi Kaiyang, have you considered per-memcg control over NUMA balancing > > operations as well? > > > > Wondering if that's the direction that you're heading in, because it would > > be very useful to be able to control NUMA balancing at memcg granularity > > on multi-tenant systems. > > > > I mentioned this at LSF/MM/BPF this year. If people believe this is out > > of scope for memcg, that would be good feedback as well. > > Yes that's exactly where we are heading -- per-cgroup control of NUMA > balancing operations in the context of memory tiering with CXL memory, > by extending the concept of memory.low and memory.high. The use case is > enabling a fair share of top tier memory across containers. > > I'm collaborating with Meta on this, and we already have an implementation > and some experiments done. The patches will go out soon. If others have > thoughts on this, please chime in. I think it's helpful to capture such broad-brush where-this-is-heading info in the changelogs. For reviewers and for posterity. In fact, any reviewer question should be treated as a bug report against the changelog! Questions mean that information was missing. I'll grab v3 now, but please feel free to send along any changelog additions which come to mind.