linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Kaiyang Zhao <kaiyang2@cs.cmu.edu>
Cc: David Rientjes <rientjes@google.com>,
	linux-mm@kvack.org, cgroups@vger.kernel.org,
	roman.gushchin@linux.dev, shakeel.butt@linux.dev,
	muchun.song@linux.dev, mhocko@kernel.org, nehagholkar@meta.com,
	abhishekd@meta.com, hannes@cmpxchg.org
Subject: Re: [PATCH] mm,memcg: provide per-cgroup counters for NUMA balancing operations
Date: Wed, 14 Aug 2024 13:48:48 -0700	[thread overview]
Message-ID: <20240814134848.1c9d59bb03a524f8462eda3f@linux-foundation.org> (raw)
In-Reply-To: <ZrqRXtVAkbC-q9SP@localhost.localhost>

On Mon, 12 Aug 2024 22:49:02 +0000 Kaiyang Zhao <kaiyang2@cs.cmu.edu> wrote:

> On Sun, Aug 11, 2024 at 01:16:53PM -0700, David Rientjes wrote:
> > Hi Kaiyang, have you considered per-memcg control over NUMA balancing 
> > operations as well?
> > 
> > Wondering if that's the direction that you're heading in, because it would 
> > be very useful to be able to control NUMA balancing at memcg granularity 
> > on multi-tenant systems.
> > 
> > I mentioned this at LSF/MM/BPF this year.  If people believe this is out 
> > of scope for memcg, that would be good feedback as well.
> 
> Yes that's exactly where we are heading -- per-cgroup control of NUMA
> balancing operations in the context of memory tiering with CXL memory,
> by extending the concept of memory.low and memory.high. The use case is
> enabling a fair share of top tier memory across containers.
> 
> I'm collaborating with Meta on this, and we already have an implementation
> and some experiments done. The patches will go out soon. If others have 
> thoughts on this, please chime in.

I think it's helpful to capture such broad-brush where-this-is-heading
info in the changelogs.  For reviewers and for posterity.

In fact, any reviewer question should be treated as a bug report
against the changelog!  Questions mean that information was missing.

I'll grab v3 now, but please feel free to send along any changelog
additions which come to mind.


      parent reply	other threads:[~2024-08-14 20:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09 21:21 kaiyang2
2024-08-10  0:28 ` Andrew Morton
2024-08-11 20:16 ` David Rientjes
2024-08-12 22:49   ` Kaiyang Zhao
2024-08-13  5:09     ` David Rientjes
2024-08-13 18:21       ` Kaiyang Zhao
2024-08-14 20:48     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240814134848.1c9d59bb03a524f8462eda3f@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=abhishekd@meta.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kaiyang2@cs.cmu.edu \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=nehagholkar@meta.com \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox