From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 228DDC3DA4A for ; Wed, 14 Aug 2024 13:09:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CC876B0085; Wed, 14 Aug 2024 09:09:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97BCD6B0088; Wed, 14 Aug 2024 09:09:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CEBC6B0089; Wed, 14 Aug 2024 09:09:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5F6316B0085 for ; Wed, 14 Aug 2024 09:09:24 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F025A160F3D for ; Wed, 14 Aug 2024 13:09:23 +0000 (UTC) X-FDA: 82450882206.18.02457F3 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2048.outbound.protection.outlook.com [40.107.100.48]) by imf28.hostedemail.com (Postfix) with ESMTP id 2CA42C0015 for ; Wed, 14 Aug 2024 13:09:20 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=BLo15t5n; spf=pass (imf28.hostedemail.com: domain of jgg@nvidia.com designates 40.107.100.48 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723640904; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2/TJEe73rZpagFT95/zy/wwUQhKNYVINv7n+OXIYB2w=; b=23APqghTBtJpZOvYWBXY7YV8jyNjh0iYo6aV0DcSDHgg8NuhgTvfJfzqTtIqMKF67+D6XI E/MU/ctOZFJJO7gViK3b7WVLl0AVPOqug1v4CIwKCu1MgNoHtWAhUOVadihzC8c2KXPQaI DxS5W2Qz5nSp4im6a5wwG0RiRHejdZY= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=BLo15t5n; spf=pass (imf28.hostedemail.com: domain of jgg@nvidia.com designates 40.107.100.48 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1723640904; a=rsa-sha256; cv=pass; b=UZ+I+rb45I1wh27RbtwMcD6WqYHErjLoRjtISf7KD2LoO1XIbsTkPs6JqyUtPo6W9pDWh8 lm/9Ce/laTsmIyijtwX2O2lSX8WkVMW9DSTHjhFba2jodjomiZkZ8MLj1tHL0wpXvDna5H RyB3M6LtQeTivrvFm2tdw8lTaa37458= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uMQ3nJiELJABuJsnnZhxWFDFWMpHXzjZBlpn9Cy50/VYf6rvEBMQGE/4yyt55XJkRg2egzD1mZn3cBQACRTxgh4t2YAhJc/gscnkg6K5MgpH4P4PVijvom1mtIEMMQ1hLwSgckosEwplSe/AINV3bKRvS4CNDrby6BrSe6bEy/o8mqkLZVr3gGFiplOmb2Hte3jpd4+u5m7Yz0YLF+c+AWIR/GUw3PKVh4rf7RN6Jy1qVDsMfc6dTqzGTGizFReqTlT6mxlU+MxzL0087zD7FtSAuG99olZ7km3VgkJgSCQRAo3fHy7e8meR7FXhC6Uu2Hq2qNNQ+5pa35v+E0gxYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2/TJEe73rZpagFT95/zy/wwUQhKNYVINv7n+OXIYB2w=; b=deOmRgEGwb4N0txst4wAAnDWyAv27rP9mpNNHJvutlfkhrb214Kdlm12KGE3firimu4FVx3Q+09dfzMchuzSgHxk65zAboIoiBw5RyV/4Z2JjcfvaiCIavhKHjsd1MFrqhuKPqAKJbtZyHkR4z/98ioiTZwFUZFKPaFzGQ5IHmEB0H65npuPjSobx4j5iWy297yiJ6JAcj+lKyCxDCx8S4o22K7pt/JTpWPB7EcoAIhALlIBgyQOIV2/fZRB2yUUrp9WcVVz85ybHR3FK6iE9lfQZ6lkp18MhEU7PlxJVUDUMj8GJgh9c+O6Gi1dgVfhXM4avI92zcvM/tu9WUn0PA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2/TJEe73rZpagFT95/zy/wwUQhKNYVINv7n+OXIYB2w=; b=BLo15t5neotpVE6FAhoRuPdlDWdA2eyicXDbhzrcS0IsuePlqHVCXTyudi9n0N/HuP4CaatzshMZlQn2NdntXMA4h7/s742T4H4Ef8/vq8mjxKYUVi25aijTPgmYmmRb5EOssXSTnKzizrGMvHl7z6mQB0eQc2e30evx7vB1DjXq7w1lxN1/IAIYt8rtZPoR279mA6gZuBGRei8ITPHlD70uqN05gdJfocUsMzyqJp3F64U+NZqXVBlFw8RHaGXss8pjVnhDpd1ku9WxSEQM/LrEBxpNaxwTbxQr4ab0BsP3PmM6TWwhrnm3EDMJXJW/CS33eayr4psx8qGD6cMMAA== Received: from DM4PR12MB7767.namprd12.prod.outlook.com (2603:10b6:8:100::16) by SJ0PR12MB6854.namprd12.prod.outlook.com (2603:10b6:a03:47c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.18; Wed, 14 Aug 2024 13:09:17 +0000 Received: from DM4PR12MB7767.namprd12.prod.outlook.com ([fe80::55c8:54a0:23b5:3e52]) by DM4PR12MB7767.namprd12.prod.outlook.com ([fe80::55c8:54a0:23b5:3e52%3]) with mapi id 15.20.7849.021; Wed, 14 Aug 2024 13:09:17 +0000 Date: Wed, 14 Aug 2024 10:09:15 -0300 From: Jason Gunthorpe To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sean Christopherson , Oscar Salvador , Axel Rasmussen , linux-arm-kernel@lists.infradead.org, x86@kernel.org, Will Deacon , Gavin Shan , Paolo Bonzini , Zi Yan , Andrew Morton , Catalin Marinas , Ingo Molnar , Alistair Popple , Borislav Petkov , David Hildenbrand , Thomas Gleixner , kvm@vger.kernel.org, Dave Hansen , Alex Williamson , Yan Zhao Subject: Re: [PATCH 08/19] mm: Always define pxx_pgprot() Message-ID: <20240814130915.GI2032816@nvidia.com> References: <20240809160909.1023470-1-peterx@redhat.com> <20240809160909.1023470-9-peterx@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240809160909.1023470-9-peterx@redhat.com> X-ClientProxiedBy: BL1P221CA0016.NAMP221.PROD.OUTLOOK.COM (2603:10b6:208:2c5::29) To DM4PR12MB7767.namprd12.prod.outlook.com (2603:10b6:8:100::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB7767:EE_|SJ0PR12MB6854:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d8d4370-d164-466d-ec26-08dcbc624d3a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?zzNhbWwHQC4KR8O3uzAVvFZgGsliOBP9373qhbDQVEL2vc6Q4sFj3AG7l4dI?= =?us-ascii?Q?J/AjyjFJrHOHmOZulHWvFZ61z7AGILXidSBzbSKC7wGH/nUyVesH9uGVRHDV?= =?us-ascii?Q?znJxSz2ie5+1tsFxsrzazuDlXrHQvn2k2v+ubkmIg8P1FCZ33M5wb/Jm8F/b?= =?us-ascii?Q?eHzbKvBLKloQ4lCkoOlYKw71l8HVGGJpMqUzTErXxatsjMPJB7ixGfGDzqed?= =?us-ascii?Q?XZ9bm8Zs0e+6M8M9+fmw3+J9iIIXp7D04hiSA+KIL4ZvI0WQ0VtFDHO0F05h?= =?us-ascii?Q?GeDK+4BItNPcVpuqNJR6Bx/4YYg1UlnKp6MlZxj9XjklYMVl3zqhomQfQScl?= =?us-ascii?Q?rSO/IUkoW+lf4ejhf1Aop0wh00gzGzTFkSY5mJu8zBAH2HDSIBA1+w8RzbDO?= =?us-ascii?Q?Pl4FXfCSajC9PykkvYOISAGywG2gxdGsAEdRImyXfMApRsxALWzXw91f0OEO?= =?us-ascii?Q?SbVEWvRCniRoiJs8ITrHooVF7DJiEDPqKB+DL0rarNqyoI/oSGK0iLmrr4zl?= =?us-ascii?Q?xacjaIZtVgvEcpy2m696AslJluzg/C07Qaylb4XmzreSghLoPIBHfbjiUd7F?= =?us-ascii?Q?Ox/Uxqc1/cZDvyqXYUCyW0Nj2o4u5a+9GSS2l8n5FWMGeiqc8a/++qLsWn7O?= =?us-ascii?Q?YMBVOcxOuBV2dC/ADyzpSeqrbaOjaM7BkG+Zwoj7BRS4ZMxV1G+kG5ZOUY/L?= =?us-ascii?Q?9SfasAdQyw88Wqb/tZg6o0dFHQHb+bHYEl40Ovq5ZwCeLYAAKtqf4Y0Lyoj0?= =?us-ascii?Q?8rAxV/T3i8u8v8Z3QxOscvcq23HoE/FnuUW+wLPZMSet/3XUurFEsawloeCN?= =?us-ascii?Q?gchiqE8Ya+RMP8KZMse/spr1OKAjZk5xM80EolIC//bO8ArSyx+Ohna2CZyi?= =?us-ascii?Q?mhjvRkjzvHwfabPHqo//3U0zW39Fnf/l1NkPu6EUcFdQ9YkQIJ3kNo5Tsflh?= =?us-ascii?Q?6TIolv0Xqjq8GzPDQjT4asUP62f+L+0geHDdhh769Bbfvh9xg3pZU7KSZ8Uj?= =?us-ascii?Q?gt3sSiLyUCMAxaYhGkZn7kbsAVw4Droec3ZB4VDKHDAuGEXbrYsNLwXCgX+1?= =?us-ascii?Q?sM8ZxQucSFi76YT+lr3mW/qY6nQMHz5RQHTFs9mWvJlpGnQbl6LYPZ/ZAWwM?= =?us-ascii?Q?LJwqnb9On4cAzSXRaXIDbKgFBd1Do4VUmyZBYTj8UKUVaLD46Z4cyFlOIwxO?= =?us-ascii?Q?xdG/ClWxDLQhjK2UIVrrkkKdeYprIz1fE2yNYsy39cpyqQugA7NcaE+g8LGr?= =?us-ascii?Q?jzdwa6cSDU0mdvACg88i8rYetfY9WIhXwYfPLJ6ENdpHj7XJmGCCnoHI8hNM?= =?us-ascii?Q?29kH/0Q9Z3qsJkeFaOCmY0GdBnF2afptA4UyT8ltb2efGg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB7767.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NoYf40ZAoLkvFxSawH3NYj2wfHj4RILuAr9gUn1hxgchWofArUHc//A6s5TA?= =?us-ascii?Q?sZdfyuQVeKaAUhoY8zqPaN5DwSQSuSgsqLnwMpsB3bF1SmNZ+017u36xg0M/?= =?us-ascii?Q?CHNZhDDCTTXJypHzuIEct0S97i8sIzoDRfXTvkxL6K8JTpeE4RUKkrsL6Fns?= =?us-ascii?Q?UZcSqTjgY4RduPh/NCTu0tuuLNPvUZmLd/AM2I2JgQE+4nC//NYsM0k93FQG?= =?us-ascii?Q?zOdx5ANtk/wMXdGkPbDANWmqvscsSnvrBunNIWfOnn77O5hwhRmUnwOF8QSL?= =?us-ascii?Q?aCPyTUelJ9IYi0IbYO0zgVEvZMD8wCJs+Ywi/b4N0Krk/JaJTIl4Rr/wczHH?= =?us-ascii?Q?H32GVqtc71USdP7BX8bfhsRXchM60DPCe4C4MrTk9xSiL9CRR5R/fptRU5NN?= =?us-ascii?Q?gkOL3FJOLbV5o6nDGCDP0W4OAU2iOkoSA7xpUpcJ6y/EjG5Y2Lbq07Kd7w/7?= =?us-ascii?Q?MdbR1rcclRR5njOW4A2CJC3tQNYmbRGRumYb0r8atCtexTjzHTE+Bc1ciF9F?= =?us-ascii?Q?5bQcwnrqlq28gQxg3vuSouWeclKeA/uh2YRe+V75+G65m43dp7q1wc7XrKnZ?= =?us-ascii?Q?f5f7DynYkzahEQWvBJYDemJ8UckOaRJthLFARG0AWT4/GXded3BrhWvdJ+ex?= =?us-ascii?Q?ipHFJQYl6KRXH6/mFL7Gum3CMek/OppZRM+zClwnkkEW+eApR+q1j90lh/wY?= =?us-ascii?Q?iuZYOwMRSv45FquOsQgvz+6FQL7Z4eom9jfuW9nTtkknfLqSnK7AVoRWqYnQ?= =?us-ascii?Q?HU/lkcCrWt+/dTKhKWokxW0OU/x7BSFZ0R7YO3gKjkNJANdRDatETYwj8Z2L?= =?us-ascii?Q?I0HBImZWE04fyo7Px5KPHHsGn4KxH6pnlnZKVhHbMsNr89wNMPWxgaVDqxWm?= =?us-ascii?Q?YrCmQo7BSQ6Gn00kDJ7cw0ifQRfoCnhhOHeVSQ5q3kMJw/WcwF/5SuxnKOO9?= =?us-ascii?Q?ZOFlNpjF+2uYSQUK9RxOGOPTdv0wRfhK2ZHp6y8a7qAEcjr0FYgPanNBzA6O?= =?us-ascii?Q?92ONHgK1gSUtzgs09rqdhknT1bftMnxGhSc+i+kwkLL1OegG2ZAsUMjE9w4X?= =?us-ascii?Q?UIsEtjWTWU2NBUbVRPTSwULtHtLelFt+gTwjXRpmSxPIxFkwggGhtvaL/wLe?= =?us-ascii?Q?aP6FQdyPSOO+bhlm1DMPa/ve7i6INLx/M4KVxIF01HVSceVjsnnvE8AF0WR8?= =?us-ascii?Q?GggtdYnk2/QPPCjLbn7VhSar6s1nx551EWJLpf1ocqfMFtyFuZGFpXTXSGgU?= =?us-ascii?Q?WBDjoM3BzEw8Pwwvhx0BJvDoiWuimRM6e+XhLbDn2caiui2elZamcoQoru68?= =?us-ascii?Q?EGsY2SW8CPOyjh9JoAHjRh9OcBpliJSsT+Jxu3ZwoyepL8eEhGQM7hS2VpLq?= =?us-ascii?Q?UW5oHZ1oTs/fKD0wuZwhFHpPE40KKi1XoBKV86sdTfJLS8Cl6I/xgKRbTae0?= =?us-ascii?Q?9bh3PBgSs3x9iDEm5P54trvgzeM4TIz+zEY9iI/qa1fRVdN2ugaaE2KWL5IY?= =?us-ascii?Q?B39OSaSIabKtxm6gwGJc0ZQcECC7+SS4lL6QGwlT9T18RU/U3kUpx5USbF1p?= =?us-ascii?Q?NAij+W4dEgw9FQHi+43yvuDMBcs5gA7kFeRLjZ0r?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d8d4370-d164-466d-ec26-08dcbc624d3a X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB7767.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2024 13:09:17.0106 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uBdfUpeLn9en4stQZEc+CgQFbBCfOkmbPGCqcGPSEYz85NqBr+X8zgg5qjopmyXN X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6854 X-Stat-Signature: rn44u1i6w969hfii31esu9ochpgwrxsx X-Rspam-User: X-Rspamd-Queue-Id: 2CA42C0015 X-Rspamd-Server: rspam02 X-HE-Tag: 1723640960-732862 X-HE-Meta: U2FsdGVkX1+2mhilrtu+vvPuJ4z3NmgeJUq6ziJYZm0OdHBMKSmJl5XL6w6j5weuDNFAzjP1kphUceOoj67llIZEfqJ5GnV3rKq/YA1UKYmcBVrY6YpU3dvhG/uKKEYjHPxCQ5OVxhnGN9zeT3TL7pI7uIiYZwo4FJIxlEGDG6+bsmpmBdQfUSVPd+0K02A2GV4LLD2oqThjuJ1BslNDa4qJxNZTM5JyS8Wyc8nlFYGUopEerksBKBG7DOxVfrC84yFm2qdEP767qnAEJ14E+PvRiDkmS1pLKbjAdtY/+Wq8glc8P47N4bGusTa7rtVJSRq/eINIBWj0qGdZpovq9cqkpjyD+8UMwNeP4iUSWZ2njmp5EPfzhIGKcMy6NE7hfDbXTRCwsSYdL9DqcnIfSAIovA5kzLgQFv/FmAbxYZ902K7eQVopknv7Al7zcJvmSxc4YC5Fx4x7QBMAjjAvXr1HhViJaqAOTm9y7OsG9Xji2ww7yOhIldX6dMTcB8/mpp8t1JzfFOj3nOpdTxCs4obDEzZsXpQBt66bsmonB3ie8qvCH5Hh8kSy1CzxFSoZii1Vs1rg6UsYVtDN5dUYuvM8IHxqhr1TQ7uDUZm2p4PfU+IyWjMNBcWQTZBieqAqV01UN9JpAH/b1ECOA070LvGs0oI4s/bYmEvJaEJkdNwFfglTa48Z/tZ2ihtgvsETDv/W48gfC5shCv7KXCyREVXrd44TRcEpbDIJgSWMNfrWFbON5g7OwANqs4B8CjMO3xIgBzo3/AK/f2imBUljUkuNp6yF3n9bjWcs0pakZ4pViwgcE7BGCQpt0+pfyhxHI0spjn5UiCADhIcxze6wEnljlYd1C8uxPIFAxq9q79IGT1Nwo+UyUz1x+y3YMwP62RTWSBpFUECw808MbKSH4whmtUbYXvA8wQHnwaA61mCAGjuGO+82OidWzCQhKi92vAM+bX9fuG2RPaKpFJ+ 5ZPVgyD+ UX737xuUP/FCXjih0z0+/vohS/N+bRHfgOdl0BgCD0p87rKewQY6mQsLEi4LqokfiGuUYjk6ozuUkzEHLqABgh0BCz5foBeNis+GJXi6PR2tBskzLMkuDK5tTXgYPWtZBz3mpQSIu/sB2v3ujdNZf2GthHprc3lB+LStCe7ZzlRbYcH0aQgvfI0w7OldmIxry0w94Irkdyib/FRyTl2IvaSMgKDaoNPvugbkhV1Y6ee6cBMpglYXktGF41vJDZ87won+kcRvm+aUZrrLHp/YjoddVfLmISNg3I8Osv8g8E5kMb8BIKSZxl+rdDGTTuaB8Ls+vjia28/0mu20W6iXrHyYeiQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 09, 2024 at 12:08:58PM -0400, Peter Xu wrote: > There're: > > - 8 archs (arc, arm64, include, mips, powerpc, s390, sh, x86) that > support pte_pgprot(). > > - 2 archs (x86, sparc) that support pmd_pgprot(). > > - 1 arch (x86) that support pud_pgprot(). > > Always define them to be used in generic code, and then we don't need to > fiddle with "#ifdef"s when doing so. > > Signed-off-by: Peter Xu > --- > arch/arm64/include/asm/pgtable.h | 1 + > arch/powerpc/include/asm/pgtable.h | 1 + > arch/s390/include/asm/pgtable.h | 1 + > arch/sparc/include/asm/pgtable_64.h | 1 + > include/linux/pgtable.h | 12 ++++++++++++ > 5 files changed, 16 insertions(+) Reviewed-by: Jason Gunthorpe > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 7a4f5604be3f..b78cc4a6758b 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -384,6 +384,7 @@ static inline void __sync_cache_and_tags(pte_t pte, unsigned int nr_pages) > /* > * Select all bits except the pfn > */ > +#define pte_pgprot pte_pgprot > static inline pgprot_t pte_pgprot(pte_t pte) > { > unsigned long pfn = pte_pfn(pte); Stylistically I've been putting the #defines after the function body, I wonder if there is a common pattern.. Jason