From: Yu Zhao <yuzhao@google.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Muchun Song <muchun.song@linux.dev>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
Zi Yan <ziy@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Yu Zhao <yuzhao@google.com>
Subject: [PATCH mm-unstable v2 0/3] mm/hugetlb: alloc/free gigantic folios
Date: Tue, 13 Aug 2024 21:54:48 -0600 [thread overview]
Message-ID: <20240814035451.773331-1-yuzhao@google.com> (raw)
Use __GFP_COMP for gigantic folios can greatly reduce not only the
amount of code but also the allocation and free time.
Approximate LOC to mm/hugetlb.c: +60, -240
Allocate and free 500 1GB hugeTLB memory without HVO by:
time echo 500 >/sys/kernel/mm/hugepages/hugepages-1048576kB/nr_hugepages
time echo 0 >/sys/kernel/mm/hugepages/hugepages-1048576kB/nr_hugepages
Before After
Alloc ~13s ~10s
Free ~15s <1s
The above magnitude generally holds for multiple x86 and arm64 CPU
models.
Perf profile before:
Alloc
- 99.99% alloc_pool_huge_folio
- __alloc_fresh_hugetlb_folio
- 83.23% alloc_contig_pages_noprof
- 47.46% alloc_contig_range_noprof
- 20.96% isolate_freepages_range
16.10% split_page
- 14.10% start_isolate_page_range
- 12.02% undo_isolate_page_range
Free
- update_and_free_pages_bulk
- 87.71% free_contig_range
- 76.02% free_unref_page
- 41.30% free_unref_page_commit
- 32.58% free_pcppages_bulk
- 24.75% __free_one_page
13.96% _raw_spin_trylock
12.27% __update_and_free_hugetlb_folio
Perf profile after:
Alloc
- 99.99% alloc_pool_huge_folio
alloc_gigantic_folio
- alloc_contig_pages_noprof
- 59.15% alloc_contig_range_noprof
- 20.72% start_isolate_page_range
20.64% prep_new_page
- 17.13% undo_isolate_page_range
Free
- update_and_free_pages_bulk
- __folio_put
- __free_pages_ok
7.46% free_tail_page_prepare
- 1.97% free_one_page
1.86% __free_one_page
Yu Zhao (3):
mm/contig_alloc: support __GFP_COMP
mm/cma: add cma_{alloc,free}_folio()
mm/hugetlb: use __GFP_COMP for gigantic folios
include/linux/cma.h | 16 +++
include/linux/gfp.h | 23 ++++
include/linux/hugetlb.h | 9 +-
mm/cma.c | 55 ++++++--
mm/compaction.c | 41 +-----
mm/hugetlb.c | 293 ++++++++--------------------------------
mm/page_alloc.c | 111 ++++++++++-----
7 files changed, 226 insertions(+), 322 deletions(-)
--
2.46.0.76.ge559c4bf1a-goog
next reply other threads:[~2024-08-14 3:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 3:54 Yu Zhao [this message]
2024-08-14 3:54 ` [PATCH mm-unstable v2 1/3] mm/contig_alloc: support __GFP_COMP Yu Zhao
2024-08-22 8:21 ` Yu Liao
2024-08-22 17:25 ` Yu Zhao
2024-08-22 18:36 ` Andrew Morton
2024-08-22 17:23 ` Yu Zhao
2024-08-22 18:42 ` Matthew Wilcox
2024-09-02 17:02 ` Yu Zhao
2024-11-19 15:29 ` David Hildenbrand
2024-11-19 16:12 ` Zi Yan
2024-11-19 16:25 ` David Hildenbrand
2024-11-19 16:31 ` David Hildenbrand
2024-11-19 16:41 ` Zi Yan
2024-11-19 16:49 ` David Hildenbrand
2024-11-19 16:52 ` David Hildenbrand
2024-11-20 15:55 ` Zi Yan
2024-11-20 16:13 ` David Hildenbrand
2024-11-20 16:46 ` Zi Yan
2024-08-14 3:54 ` [PATCH mm-unstable v2 2/3] mm/cma: add cma_{alloc,free}_folio() Yu Zhao
2024-08-22 17:24 ` Yu Zhao
2024-09-02 17:04 ` Yu Zhao
2024-08-14 3:54 ` [PATCH mm-unstable v2 3/3] mm/hugetlb: use __GFP_COMP for gigantic folios Yu Zhao
2024-08-16 15:23 ` Zi Yan
2024-08-16 16:02 ` Yu Zhao
2024-08-16 16:30 ` Zi Yan
2024-08-30 17:55 ` [PATCH mm-unstable v2 0/3] mm/hugetlb: alloc/free " jane.chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814035451.773331-1-yuzhao@google.com \
--to=yuzhao@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox