* [PATCH] mm: vmalloc: add optimization hint on page existence check
@ 2024-08-13 17:12 Miao Wang via B4 Relay
0 siblings, 0 replies; only message in thread
From: Miao Wang via B4 Relay @ 2024-08-13 17:12 UTC (permalink / raw)
To: Andrew Morton, Uladzislau Rezki, Christoph Hellwig, Hariom Panthi
Cc: linux-mm, linux-kernel, Miao Wang
From: Miao Wang <shankerwangmiao@gmail.com>
In commit 21e516b913c1 ("mm: vmalloc: dump page owner info if page is
already mapped"), a BUG_ON macro was changed into an if statement, where
the compiler optimization hint introduced in the BUG_ON macro was removed
along with this change. This patch adds back the hint.
Fixes: 21e516b913c1 ("mm: vmalloc: dump page owner info if page is already mapped")
Signed-off-by: Miao Wang <shankerwangmiao@gmail.com>
---
mm/vmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 6b783baf12a1..5d031fc83f04 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -105,7 +105,7 @@ static int vmap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end,
if (!pte)
return -ENOMEM;
do {
- if (!pte_none(ptep_get(pte))) {
+ if (unlikely(!pte_none(ptep_get(pte)))) {
if (pfn_valid(pfn)) {
page = pfn_to_page(pfn);
dump_page(page, "remapping already mapped page");
---
base-commit: 7c626ce4bae1ac14f60076d00eafe71af30450ba
change-id: 20240814-fix_vmap_unlikely-2973d2cb904b
Best regards,
--
Miao Wang <shankerwangmiao@gmail.com>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-08-13 17:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-13 17:12 [PATCH] mm: vmalloc: add optimization hint on page existence check Miao Wang via B4 Relay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox