From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E382C52D7C for ; Mon, 12 Aug 2024 18:25:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E19886B00B9; Mon, 12 Aug 2024 14:25:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC3166B00BA; Mon, 12 Aug 2024 14:25:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3C396B00BB; Mon, 12 Aug 2024 14:25:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A4AFC6B00B9 for ; Mon, 12 Aug 2024 14:25:16 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 60EFF120337 for ; Mon, 12 Aug 2024 18:25:16 +0000 (UTC) X-FDA: 82444420632.22.FF38AFB Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf23.hostedemail.com (Postfix) with ESMTP id 5A512140007 for ; Mon, 12 Aug 2024 18:25:13 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=E81DuNFU; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of kees@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723487058; a=rsa-sha256; cv=none; b=Thmkqe6dx2YF0cooGWg0wGYRLPMiS2+4Jx+FgwtLDHPGhM8hg8hLWP3fABcs4l9R+x7pHV O0LepzwfS42GIqu2JwkuAgLCSJz9d0fH/K5MIN1lu2HAFa/KZ2PnPKW9EBRB765Rax2VbH ma+tX3FqpK/nGw18p8NXgLaRuvcRyy0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=E81DuNFU; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of kees@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723487058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=onPXYnAcmz6LJasuDwFXrzCscWLsGJadKiZuwWC+d4o=; b=xU5Px62Qtje6YMurrk2EERA27pgzopO7VdZBnmVEAOByEdzVQkpFocogXX2z/vAuu2BKuC K0SrEV/Oko4q0m+HcVkFeYPYX58jzQWHUQbAEdwfAOo8RGOk+BCGscvwahi53nm6pmivVd uD4xRAz5v9AOElCB/sccnQ7izw/jJU0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CECCBCE1043; Mon, 12 Aug 2024 18:25:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2282C32782; Mon, 12 Aug 2024 18:25:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723487111; bh=b9XMtJBDz1eS9eHtLGMNWgjburbqn9Im8RPbrEwodd0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E81DuNFUQBf+Hp0FbT2dTh9FMz6izZjqLPR8pbFkTDHAwRcUSi9U5m4y+b7a5D84S L4T1X6GfeBl5U02jvjl9KAFPYvCkhlnnu6mzL1APe2tZXOEtBs31xMIYkbdSYXb0uw OCZ8ZDxNXF7b9OEHsVto4zb2JZ3KhWUgU8eKSa/fkUBVjkpmgRmH38JMJrE/d+keLW JS9jz+vUKujhhhB11sboKhh4NrSYNASIY94gwq4RxOhzVpA5LDtW+iKVMQnO+sX8+f uubQ8A9wcfOwIxJzy/nBX9COA4qzl87jmWK/AILzeuT6hD8woAsZ10LokHwHHjv8zw nSNBePSfzuDjw== Date: Mon, 12 Aug 2024 11:25:10 -0700 From: Kees Cook To: Brian Mak Cc: "Eric W. Biederman" , Alexander Viro , Christian Brauner , Jan Kara , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Oleg Nesterov , Linus Torvalds Subject: Re: [PATCH v3] binfmt_elf: Dump smaller VMAs first in ELF cores Message-ID: <202408121123.FBAE8191A3@keescook> References: <036CD6AE-C560-4FC7-9B02-ADD08E380DC9@juniper.net> <87ttfs1s03.fsf@email.froward.int.ebiederm.org> <202408121105.E056E92@keescook> <713A0ABD-531D-4186-822A-4555906FD7EC@juniper.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <713A0ABD-531D-4186-822A-4555906FD7EC@juniper.net> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5A512140007 X-Stat-Signature: kh14p9wpiazhkchmre4y5xe41x6j7w47 X-Rspam-User: X-HE-Tag: 1723487113-867571 X-HE-Meta: U2FsdGVkX18JhGzSpXmTnZZB2+xJ5LYQKuoCSUzyPTVfzRyBEZHhkjRMFcSUSU+SeemYheZ+/fdWfkwc8EIJy3xzYt/keWp26EI5AH7LFkZDYjDTib5sE7bKLDpX82Z9xcEgwAgYzIyoDuGt3x+MjHc0eOeJJ8SVEnzFFLU+p/Z4uDpT+rZ71YKSF/JdpSXziI7wc8vBnA8yi/9ccAhWa5fh0UGyCCh+KsRDOhjtkG2ltxV0DTkZ/DOV1ncJ6Lt+ZTAUjknRamWcXIosT8WGDDsfFbqBn3DzEsWVrVMK7BHwSNOmj9Z6cCSK+0lx7k9L6CLR22Lh9LKAMO5YTf9o/7f0GNmfI87uaUqOGpsROUCuwjaOt8xmUwx2lnBgjZj6lRcV25tCsrObk0UCUFtIG5xIDY8KXxvZ+K6U5yxD92rZnIoXPEPnDmgD6D1PuZRPOuZZq8yOAeuH6Ubvu5xYM8Bnn7zQRkownS41O7j6l0qzBqgS72FGEQxBFH12GTFH3+cu9YSlO2P+W8wgSbtGMygRtuc575qQlo9smhuAKkorS6H64Ha2NdgZHvC7SZjdgzBODsNOy/manW5LwKPa5C3KfMYOEAZx62ZzAn3gmZY/0DSZo607RIjb7f4iWotO3QYpWBI0ygtQ7bMI4A3jT5V82Opg8CjYT4/3Qtn3jHMO4ZZEz0J2TbwEceE2+/mUfZ3fR3eLIcIGYc1PxlNCSgdG/SvnGM2EnNQ28ZHZ+zXzVPrnQ6JxGS5cu7ifFWBMzXrticvBlKz5cFHY5X8KOg/taXH981FMIBGsk9fJU1ClS7hKxy3mzEv93eGs0TBpr63N/K1klL6IWCKG+T+3Y19nAWmZzG22YkXQKaBloom+ufse1Ir+LZ0fEo4CDuX2j6e+wxCAJSGW++H6jfli9AGlBbLwvv5aiyMZXzif7r4ckz448Z94bq6O+c4n6U/cqAB52ZdzrrfStdQsPzU JOLj+WE4 mRH6WHlU1c9N0bDAp5eG4k/e3OLKhjG19ZB6pDLQ6Mx14Bnd1qLCpWBNrDiTQQHKhrCoHTflBr/MLLO1r18HC3r8puWNkgqodVXek7b9/Cgg0bWJVIv/oT6NcBFwl/KtQTwJ2odB6O9a5M9l4LfHd62GczTMJ1/eccAWenfLqpziakACmiSLMTqO5L3mb0y5HSMI60VfaYwoGRpfv982BW5WY/2dJEcBoOBelJuvCXUBq6nnmV3B/octk3T8mCJX1+fIRRNhM2vPph2+UETIahzTuoQEhorBgBIStALUXZMI/0biC3C6oLBk1gYawE5YYpRygL4tIK/+WCpPiTP6GpMR8ZwBz1NNz5mY6xkr/u4k0veGVHew+JbXpxiuRNZFc/hzod84u2IxlCXuSwzRYi0MbbxO/fS6GHj/LeLsrtOwC93ku1qMzwJViCUXJg/t/k9fg08qd4/wOAeREO+jl1QIi4M4ionck8m83kyRyFI9yBtM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 12, 2024 at 06:21:15PM +0000, Brian Mak wrote: > On Aug 12, 2024, at 11:05 AM, Kees Cook wrote > > > On Sat, Aug 10, 2024 at 07:28:44AM -0500, Eric W. Biederman wrote: > >> Brian Mak writes: > >> > >>> Large cores may be truncated in some scenarios, such as with daemons > >>> with stop timeouts that are not large enough or lack of disk space. This > >>> impacts debuggability with large core dumps since critical information > >>> necessary to form a usable backtrace, such as stacks and shared library > >>> information, are omitted. > >>> > >>> We attempted to figure out which VMAs are needed to create a useful > >>> backtrace, and it turned out to be a non-trivial problem. Instead, we > >>> try simply sorting the VMAs by size, which has the intended effect. > >>> > >>> By sorting VMAs by dump size and dumping in that order, we have a > >>> simple, yet effective heuristic. > >> > >> To make finding the history easier I would include: > >> v1: https://urldefense.com/v3/__https://lkml.kernel.org/r/CB8195AE-518D-44C9-9841-B2694A5C4002@juniper.net__;!!NEt6yMaO-gk!DavIB4o54KGrCPK44iq9_nJrOpKMJxUAlazBVF6lfKwmMCgLD_NviY088SQXriD19pS0rwhadvc$ > >> v2: https://urldefense.com/v3/__https://lkml.kernel.org/r/C21B229F-D1E6-4E44-B506-A5ED4019A9DE@juniper.net__;!!NEt6yMaO-gk!DavIB4o54KGrCPK44iq9_nJrOpKMJxUAlazBVF6lfKwmMCgLD_NviY088SQXriD19pS0G7RQv4o$ > >> > >> Acked-by: "Eric W. Biederman" > >> > >> As Kees has already picked this up this is quite possibly silly. > >> But *shrug* that was when I was out. > > > > I've updated the trailers. Thanks for the review! > > Hi Kees, > > Thanks! I think you added it to the wrong commit though. Ugh. Time for more coffee. Thanks; fixed. I need to update my "b4" -- it was hanging doing the trailers update so I did it myself manually... That'll teach me. ;) > tests. Since all the other tests pass, I'm just going to leave it at > that. Yeah, I think you're good. Thank you for taking the time to test rr! -- Kees Cook