From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEC28C3DA4A for ; Sun, 11 Aug 2024 08:32:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CD2C6B008A; Sun, 11 Aug 2024 04:32:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57C486B0092; Sun, 11 Aug 2024 04:32:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46A8D6B0095; Sun, 11 Aug 2024 04:32:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 292226B008A for ; Sun, 11 Aug 2024 04:32:05 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BBB4DC1A39 for ; Sun, 11 Aug 2024 08:32:04 +0000 (UTC) X-FDA: 82439296968.07.FD31627 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id DD842C0009 for ; Sun, 11 Aug 2024 08:32:02 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=ftHBMIeA; spf=pass (imf28.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723365055; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aiDQTo5cWY9dBPUcDPrGiRMod5vyxfvPCy23pbfh4vs=; b=I68NDalVFPzxMm5n4mPA7hiBCsxUbL0UrYoJF/luEWQox/BtplS543N05EP8JoYnHbjcLD 0xKAovMcWzfAtHU28AGq0FbimMv8e9Mxp6cQ0zYq4xgPKrm0xY2X5nR48jG/sjDs7ao9Jc EJuo1LQCdhkLlMoLtGR/j4hnv2spUHE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723365055; a=rsa-sha256; cv=none; b=QbZKB/uHYUhETFqXMaMh+rPtRGprDZZHesv2TpYHHV20WfrFe8dRUjcApbyEDz7BgkvsAu c9w5XkKEHo4rJqwFt8D6kgebEnzSpfhPpPiaLDlB9qPdMsXj2RMC7VrBbylWjCLw3g1fuc l/50RbCKFLJiuXaUrzBViIDFqezjq2c= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=ftHBMIeA; spf=pass (imf28.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 60B3E60C98; Sun, 11 Aug 2024 08:32:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76943C4AF09; Sun, 11 Aug 2024 08:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723365121; bh=zLtDOM7PQ8iLss9xVrpNuIEalRTzz+iItddnV7DhAnw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ftHBMIeABzDSuJnmpzkyW86O9e3QD3QBU6PlGfguePd6wfRA4Fuz4M70NCgKtoICL jjdvLFzEB2nH1T8P60paJkE71bSTrJur5H1ekQjJphmcf+PRn9K9mlZBltX3GzySXb vMlpOgi/MnK222BMJjVDlHkVGDn7Lz0oto3i6hJ8= Date: Sun, 11 Aug 2024 10:31:57 +0200 From: Greg Kroah-Hartman To: Martin Oliveira Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Artemy Kovalyov , Jason Gunthorpe , Leon Romanovsky , Logan Gunthorpe , Michael Guralnik , Mike Marciniszyn , Shiraz Saleem , Tejun Heo , John Hubbard , Dan Williams , David Sloan Subject: Re: [PATCH v5 1/4] kernfs: add a WARN_ON_ONCE if ->close is set Message-ID: <2024081141-cattail-kick-3ff5@gregkh> References: <20240808183340.483468-1-martin.oliveira@eideticom.com> <20240808183340.483468-2-martin.oliveira@eideticom.com> <2024080933-jazz-supernova-9f3a@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DD842C0009 X-Stat-Signature: i3zp95433npfweorw4dg8pwhwaguiqhz X-HE-Tag: 1723365122-512287 X-HE-Meta: U2FsdGVkX1+fYfXKLjCtVSbkR+j7Od8mPmc+XQo59m0IqtktAVVpebEtnKDrw4gMApe3idJJmWyqoeOTp7lang+BLipPZ8FUda5eFZ2O/rsk42urvHMUS20CDhbowqIjr1JbbL6PzL2f+fX0k7fTeDvcZmvNCBoXWtvKnLCqpwnLUnP2x6Xt3bJQ/pGPkPnDA4plEh6mmqRwCqMYr0VAUEXpoeETxMznL51JYxZeOfgw/pkQok6sPvYIhW4e8QjTg06Isp/bGGjtqNXjRmga7IAu3F6t5PG1erBawA2udPNdEH9amCGk+I4CdZiZ9Z3sDnSYKl1unCEbC4lmzlAUCOgkkEPmX0yAjFlr2opKNQNDGSiJhHMWbMOEn+CtJAYbEF3wKXxX5Li+Co4xnXFcK+azVw+cjP8olQ559SsVibo9Rt5fgZVSoFnBQgt0oeQoQOVwJQ7OQOqRsReQdNuRCqxtHuUTJ71TjY5cGFC4jZyAoFpu68Fn6NPne9sImcIbMOlFWz3Q2L5I7UMx9YnhtLwt7rNvT/ax6lq/vTtPiu/I52nIWV973RNKRn9sbyDAVFDk1CJD/ReR2RUSJ7lJe1Enp/KNJRkaURM0ohLo6OEcYW1y8/HOaXrE8/o7StCgFzd/8Np1+rVQY2ohfFz2WkVDz02edhUKz8BQ5ogbxSFUTg93GX6THaTtxt7QUaHZpBZBtLRReR1Jyrb2wC5xfz8tTEguQjqR5Ma3fThwlfI06ax2j0pyzY9OSuf31VZrEJj8Qs1M7j+NvdguQ8gdj4a2T3RUDu082Z9TharER9O1Dv1HdV5eqi2Rs+XVB6+MP3d1AgGhaqc5BXGXD84B/gR+z8O+QnsoNAaDD3E1NjuLX/EKnLViqPuh2ArRSqIRbYEEwIg6vOBRF5JmtAeLfayXzw4uC4nNY7x0Tx+XlZFlkzHTPooZnBNLan8jljoYyiFs9+CDbhLCppdLCbL G6oyDj5O xDe1+XtMNp7a+gzUe4eFzVa+ihJmr3xy7J5D2/szAAr69WXhxspg2IvsAphfgskF4ETS/AaLgXD0rcrKnN2Nbp0XyqBrwRi12OHrnhDXXHPr0GF/OIzci4uCWt1YbMShETk0njIWEvcjo7X0kMvtSvKYUqg0omY/oNPqfNxtI0BPhryT/oAl4kkcLaHSOu8ABP26+o/FPeAGJ26kIuuQNksaqgCp67U/sbUzAkesMgmhEarP42oLoYdn0hVCJulK6y0+TUK4JZJGwG8sByuRvyJm7J4zWvYL1ZsKQCUomH7mUcI+IiBhpjyXKv/K22dBhonJUxqMmR6ChwUwRhQ7HKxuluCIs+iR6FcWB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 09, 2024 at 09:41:48AM -0600, Martin Oliveira wrote: > On 2024-08-08 23:37, Greg Kroah-Hartman wrote: > >> diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c > >> index 8502ef68459b..72cc51dcf870 100644 > >> --- a/fs/kernfs/file.c > >> +++ b/fs/kernfs/file.c > >> @@ -479,7 +479,7 @@ static int kernfs_fop_mmap(struct file *file, struct vm_area_struct *vma) > >> * It is not possible to successfully wrap close. > >> * So error if someone is trying to use close. > >> */ > >> - if (vma->vm_ops && vma->vm_ops->close) > >> + if (WARN_ON_ONCE(vma->vm_ops && vma->vm_ops->close)) > > > > So you just rebooted a machine that hits this, loosing data everywhere. > > Not nice :( > > Well, apologies for that, but there's no way to know what every single machine > out there is doing... > > However if this machine is using ->close when that's clearly marked as > unsupported then shouldn't we fix that? return an error properly?