From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Martin Oliveira <martin.oliveira@eideticom.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Artemy Kovalyov <artemyko@nvidia.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
Logan Gunthorpe <logang@deltatee.com>,
Michael Guralnik <michaelgur@nvidia.com>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Tejun Heo <tj@kernel.org>, John Hubbard <jhubbard@nvidia.com>,
Dan Williams <dan.j.williams@intel.com>,
David Sloan <david.sloan@eideticom.com>
Subject: Re: [PATCH v5 1/4] kernfs: add a WARN_ON_ONCE if ->close is set
Date: Sun, 11 Aug 2024 10:31:57 +0200 [thread overview]
Message-ID: <2024081141-cattail-kick-3ff5@gregkh> (raw)
In-Reply-To: <a9468d88-c2e9-431c-a2bc-847ce9743729@eideticom.com>
On Fri, Aug 09, 2024 at 09:41:48AM -0600, Martin Oliveira wrote:
> On 2024-08-08 23:37, Greg Kroah-Hartman wrote:
> >> diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c
> >> index 8502ef68459b..72cc51dcf870 100644
> >> --- a/fs/kernfs/file.c
> >> +++ b/fs/kernfs/file.c
> >> @@ -479,7 +479,7 @@ static int kernfs_fop_mmap(struct file *file, struct vm_area_struct *vma)
> >> * It is not possible to successfully wrap close.
> >> * So error if someone is trying to use close.
> >> */
> >> - if (vma->vm_ops && vma->vm_ops->close)
> >> + if (WARN_ON_ONCE(vma->vm_ops && vma->vm_ops->close))
> >
> > So you just rebooted a machine that hits this, loosing data everywhere.
> > Not nice :(
>
> Well, apologies for that, but there's no way to know what every single machine
> out there is doing...
>
> However if this machine is using ->close when that's clearly marked as
> unsupported then shouldn't we fix that?
return an error properly?
next prev parent reply other threads:[~2024-08-11 8:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 18:33 [PATCH v5 0/4] Enable P2PDMA in Userspace RDMA Martin Oliveira
2024-08-08 18:33 ` [PATCH v5 1/4] kernfs: add a WARN_ON_ONCE if ->close is set Martin Oliveira
2024-08-09 5:37 ` Greg Kroah-Hartman
2024-08-09 15:41 ` Martin Oliveira
2024-08-11 8:31 ` Greg Kroah-Hartman [this message]
2024-08-12 6:38 ` Christoph Hellwig
2024-08-12 6:38 ` Christoph Hellwig
2024-08-08 18:33 ` [PATCH v5 2/4] kernfs: remove page_mkwrite() from vm_operations_struct Martin Oliveira
2024-08-12 6:38 ` Christoph Hellwig
2024-08-08 18:33 ` [PATCH v5 3/4] mm/gup: allow FOLL_LONGTERM & FOLL_PCI_P2PDMA Martin Oliveira
2024-08-12 6:39 ` Christoph Hellwig
2024-08-12 23:12 ` Jason Gunthorpe
2024-08-13 5:41 ` Christoph Hellwig
2024-08-13 16:05 ` Jason Gunthorpe
2024-08-13 17:03 ` Dan Williams
2024-08-14 0:02 ` Jason Gunthorpe
2024-08-14 4:26 ` Christoph Hellwig
2024-08-15 16:38 ` Jason Gunthorpe
2024-08-08 18:33 ` [PATCH v5 4/4] RDMA/umem: add support for P2P RDMA Martin Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024081141-cattail-kick-3ff5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=artemyko@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=david.sloan@eideticom.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=martin.oliveira@eideticom.com \
--cc=michaelgur@nvidia.com \
--cc=mike.marciniszyn@intel.com \
--cc=shiraz.saleem@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox