From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36EEEC3DA4A for ; Sun, 11 Aug 2024 07:09:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BC306B008A; Sun, 11 Aug 2024 03:09:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86C206B0092; Sun, 11 Aug 2024 03:09:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75A676B0095; Sun, 11 Aug 2024 03:09:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 57AA56B008A for ; Sun, 11 Aug 2024 03:09:11 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D3F06A7E21 for ; Sun, 11 Aug 2024 07:09:10 +0000 (UTC) X-FDA: 82439088060.20.910E0E6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 283DB120025 for ; Sun, 11 Aug 2024 07:09:08 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="HnNS/Pp9"; spf=pass (imf29.hostedemail.com: domain of Neeraj.Upadhyay@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=Neeraj.Upadhyay@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723360080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aNmf6NfIQJKvIpFzLRPLRig7GM7CzHwgME6v0WnperE=; b=XllVuDKPnDxG0wZrhnPZ0wqom7lxCdq4hyKqL+6d0Y7GiXbajGFQ+Sm+d0qDeTDqmdbw14 1XZt508lgaudRgaJh97+E4kzcsC+e1iQ21fWcLPJQZsr/Zwu8mK0jqR5RyqKXWyMpWPi5W 6iEBBqoPXlEBf20vuXERg33m1H0xUM0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723360080; a=rsa-sha256; cv=none; b=i3vRyj7HJWsQAZCWYAulv9O/qjot60rR3oaNOwLEUoTmHT8TvNH9Te4+saV987LYDfTDIy eFXwYyQU42ktVYC5oUSbbKJ6x34ElXtv1oagIHW7fzjNcNmYxKa+kaboNsnT1ccKbf2aDs oY5CyoOnbWHkSocYQpjGz5ScIpeYebM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="HnNS/Pp9"; spf=pass (imf29.hostedemail.com: domain of Neeraj.Upadhyay@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=Neeraj.Upadhyay@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id ECB4060C83; Sun, 11 Aug 2024 07:09:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C5D0C4AF0C; Sun, 11 Aug 2024 07:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723360147; bh=HzUn46edg0BlXhUZG0jfiBG5N65tmpo0nKxL2EGqm8I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HnNS/Pp9HIymhgFSOgcObB4Q/EjwnCSKaXwbmVW+C7wegY7oidb0Ze1LRWk+6upl9 PYboGeq3l1vsj3vfjD4KSqmNDuFBAduw+esO+dzvOxiFHthXsZqx04CZyAUpQc/VwJ kgN0kmuW1riZ97c9mzj5ZGH3LGZ25QxJFvQRJ6QlYM0TLZBHe4ZAkO1sxDDvckpmGZ L+iJ0fQoeAi5vjzPeX2V75i4/tkXTsGBwP9lIPZ2P/4t2p48FOZColc+e3nFoLcLa0 9z5kynvHCxIQ75t6wFusdgLpH08xeU+SBCwepQfFaIFeTq1xWUO94A+vKRSrfL2q6H UYngiEgA8lrSA== Date: Sun, 11 Aug 2024 12:38:59 +0530 From: Neeraj Upadhyay To: kernel test robot Cc: "Paul E. McKenney" , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Neeraj Upadhyay Subject: Re: [linux-next:master 3246/3984] kernel/rcu/rcuscale.c:303:2: error: call to undeclared function 'rcu_tasks_torture_stats_print'; ISO C99 and later do not support implicit function declarations Message-ID: <20240811070859.GA977168@neeraj.linux> References: <202408110343.A2yLpRdP-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202408110343.A2yLpRdP-lkp@intel.com> X-Stat-Signature: px5wgu4oqpxjonzh4asrfjxemhek6smd X-Rspamd-Queue-Id: 283DB120025 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1723360148-186136 X-HE-Meta: U2FsdGVkX18SND0PBVvbbhwPe8Asv7F99amg/KYhHtSm7UjS88dtmztrBD2WhjaEVe4YRmsxAl0cZ5H6I7/nnbLPQFBopWnmuv6rxwl8WIsgWI4jV7H6WRtSvOhTBdjuijNxgrP8Yawea94q26lcOgq+vqK4cKNJjneFXc1h9W1M9G6S3niLEt+HMnljMVT5ijs7Llh5XL6Ej3Oktp3yAGMn+FF36blNgH3gOS1pZ2J2d9vfTPD3I4GZS92jm0dUIgi9jwENQ4edjVGP8h69xfPkA6ptuRzwNHNVhSL7UdqVLhwn6IERC1a2U3WeSesPhhu1MBpNlKWGZaykfe+c6XEJNGgq3arVbVXmeV98D87GY64kxbCqh0ASwyecCoND78p4ErO7HunCJdSm61jJXxbkjxHm7ylKeb7gc+i52gGdqRJtFdDuTOPpH3Hw52OTZFCv6loQSve2J4vudyJLRl0w+QIgMzKmxO1nxUTwJJKqCWLT5R2jePOpfqFcFRrQDJpXc79TG5daeRN42VM5fc6XzCxN7/gzgACOAmC1khA37YGaWeS1xRGUn90yu7ZIGsngVMQhBqoKRYivX3JYPG1epSsu0nr2NYfBPQzYzY/HBgR3+1Jb/cbkbxTOYjLxH9woHwJdQJuGp3o1c6LO+kvCBwchtGaxQ31G0/w/3xp5pY7FnpL1QlOJV+YaayXFWCfx2f4/LhwDCcPs+XDRIxK71b5Q3j96cXHTM46orKqKEjFj9Dc+0aJhdfKyMui80mnVUwAN1ASVyXGcl7fz0BqGQnvB+p8lXop/P0lz/OEQzyqK3cvGOL5wPQeH67/q3uvhzS1TCnsBSjThQ6QPxtPJcNe4GaCgBDKiH/NYH80D6O/Hxhaqdtc13oeC9mn8G1qfGOO7GAjU+hmfPpnDr5o334QBeMDZmnAZOt8KeU3eip5I/FeIZxjEQJXl3Qxo9SCyF+RQeFvY6jqbOZo WSVflVFU Aw8T3bZubJaHUuhYit1dBZnXcHv+Qca7+taoujFe13FNcfRBz2Ockqdsgc2SeUFKM6ZCado+DpCYfopuhP3mfJL3CIIoifcGdl4lsdlHa7xTMGsMLvuSBG4iB0xwKWYuowNkRfVFglD1lU/V0NXk3FkANcGX3yhaqiu1y8fJCW8+CR86lVbZy53mPOLujTGqm1sYamaXHQpvEhsbtAQqE+8oyIM6785w9yjr6J+8vV/pN55SO/zgorrphBSZMiBEYLxm0Hg78zSXAGHQFj4pnNep+XYFo0UDuTm9693P2H8aMiRAbOkA5sr5LqF+ndmb5lDo99FTikuiT4mhckKftFRzVaZRdragpK+tWBXN1e1yl0z02UaJP6E8yVonyN2JckehY3vJE7wwLQ9Xw0iTNuTWyYZP8vaFSd1NA/oOofGKdhXU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Aug 11, 2024 at 03:55:37AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 61c01d2e181adfba02fe09764f9fca1de2be0dbe > commit: 628ea78b8d1057d4709b38730a1f181e9607ad23 [3246/3984] rcuscale: Print detailed grace-period and barrier diagnostics > config: x86_64-randconfig-074-20240809 (https://download.01.org/0day-ci/archive/20240811/202408110343.A2yLpRdP-lkp@intel.com/config) > compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240811/202408110343.A2yLpRdP-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202408110343.A2yLpRdP-lkp@intel.com/ > > Note: the linux-next/master HEAD 61c01d2e181adfba02fe09764f9fca1de2be0dbe builds fine. > It may have been fixed somewhere. > Thanks for reporting this! I have fixed the order of below 2 commits here [1] cb4b877e9d5f rcu/tasks: Add detailed grace-period and barrier diagnostics d9562675f501 rcuscale: Print detailed grace-period and barrier diagnostics [1] https://git.kernel.org/pub/scm/linux/kernel/git/rcu/linux.git/log/?h=next - Neeraj > All errors (new ones prefixed by >>): > > >> kernel/rcu/rcuscale.c:303:2: error: call to undeclared function 'rcu_tasks_torture_stats_print'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > 303 | rcu_tasks_torture_stats_print(scale_type, SCALE_FLAG); > | ^ > kernel/rcu/rcuscale.c:303:2: note: did you mean 'srcu_torture_stats_print'? > include/linux/srcutree.h:192:6: note: 'srcu_torture_stats_print' declared here > 192 | void srcu_torture_stats_print(struct srcu_struct *ssp, char *tt, char *tf); > | ^ > >> kernel/rcu/rcuscale.c:347:2: error: call to undeclared function 'rcu_tasks_rude_torture_stats_print'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > 347 | rcu_tasks_rude_torture_stats_print(scale_type, SCALE_FLAG); > | ^ > >> kernel/rcu/rcuscale.c:393:2: error: call to undeclared function 'rcu_tasks_trace_torture_stats_print'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > 393 | rcu_tasks_trace_torture_stats_print(scale_type, SCALE_FLAG); > | ^ > 3 errors generated. > > > vim +/rcu_tasks_torture_stats_print +303 kernel/rcu/rcuscale.c > > 300 > 301 static void rcu_tasks_scale_stats(void) > 302 { > > 303 rcu_tasks_torture_stats_print(scale_type, SCALE_FLAG); > 304 } > 305 > 306 static struct rcu_scale_ops tasks_ops = { > 307 .ptype = RCU_TASKS_FLAVOR, > 308 .init = rcu_sync_scale_init, > 309 .readlock = tasks_scale_read_lock, > 310 .readunlock = tasks_scale_read_unlock, > 311 .get_gp_seq = rcu_no_completed, > 312 .gp_diff = rcu_seq_diff, > 313 .async = call_rcu_tasks, > 314 .gp_barrier = rcu_barrier_tasks, > 315 .sync = synchronize_rcu_tasks, > 316 .exp_sync = synchronize_rcu_tasks, > 317 .rso_gp_kthread = get_rcu_tasks_gp_kthread, > 318 .stats = IS_ENABLED(CONFIG_TINY_RCU) ? NULL : rcu_tasks_scale_stats, > 319 .name = "tasks" > 320 }; > 321 > 322 #define TASKS_OPS &tasks_ops, > 323 > 324 #else // #ifdef CONFIG_TASKS_RCU > 325 > 326 #define TASKS_OPS > 327 > 328 #endif // #else // #ifdef CONFIG_TASKS_RCU > 329 > 330 #ifdef CONFIG_TASKS_RUDE_RCU > 331 > 332 /* > 333 * Definitions for RCU-tasks-rude scalability testing. > 334 */ > 335 > 336 static int tasks_rude_scale_read_lock(void) > 337 { > 338 return 0; > 339 } > 340 > 341 static void tasks_rude_scale_read_unlock(int idx) > 342 { > 343 } > 344 > 345 static void rcu_tasks_rude_scale_stats(void) > 346 { > > 347 rcu_tasks_rude_torture_stats_print(scale_type, SCALE_FLAG); > 348 } > 349 > 350 static struct rcu_scale_ops tasks_rude_ops = { > 351 .ptype = RCU_TASKS_RUDE_FLAVOR, > 352 .init = rcu_sync_scale_init, > 353 .readlock = tasks_rude_scale_read_lock, > 354 .readunlock = tasks_rude_scale_read_unlock, > 355 .get_gp_seq = rcu_no_completed, > 356 .gp_diff = rcu_seq_diff, > 357 .async = call_rcu_tasks_rude, > 358 .gp_barrier = rcu_barrier_tasks_rude, > 359 .sync = synchronize_rcu_tasks_rude, > 360 .exp_sync = synchronize_rcu_tasks_rude, > 361 .rso_gp_kthread = get_rcu_tasks_rude_gp_kthread, > 362 .stats = IS_ENABLED(CONFIG_TINY_RCU) ? NULL : rcu_tasks_rude_scale_stats, > 363 .name = "tasks-rude" > 364 }; > 365 > 366 #define TASKS_RUDE_OPS &tasks_rude_ops, > 367 > 368 #else // #ifdef CONFIG_TASKS_RUDE_RCU > 369 > 370 #define TASKS_RUDE_OPS > 371 > 372 #endif // #else // #ifdef CONFIG_TASKS_RUDE_RCU > 373 > 374 #ifdef CONFIG_TASKS_TRACE_RCU > 375 > 376 /* > 377 * Definitions for RCU-tasks-trace scalability testing. > 378 */ > 379 > 380 static int tasks_trace_scale_read_lock(void) > 381 { > 382 rcu_read_lock_trace(); > 383 return 0; > 384 } > 385 > 386 static void tasks_trace_scale_read_unlock(int idx) > 387 { > 388 rcu_read_unlock_trace(); > 389 } > 390 > 391 static void rcu_tasks_trace_scale_stats(void) > 392 { > > 393 rcu_tasks_trace_torture_stats_print(scale_type, SCALE_FLAG); > 394 } > 395 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki