From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2830EC3DA4A for ; Fri, 9 Aug 2024 05:37:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A48A96B0089; Fri, 9 Aug 2024 01:37:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F8D56B008A; Fri, 9 Aug 2024 01:37:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E7496B008C; Fri, 9 Aug 2024 01:37:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6F4476B0089 for ; Fri, 9 Aug 2024 01:37:58 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 20BC3A0993 for ; Fri, 9 Aug 2024 05:37:58 +0000 (UTC) X-FDA: 82431600636.20.2BBA027 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 7571940013 for ; Fri, 9 Aug 2024 05:37:55 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Ja+Tlyoq; spf=pass (imf12.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723181788; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rPmniOXzsb5S3hN4MqE4JOMFlIfEiVtKVpMcEAs9Wrc=; b=Zs50OWprjgM/m2VlDpvslSUeXDmV1XJC9mOVh+N4lma5wnEuq7GIkPp+EYABsMm0NeB404 /9TjTHZyVXA6r6RI31S6Q7fJud0UWdTQmMnKnzvilYIN9iF16QIKU12V1ByJkaJWG8vcwp u007bfAgoB7xUKrkZdsKaWGoxAP7kKk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Ja+Tlyoq; spf=pass (imf12.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723181788; a=rsa-sha256; cv=none; b=33ei+WPo5wQYM5Qs2JqFfp9MvwwEu2yzAFxa6tFXlgScCO0+cVcKcsLKH61VZMqiR7N7la kxoF+A3akt/GT7sT2tYHBHOXaxOmowVT1Utqger3LSxpXKGXSjyWB9xpTf8PYeSVdJkbHC xMJz1PJvSLxHV421hxOu46nKfUMScho= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 447D76163B; Fri, 9 Aug 2024 05:37:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B4CEC32782; Fri, 9 Aug 2024 05:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723181874; bh=lOZtihui0k4mla/fwJ1SNSDDA5JTGeFOJpE/zRPr7lI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ja+TlyoqL0I/er2EtwIN4JTQMRt46xrIy6SHLUTkaWucveylKEtv6fCgp0QsIIu5S uW4JUdOXIRUDPwYg4E+zaaRKkDuEvZ5QX7qgMMmCVmTFai624T1WvUNvhtA7Nd6oXm UqGTQUWNWrx4jf4K3Y5ja+D4LIc6uc/g6u9n6F30= Date: Fri, 9 Aug 2024 07:37:49 +0200 From: Greg Kroah-Hartman To: Martin Oliveira Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Artemy Kovalyov , Jason Gunthorpe , Leon Romanovsky , Logan Gunthorpe , Michael Guralnik , Mike Marciniszyn , Shiraz Saleem , Tejun Heo , John Hubbard , Dan Williams , David Sloan Subject: Re: [PATCH v5 1/4] kernfs: add a WARN_ON_ONCE if ->close is set Message-ID: <2024080933-jazz-supernova-9f3a@gregkh> References: <20240808183340.483468-1-martin.oliveira@eideticom.com> <20240808183340.483468-2-martin.oliveira@eideticom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240808183340.483468-2-martin.oliveira@eideticom.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7571940013 X-Stat-Signature: 3fexbxoj8sm1yjz9pbpag8weqshbudzz X-Rspam-User: X-HE-Tag: 1723181875-445105 X-HE-Meta: U2FsdGVkX18b+FsQTc3m096TxMk1bVWIXbsZygm2yomdErplXU4HrD5YmUxSfMNTfVaFTfFX9yVrzRvKMWfURocTDfxU3yXhO4CSY8h3qGTwp+BMDsyBRRDmqMvPjcr/h77UOVm89TqZZK+YknBv0jCOzU4akveLZWxN8VnP4jk0cAwO5O5gvUa8dpk8DZOLYzeiGWBUO6GNdPdLTR4gGt9+0gtjw8POoPwge59bwOJTwA0GVt9G2aFiWt8ELEo58z9fOl7+VCv2mWKj1+Ps7tEhe2s9CVCiqq47sXcdaEEBY7Wvevt7SOnSUNSNkSsSiTP+z+r7nHmDdPf5P3mDcuGcZiXe4SMU26stRqkYYlV2TwtFYnXjeGN+qolKEdjvLvKGrkXrwgJcECeiKkq+xGhpHIDQ7+sDr8HNt9PKOn5lGJZAw7btpvttMRihg1ZaDY9L4COrRv2MHPSSozsr+REkF2qxUFbRrvUe+WlXaY/LbrADTy0Wa3FOvfQxxItuba9W+ZCQfr70sKqJqist59mznALJEqyNnIbyzSNEDxLEUpRh6pPTGmFhB4DOqKuEvxUvQI/G4RzgFG6i05QNwSzTfQXacsWY4HrKLIZ2U2uh5Equek4d6L0QURAb8zpSHW/I8Qam7NdVYgT1TAzZGUxG6RGNX+q36zA+fg+cvHrKC1GsgSfRzejqf3yR/gWdJ+yMxgFGzGsUDxrxvcysvpPk4Z3X+wac42AtxqwbVgtwxu77pJ4DqBcnJsY7KcYNRjhaj+qQ4jy4zivOhSunrxSR/GjN8aysFE0WKhn/k2y/tRncZsBYHADWmE8ek3CDf8HRQrfjdILc6xgITAJpB1wiBE+zAxTHILK6VHeBzmdxmTeAWgE7HbAgTqBSU7ODZ1D+51UoVV4QDhuXHsMbB29MMMyTZrwq8limW02TJn1abii05PrnsSZ11AFDthUCFS/mRAtlnKtQhjJ7c/T l/TWEgZL gMQNdlLRnH+3/FvpMw50UUk+8cseaY1q8AftVYhuMJEsvIGxoPVgA8HiSrR5O6yRCxfQTNvIqYAaxs+mwvLq2KNqZH7WTn87pEbaYZPgfd3PBpbVYO4PIWKwryS2MsZRNMnb0OIOWxReugWvzmBtPm4ilyQgsHQLtitk4fd9JbaQtRDphZB3jUAJRtkii1dilKCtmp2Qg+PCNmkoAWQcNcO3oVtblhBCqHZbEXvcVdNUhQlTYI8k4EEoci0hS4f2yWK5B2MahAA0WUvQ5neNVIiWU09b54alwruMKJczQXON2gwmcK6PVMl1VM15sc+Y0bX8PaKgn8kGnqVHS9NAJ+fBLFd9L/hPfV80Tp4SN5gciZaZnc1uBExdOaDl+bZFkenMwrDkinxwE/tAF2pY0y06yv1sNuuJGMq0Sx3TiCnT7+C/rIxTpTaq/ka7YZOtZL3EItf4pSQRD3acZ3JfDh8UJOA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 08, 2024 at 12:33:37PM -0600, Martin Oliveira wrote: > The next patch is going to remove .page_mkwrite from kernfs and will > WARN if an mmap implementation sets .page_mkwrite. > > In preparation for that change, and to make it consistent, add a WARN to > the ->close check. > > Co-developed-by: Logan Gunthorpe > Signed-off-by: Logan Gunthorpe > Signed-off-by: Martin Oliveira > --- > fs/kernfs/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c > index 8502ef68459b..72cc51dcf870 100644 > --- a/fs/kernfs/file.c > +++ b/fs/kernfs/file.c > @@ -479,7 +479,7 @@ static int kernfs_fop_mmap(struct file *file, struct vm_area_struct *vma) > * It is not possible to successfully wrap close. > * So error if someone is trying to use close. > */ > - if (vma->vm_ops && vma->vm_ops->close) > + if (WARN_ON_ONCE(vma->vm_ops && vma->vm_ops->close)) So you just rebooted a machine that hits this, loosing data everywhere. Not nice :(