From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 695BCC52D71 for ; Fri, 9 Aug 2024 07:04:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C8746B0089; Fri, 9 Aug 2024 03:04:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 778AB6B008A; Fri, 9 Aug 2024 03:04:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 619396B008C; Fri, 9 Aug 2024 03:04:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3E82B6B0089 for ; Fri, 9 Aug 2024 03:04:34 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A2A2AA5AC0 for ; Fri, 9 Aug 2024 07:04:33 +0000 (UTC) X-FDA: 82431818826.28.F00E12C Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf11.hostedemail.com (Postfix) with ESMTP id B04C44002D for ; Fri, 9 Aug 2024 07:04:31 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kZ02deMM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723186998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EdToOVR8R9qNO1x23qVgI+jyK3cSKVgY8O7SCriXr6I=; b=2o+5vp6sIQO2F8OUhaoUtgOUxMN23jNlqfht7w7Ru1l8Q1Fm/Mpt30UW3bbgsR0RVcd9Ub ZGGjmBaLCf8Q2am67XyVWrh7XPpv7vKaS0yTcWPXH0eC3bkYNpEE0K3mK55aqfZOok9DJZ VJh+7QNQeIxaR8Oj49dRGiWPhbnBPeE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723186998; a=rsa-sha256; cv=none; b=ze8UHi2HP0UcfbWDTRqMLL8kdfVICTYlEb3KMczmwZf5s4qDVyCMa6mxAlGFxYB+E6dLJh I7IShHl2s3J4978lC4tTGBVFQo0UT0FoN6JEt8rhMK5nyXhIggNbpKb/smipmRhWlLrXlN Bh+baSlmFcRq7/mtNnfDA4jqdBhMoIg= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kZ02deMM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=21cnbao@gmail.com Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-7107b16be12so1475062b3a.3 for ; Fri, 09 Aug 2024 00:04:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723187070; x=1723791870; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EdToOVR8R9qNO1x23qVgI+jyK3cSKVgY8O7SCriXr6I=; b=kZ02deMMhm15f1kd6aVkTMORv+5r4dKrlYgs/rtgRDrUrLQCeh37ndIii3QDG8CFhp +LdGh+rFz24kKU9MOD5anUWEyuRI6C+0kLKM/jk5nQnhPjzQlE8NeELz3yMoAZE4/HxO BTJDWmJ9cdfITjXN4Dog5u6rSVniczY6S3CLPYDTA+ejYIMgkxcMjwZmw6H1DFEguqBu 1FsHWDNOLb8ut8bc9I8u7AapI3nhiJ9IvVmipe148WoeT3HFY6L3C/GUGrBl/b8OBKvc zljcz3kh6FovgffW5udlsBPZF/nQiZkW2mvGk36NJwBf/6L0tNqOS833AuV23OGUYA/X u0uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723187070; x=1723791870; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EdToOVR8R9qNO1x23qVgI+jyK3cSKVgY8O7SCriXr6I=; b=lQhv/IoXfxMnIhQN1DZoNxEEKtY7rn0jj6Tz//pfxLE3nxAoDzoXYMstLAOnlTQ5Hi l9GtFjs6r2WrS77Wp+RkqdAtc9n0vMclbXFrwTMnmZWOu8Us3/woW8UZ3C3+kHT1m/If muznTQDevwU93ICA4rK9/R+K9XyUGoT/JL2LiLpMT75viyNwMFzeHiYIa5IZ/+7PGige PHrffr5VviRxveTma8YoCHtM52r2aekcp71Ft+raHESC9mG2p2fCxY57njwqcJM0tBZn MiUxBy3qot2IjWtdyyJ+xBT6w6OVvmso53hJPHZ1NuzRVSj3JIqQfy/FdbQriMXbvpVO 4qhg== X-Forwarded-Encrypted: i=1; AJvYcCUdQNvu93wnAMnluqt4eBvoVk5Ckz9eMcg2APYwRDx7ll52pM/096Xfwekn7UOSaK7bsXYmekwnIi/DCBZYDylof1I= X-Gm-Message-State: AOJu0Yw/GdJr2uF2aLMTv81i+R0NsaazQfvxy0fd4eQulSTI76L7BGqK KE5RF3SkCl/VfWrwfYuuA8pEBXLthsKlFiQvpuL2ylVfgjvJBli+ X-Google-Smtp-Source: AGHT+IEwKsXDwp1MzgW55+Gy4FSYeUfuHdbLgCuhROOzqo65n48JsgvZeIUX9OxU0djNpboUXXFabg== X-Received: by 2002:a05:6a20:43a0:b0:1c4:7a11:9ef1 with SMTP id adf61e73a8af0-1c89fe9cf92mr900759637.15.1723187070285; Fri, 09 Aug 2024 00:04:30 -0700 (PDT) Received: from localhost.localdomain ([2407:7000:8942:5500:aaa1:59ff:fe57:eb97]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-710cb20a025sm2066787b3a.34.2024.08.09.00.04.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 00:04:29 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: david@redhat.com Cc: akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, hanchuanhua@oppo.com, ioworker0@gmail.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ryan.roberts@arm.com, v-songbaohua@oppo.com, ziy@nvidia.com Subject: Re: [PATCH RFC 1/2] mm: collect the number of anon large folios Date: Fri, 9 Aug 2024 19:04:12 +1200 Message-Id: <20240809070412.33847-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <41b49313-5804-46ba-9e1d-358b079274cd@redhat.com> References: <41b49313-5804-46ba-9e1d-358b079274cd@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B04C44002D X-Stat-Signature: myfa3xjtq5gi3h1eh4qen9ndmend3asa X-Rspam-User: X-HE-Tag: 1723187071-334430 X-HE-Meta: U2FsdGVkX1/+5uSiPIexychSAnEbjCwc/Q+JeEmMBQXeXKWK3Hfm3nYgEB1I8DcdEMADl2PsxK3xw/nl7xwMRepDZuF2MahYY1H9dmPMqw6TF2yxmq8yodmpZuPsTodOi69AnqGMClkQ1e7gyHFyBIdmn/FA9q7wiQ/ZggMuBdW2LBrnPt308fshswY/NZarc7HVf5XR7ERuXntkuBaf16fgig1YH/1FeC/6lUj/oLtj7mVfDv3qKsir3XubTrgDZoWbp63uPjOwskn/DRzkeibCCtXbziP5wSNdK44crDbVLfFmwYSIW8DBcV09xuRxNcwsWFuyQfYkbRJdNh3077lbLCRsx0VbQ1Oy/AP5/NynA/72OZcAYuKb0fqOrYefeW6VOhZ1pPv7DEC+Qr2xxNoLsAOzNUWRi/Q5rmHFwqRQ1P6MVIl2iMSRSDl7RefywE4nLz/5IZuiXRV/5NNqnS9swuxjhOGBprHTOnz5oE2doyWJnXFBxrGKXxHfLa95E/Hk58cCMaedaa2AFvuplMftjC9a7rLit4NT8siCYcGumguWxiwXoZl90/s7ttNfNaBlbyVW6p2LQillHeJigEo9cgoirE7jlfzibF/+Kmdx5QgaMny8wCT1GezSKFH5Xl8YOB3vCfbK0Gw1VtHXNX9iJ17mSNDhPfCKprmy+sbtPN/5gwfEBal9VBaBunqANOecuN0wKYNhnAo/gm1Eb6KQILOFFWE3datCK3w9k5gxaBTUqXyKCtzv+xT5nc0NM777/0tr0R7B8XfnCkWBy5imdzULg0J76NaqDgVWB0+yq87E37fBDEOorWQFTpokVl83PznmBi7U2+9frVRHpTQRQoclKMOQ860lChl2VSy3mTsgE3VoS3FktyYNb86nXH/NKDcJfUTzUkNagPQTHFl6AW087e9/ca0LLR9qSp+LbBMxpGMOI+kzg4yRKa5OQKC7ij1a3wtBskpTp5g W6ZTTzko pmFKNLtqpStr3vd9aUReQ5aSj0WOWEXCziR8xT371nJ8b8IJoXJI6KIDWh82HWG1rWpZgkTFlZCcDstmwV7oe2XVZ/bC1jJ+tBidO+sBYilhdj43V2fFTl2987YoZAStm7nYXeCUKx/eoh3hwubU15Zvwen7UyecX63RSMqdTBIcdG6bz4iNlpv2YRp29dZzp0PRkW+PIi2AJ3VqxZMRXiajpc2hW9REiu7VD2m7d5sYymejIT9W9EjKeMCTv7UzEwcmqwe8fNWSLr1jG/R1noNWBp1ZS+fymiiYDnJwK42bdn8cdgxggxZXUzmJURKk6TQ9Q0RxIGKqViwqWyKN7ZPWWq8o1ivQ3v3IyUOr/gCKokVULLl8mf/wJzQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > >> I would appreciate if we leave the rmap out here. > >> > >> Can't we handle that when actually freeing the folio? folio_test_anon() > >> is sticky until freed. > > > > To be clearer: we increment the counter when we set a folio anon, which > > should indeed only happen in folio_add_new_anon_rmap(). We'll have to > > ignore hugetlb here where we do it in hugetlb_add_new_anon_rmap(). > > > > Then, when we free an anon folio we decrement the counter. (hugetlb > > should clear the anon flag when an anon folio gets freed back to its > > allocator -- likely that is already done). > > > > Sorry that I am talking to myself: I'm wondering if we also have to > adjust the counter when splitting a large folio to multiple > smaller-but-still-large folios. Hi David, The conceptual code is shown below. Does this make more sense to you? we have a line "mod_mthp_stat(new_order, MTHP_STAT_NR_ANON, 1 << (order - new_order));" @@ -3270,8 +3272,9 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, struct deferred_split *ds_queue = get_deferred_split_queue(folio); /* reset xarray order to new order after split */ XA_STATE_ORDER(xas, &folio->mapping->i_pages, folio->index, new_order); - struct anon_vma *anon_vma = NULL; + bool is_anon = folio_test_anon(folio); struct address_space *mapping = NULL; + struct anon_vma *anon_vma = NULL; int order = folio_order(folio); int extra_pins, ret; pgoff_t end; @@ -3283,7 +3286,7 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, if (new_order >= folio_order(folio)) return -EINVAL; - if (folio_test_anon(folio)) { + if (is_anon) { /* order-1 is not supported for anonymous THP. */ if (new_order == 1) { VM_WARN_ONCE(1, "Cannot split to order-1 folio"); @@ -3323,7 +3326,7 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, if (folio_test_writeback(folio)) return -EBUSY; - if (folio_test_anon(folio)) { + if (is_anon) { /* * The caller does not necessarily hold an mmap_lock that would * prevent the anon_vma disappearing so we first we take a @@ -3437,6 +3440,10 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, } } + if (is_anon) { + mod_mthp_stat(order, MTHP_STAT_NR_ANON, -1); + mod_mthp_stat(new_order, MTHP_STAT_NR_ANON, 1 << (order - new_order)); + } __split_huge_page(page, list, end, new_order); ret = 0; } else { diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 408ef3d25cf5..c869d0601614 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1039,6 +1039,7 @@ __always_inline bool free_pages_prepare(struct page *page, bool skip_kasan_poison = should_skip_kasan_poison(page); bool init = want_init_on_free(); bool compound = PageCompound(page); + bool anon = PageAnon(page); VM_BUG_ON_PAGE(PageTail(page), page); @@ -1130,6 +1131,9 @@ __always_inline bool free_pages_prepare(struct page *page, debug_pagealloc_unmap_pages(page, 1 << order); + if (anon && compound) + mod_mthp_stat(order, MTHP_STAT_NR_ANON, -1); + return true; } diff --git a/mm/rmap.c b/mm/rmap.c index 8d432051e970..982862cbf5ba 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1467,6 +1467,7 @@ void folio_add_new_anon_rmap(struct folio *folio, struct vm_area_struct *vma, } __folio_mod_stat(folio, nr, nr_pmdmapped); + mod_mthp_stat(folio_order(folio), MTHP_STAT_NR_ANON, 1); } static __always_inline void __folio_add_file_rmap(struct folio *folio,