From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61166C52D73 for ; Thu, 8 Aug 2024 21:41:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9CAF6B009A; Thu, 8 Aug 2024 17:41:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4CC96B009C; Thu, 8 Aug 2024 17:41:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BED036B009E; Thu, 8 Aug 2024 17:41:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A14366B009A for ; Thu, 8 Aug 2024 17:41:35 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4B89C1A0173 for ; Thu, 8 Aug 2024 21:41:35 +0000 (UTC) X-FDA: 82430400150.07.591E9D3 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf03.hostedemail.com (Postfix) with ESMTP id 1B38F2002F for ; Thu, 8 Aug 2024 21:41:32 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=VCMc1MOo; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf03.hostedemail.com: domain of quic_eberman@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_eberman@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723153220; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yzRuJMoAZ9lO0AnlBJXQ65P+OT5URHclW0jsSuS9+i0=; b=A3+LNDAfqkn8qkcIqQ+bHdIiBTNFB3+1EAYb3Jcly7NSqa4o4UUJ5QGcqy3p3C0yb002X3 u+94DgA1lnAA2+3IC2nCnzF+GzhgsoSho8M5UcGshmaxVp08xorl3fcyL8I2B3D1ooJGU+ zWaNXiydxgwOnDLEbtEoLn5XiNSAPsQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723153220; a=rsa-sha256; cv=none; b=3qrfEfcSjJRLB+T6iQeItZqn4Iy02P7Xfq01LzGSVdWYQzJ5WgmRE26xqI3sb+UeqyuaoD 1BmvHLKNtQkUTxlygzFbKLGTUup3LCV5dLgfiHLQzWod51RsOK4nTY4+drpHvauL7O2ynQ yz2iS8Ng8PYFFWJCe66WGY0uDhCrzS8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=VCMc1MOo; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf03.hostedemail.com: domain of quic_eberman@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_eberman@quicinc.com Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4789kCvp015673; Thu, 8 Aug 2024 21:41:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=yzRuJMoAZ9lO0AnlBJXQ65P+ OT5URHclW0jsSuS9+i0=; b=VCMc1MOorbejCZcF06LV/yx91VH22tyBOpaxi878 wb7rJY4hwJy3OMIaX7AMdXup4sWzmfxfOBYg75RRJL/tIhtfXSBMcJKS4Kin1ZOG 7wgPEyQgqiX/GfaCOq7l1ebg0f2SsyBxH0oC7hVikWn5Is1ec5iqqdTLdMX6t/Lx z7qwFv2j/m343JUQP4BmE0M9RUVTyjUy2edxFady5VBFcWX77RtjqI8c6IdQ/Dfj OK6n/wQEBYoHAvupdDeJ2fXVFgVKJmt0OvhsD3lrLkDzgp1c8CUIjwoK9OYWwUkK GLo3ym+SPPszt5ihilkTc0Y2Z7nwn7bZPkwWb3hM6AIyvQ== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 40sc4yf3s2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Aug 2024 21:41:28 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA05.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 478LfRdV013151 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 8 Aug 2024 21:41:27 GMT Received: from hu-eberman-lv.qualcomm.com (10.49.16.6) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 8 Aug 2024 14:41:26 -0700 Date: Thu, 8 Aug 2024 14:41:26 -0700 From: Elliot Berman To: David Hildenbrand CC: Andrew Morton , Paolo Bonzini , Sean Christopherson , Fuad Tabba , Patrick Roy , , Ackerley Tng , , , , , Subject: Re: [PATCH RFC 4/4] mm: guest_memfd: Add ability for mmap'ing pages Message-ID: <20240808101944778-0700.eberman@hu-eberman-lv.qualcomm.com> References: <20240805-guest-memfd-lib-v1-0-e5a29a4ff5d7@quicinc.com> <20240805-guest-memfd-lib-v1-4-e5a29a4ff5d7@quicinc.com> <4cdd93ba-9019-4c12-a0e6-07b430980278@redhat.com> <20240806093625007-0700.eberman@hu-eberman-lv.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01b.na.qualcomm.com (10.47.209.197) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: yIMS181wrrjh2V_923pIGptH-dEIuvfy X-Proofpoint-GUID: yIMS181wrrjh2V_923pIGptH-dEIuvfy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-08_21,2024-08-07_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 suspectscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2408080155 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1B38F2002F X-Stat-Signature: hntqsxtpydyh56fymych6o868d3er1hp X-Rspam-User: X-HE-Tag: 1723153292-836445 X-HE-Meta: U2FsdGVkX1+KzN/3NUBVkzClSPYNjjwgpg6w2vJYlrMLBBhXrCBYdkTERzO2aIwaC0ZRb/qNh+qAcoy7BQRcnLG9xwA+uHcOQz49e++GKZrvUbW66+C+87sAQ4Avt8H+vC8Zc1zB/pEHLsGrN+zdr9hy3IrmAMrx1DiNC1wxK1Rs/z2p2j1sVXYRq5zRm4+3DeckS/DCnxhs5AWEcQTqtpuO2oggRkNaI+3zid/78r/uyNqIqi8XHlzmNgwpUba9NpMFYmbZB0oido3ywyARfkiJpekshNB/HxVfiMhZ8P1r5MNJU1HbLGCsMAExBn9+2S+TqXQIloXE1D5KkJyptgLwoGhmEnCsYvU4WdIF0RnPIOz4yol4Q1XwPlFh2S8xjtRwz6Gv0IavxdCx6jBx2hPCVrGut6Tdn6R6o4quvqRRqF/cVdQgpyGaou3f7vpKYjqLVEqE24WqvIaW0/mfVBE0ubxedxC6Lit+6vXNxkCqxvQ/zlxG3k/pVCuZawRWSzPemiub23UCT4ji2IXDBvKJ+7hddoH2q8H9pLfzUytfa28jVK4zmtPKLBzDAtgCBPNaw6Hhvxpv1MnRY2edWs/Css0TKg2u01NLSSxNeckQYpQqvn0qXbN/3zHu2J+pmUc2ibN0siaf5KWnuloBZZW7RD7E/otey5EY4MUAOGYLe5GM3fwnX3ajn59j6bSb+cqILSKfttGtfYKv63S0WZVIuX9BxSNjzgXuCpampFL0wX4Z/0qczQpgkzBOdylclsutXNl60eccTXwS6cT1OGMJLkcS4JhfrB0B4pWg6tpIEN0CSu4fXwTDzcfsti3ER5zarbBVuJ7lbozmRWReP6AK0KMDL61wmieiSKdeBGZmwDKpDFU4olaN09bWz9tt5Y0rXv+bY39wdtJpMP/Jc9V4ui0sEvrof/y6JLRGyNomj9qdTmMwegI4rs9mB+Lw2o7FPbgT5xt8yXms4OF sMnMwvvL SXpSnuwu1CNK1ygQj4RTygnkAc9Tyn951ZPPCAf1yvovnQy/DSraaLHbNnLOIci0K8Hx9/XI5d+5r3ytsErkb+p0rKoRsU965LQnGPn/PyeYeMbSdRheDtMAdAg9tngqEQYXjvuYXgiMiknWEAye3K6krLMtc/LWrnYcGa9wEFij7YiWLUQlAVTw0teWneMWd9ObaUOQf1NMwSGYFXkTmQBI0tIGHQ4zQJiST8jcpAAx9hOg4Xiv6Wpa1y2n+Jpta/NZe43BT6op1mB587XAsZjSk3lgDUu0S2V85 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 07, 2024 at 06:12:00PM +0200, David Hildenbrand wrote: > On 06.08.24 19:14, Elliot Berman wrote: > > On Tue, Aug 06, 2024 at 03:51:22PM +0200, David Hildenbrand wrote: > > > > - if (gmem_flags & GUEST_MEMFD_FLAG_NO_DIRECT_MAP) { > > > > + if (!ops->accessible && (gmem_flags & GUEST_MEMFD_FLAG_NO_DIRECT_MAP)) { > > > > r = guest_memfd_folio_private(folio); > > > > if (r) > > > > goto out_err; > > > > @@ -107,6 +109,82 @@ struct folio *guest_memfd_grab_folio(struct file *file, pgoff_t index, u32 flags > > > > } > > > > EXPORT_SYMBOL_GPL(guest_memfd_grab_folio); > > > > +int guest_memfd_make_inaccessible(struct file *file, struct folio *folio) > > > > +{ > > > > + unsigned long gmem_flags = (unsigned long)file->private_data; > > > > + unsigned long i; > > > > + int r; > > > > + > > > > + unmap_mapping_folio(folio); > > > > + > > > > + /** > > > > + * We can't use the refcount. It might be elevated due to > > > > + * guest/vcpu trying to access same folio as another vcpu > > > > + * or because userspace is trying to access folio for same reason > > > > > > As discussed, that's insufficient. We really have to drive the refcount to 1 > > > -- the single reference we expect. > > > > > > What is the exact problem you are running into here? Who can just grab a > > > reference and maybe do nasty things with it? > > > > > > > Right, I remember we had discussed it. The problem I faced was if 2 > > vcpus fault on same page, they would race to look up the folio in > > filemap, increment refcount, then try to lock the folio. One of the > > vcpus wins the lock, while the other waits. The vcpu that gets the > > lock vcpu will see the elevated refcount. > > > > I was in middle of writing an explanation why I think this is best > > approach and realized I think it should be possible to do > > shared->private conversion and actually have single reference. There > > would be some cost to walk through the allocated folios and convert them > > to private before any vcpu runs. The approach I had gone with was to > > do conversions as late as possible. > > We certainly have to support conversion while the VCPUs are running. > > The VCPUs might be able to avoid grabbing a folio reference for the > conversion and only do the folio_lock(): as long as we have a guarantee that > we will disallow freeing the folio in gmem, for example, by syncing against > FALLOC_FL_PUNCH_HOLE. > > So if we can rely on the "gmem" reference to the folio that cannot go away > while we do what we do, we should be fine. > > > > Meanwhile, I was thinking if we would want to track the references we > hand out to "safe" users differently. > > Safe references would only be references that would survive a > private<->shared conversion, like KVM MMU mappings maybe? > > KVM would then have to be thought to return these gmem references > differently. > > The idea would be to track these "safe" references differently > (page->private?) and only allow dropping *our* guest_memfd reference if all > these "safe" references are gone. That is, FALLOC_FL_PUNCH_HOLE would also > fail if there are any "safe" reference remaining. > > <\random though> > I didn't find a path in filemap where we can grab folio without increasing its refcount. I liked the idea of keeping track of a "safe" refcount, but I believe there is a small window to race comparing the main folio refcount and the "safe" refcount. A vcpu could have incremented the main folio refcount and on the way to increment the safe refcount. Before that happens, another thread does the comparison and sees a mismatch. Thanks, Elliot