From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A46D8C52D6D for ; Tue, 6 Aug 2024 07:06:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E5BA6B007B; Tue, 6 Aug 2024 03:06:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 796266B0082; Tue, 6 Aug 2024 03:06:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65D7F6B0083; Tue, 6 Aug 2024 03:06:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 423D46B007B for ; Tue, 6 Aug 2024 03:06:34 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9103CA04F7 for ; Tue, 6 Aug 2024 07:06:33 +0000 (UTC) X-FDA: 82420937466.12.90F69D9 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf10.hostedemail.com (Postfix) with ESMTP id 5A171C002A for ; Tue, 6 Aug 2024 07:06:30 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dr2Zz0EN; spf=pass (imf10.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722927930; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BERIddNUNPmyyfQLc82JlMsxptOCyJZJAgGYHNgbIiI=; b=PewZd/FCh0JofiAlHyLD5aYVEXbNE3stImcr+R/vMh59m8d5Mf1RNedMJarJewe2RBe1Hh Pe1PyGrhCrzaFezslTjU9adAFtc5ortldjRDnybOS1yt0UF7SIyq/XeFTtqRu/hiYnDsLP QOLNyb/dUZ67zVS8F7XB1nlE8e5OHww= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722927930; a=rsa-sha256; cv=none; b=cUw6OCrB6Pxi0sNU0puO5OQCU509htG51AsZIRTJtfPcymnsswow3TdgzClWyFkqEMo0vI oSuqhQo/nFGuTgdb9HxQ7zbUSm4En47FjlU5AD2rPfpuh2X/P/n0AUUVu/94EATr0XvkTZ D9MlyhhoungCN2LVFia6v0SXxzsnhFQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dr2Zz0EN; spf=pass (imf10.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6B6E2CE0E01; Tue, 6 Aug 2024 07:06:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E621C32786; Tue, 6 Aug 2024 07:06:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722927985; bh=kGY8n6Su1JvqpXyWjEuQ6qSeT9M+Bh6NQpKsUwtjaZE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dr2Zz0ENpPWLdlpf8A/xlwPoQUVWMmowjSamX1bIhlZr3YK6C2DKzfuhO1cYizB2B +ckcCNgHEJbo1jDbEEbPbJVG05TLR3k8qpGeBxXW1FkxDs7rspbrOV8h39/tUCE13l kstU2g15HQR9HlO8siUB14aePccO1N1zUz79C5WFzQVxUS1vGEWD46bSUpbMmVfUS/ JxItIyQdClBBmCO3X++sZI7PVovSyjwEt3luoEjDhQ8ZeAlmG44wyUXXPZHb+Il/n1 tzc6plA8IrQxvTSK0QL1QodDHuelpio+zsggpRFE0WA6CInOla1EK3m1I9m9utrRn/ +iT8AyfcNKd1w== From: Christian Brauner To: Mateusz Guzik Cc: Christian Brauner , viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, josef@toxicpanda.com, wojciech.gladysz@infogain.com, ebiederm@xmission.com, kees@kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] exec: drop a racy path_noexec check Date: Tue, 6 Aug 2024 09:06:17 +0200 Message-ID: <20240806-atmen-planen-f0eb6e830d8e@brauner> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240805131721.765484-1-mjguzik@gmail.com> References: <20240805-fehlbesetzung-nilpferd-1ed58783ad4d@brauner> <20240805131721.765484-1-mjguzik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1231; i=brauner@kernel.org; h=from:subject:message-id; bh=kGY8n6Su1JvqpXyWjEuQ6qSeT9M+Bh6NQpKsUwtjaZE=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaRtPJ0ZZ7EiSWP7x9e1J8QOBxxTMq+M/GjDv9B86fvrJ lFvl+dd6ChlYRDjYpAVU2RxaDcJl1vOU7HZKFMDZg4rE8gQBi5OAZiIThkjw7dizpkduyapznxz nkvhaTdDf8bJiStLMsoXBP3dFu2hZczIcEDNfuIiva/a23Xlbb5ddnKzanRxXrKuaCXXVMOGeL4 XPAA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 5A171C002A X-Stat-Signature: iwbgibaix638dbg9yt79f1pqxgiut5fb X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722927990-886707 X-HE-Meta: U2FsdGVkX1/9jEBHLFXiM0O0sp9ygmLyZt1fiswpsJyi4OP/WcAivgPjTiHRiXU+zhtPX/nFCvThfomqnyi7XpjLrKFErmy7DKxYTKQZJQffDhv4WTM+6Ydv3y5LTs1Wev5BKZOCtzzZdh29YP+7frdMQ5jCWo36x5EA3I4JNXAgO3Bkz9GZ+WhsBlGmvyHZEmKozQQFDGtB9t8x+vbPiRDBKH1MKxIhCHmuLyMOH+RZ5GgyyLrDqUhiwdQGECYlAazYSWp0IEvRuGwZPeeTgqNCOxdX156+WeYV2skHLXapl32DED/oGxgWEWqo7zx/BaIuzMFLkomzr9K7Ky+rwZ7qHD9r/odCkJr4RxrTKjUaepPHFndM/DUkODSocSjr8t3s6a6aQP4ZfsEl92Ww2wAtPUcKybkxaMzg88Sy0l+RM2fHhea//aem4LN52IIqaM7DkbcquNf0Oi67GwIuUMPifFHU9LdfNEyOzU6jBDWqeDwgB/YKrFRpSJAEa9l1HFzId+URPUbQWs6LS894dmH3A4wlknA1fnVe8Vpmt9+qOJI4vWAqmUaWq5K4pVgbycL5NniV/E+mEBrBMmg/su/5ITdLHWzusaqPfZqSDDincZCtAu2xC6yykvIRuXMd4rXQsreeBSfht2MhsrFbQUNWfkMp60jtuaxwCtBdXHWlDjaCgoZZu98E4NkQkY3i2X+eG0l1xCas+QIXBVLnSqJcUS42ctptKzCdWYS4AUBrL+8sqQdkwkAM6wW5gCe5E6D/wpMte43w/YM1ys+X+SiM/VVzg72NOicmtXpX+Dm0HttF7ipy9Y+FQz5Vsd62UAcTzJXGO2DBb2eltK2h5M+WONCbeQAhtV4mW/FE1ARwt1P1Ng5absiDO315t7bun/QY+i9CH0ohrLR8aw3tuLEI7QonlXqr38gJ3+NSewD1SR5baejtoE0Jlq2gXtpgHYvIKBPrTg883ygKxKS GsVD0ftE twCX7kOolG8voBqY9jA8lydCyyjcVjOf3gWbvhPJjYVJOGqcrRSTp9zJsWpD7mRv1lLRXhpQYKVZT8SMN0C47zeBeDMBfnIgRZz4jp5O7paacZlMokHQQaieFa388lPYg21xX2cSuxZtBSjkMq2BdtQc6VtFSIYtPA5LDN8Gno99KOIUr6jSIxxLPurWPOk2JlsqV6ohah2iwBMy7V/oyzeGZ9Vi3lWNQOmekCT6U2Z1ddr4cVYzU+xWV3fJ+8lLJAEL6WGE2usNRTDUoTCkRudy5q6AoTUxk3jcoovZsmhuDcyW2p/ngqqG3D8ZGIR5HW+HbS/yJxhqvOGLarfwRRARXNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 05 Aug 2024 15:17:21 +0200, Mateusz Guzik wrote: > Both i_mode and noexec checks wrapped in WARN_ON stem from an artifact > of the previous implementation. They used to legitimately check for the > condition, but that got moved up in two commits: > 633fb6ac3980 ("exec: move S_ISREG() check earlier") > 0fd338b2d2cd ("exec: move path_noexec() check earlier") > > Instead of being removed said checks are WARN_ON'ed instead, which > has some debug value > > [...] Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] exec: drop a racy path_noexec check https://git.kernel.org/vfs/vfs/c/d1968fae98da