From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E96BC3DA7F for ; Mon, 5 Aug 2024 17:06:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A87266B00AE; Mon, 5 Aug 2024 13:06:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A36E36B00AF; Mon, 5 Aug 2024 13:06:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FE196B00B2; Mon, 5 Aug 2024 13:06:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6F3326B00AE for ; Mon, 5 Aug 2024 13:06:28 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 00C981402EF for ; Mon, 5 Aug 2024 17:06:27 +0000 (UTC) X-FDA: 82418820456.14.1B6CD7D Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf14.hostedemail.com (Postfix) with ESMTP id ED39F100030 for ; Mon, 5 Aug 2024 17:06:25 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="Ksr/m+be"; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf14.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.170 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722877535; a=rsa-sha256; cv=none; b=ju65YA3wBSanVWayR6sBJ7CWH22G8svbyBURlwGSioC4DptCkjnTDcO1QRbOVcXyiWhm/i hb7N2Adl7GZqhGqFq6Om1YwtxitO1Zzobe1l47/PWnEofzRc8NEEvTJcgYjQ/lSgKmaRNO TzuhIA6rmEuPBhPgWXknf5HocC+dJkY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="Ksr/m+be"; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf14.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.170 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722877535; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aVdnmiDlJ6/XqpvsgoCw3lC20iW8UH/7vdY3FPonF88=; b=Ua27rCw5ouEHwhHgjMzqAD3n/MMEKVPC6QAylNhoVftzUHjyC1r+MtmUWi8bh3wo9+m/Qo zSkgXDQspCiuAXfOrQgLtCeB5Ww3QJZmDzvw7aqbC2HCwX7KwZls5ua/+9lbiGUnhjwCJ4 c6fR4oC9Bj9rcaBNDxKHoHvPCMVDciM= Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-45019dccc3aso51062781cf.1 for ; Mon, 05 Aug 2024 10:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1722877585; x=1723482385; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aVdnmiDlJ6/XqpvsgoCw3lC20iW8UH/7vdY3FPonF88=; b=Ksr/m+beIaD2pc42Hxm9h4MnvRjErq3Q4c9DHQ7bsbNViOmLLLK1Nu9d0aHRvHyS00 xRZFAqT3NnOTiyyPrhrZ9wA3xfP7A4gPsPP8CgJhPvDcjrJlU4lyHzmUmw0BoGLnhhXy 54PRsb1TBelelkyaRtjI0gLxbqf9suA8Hg/bB6PYP5VlOdmU9Dg4xgPDfyH0A10hI7aW rpueOHeZnVSiSMNlXpVjgBu4px0aUeR0BPLNZnMMxLzzvWP4KEZZgE1pmvdQhocprxPm SJKySH2PBnLiFtzBYYJS2W99SX577+IQxjc5Oy0FHXK13zTXWrgiNduYdNHzyV2mdLFx Px/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722877585; x=1723482385; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aVdnmiDlJ6/XqpvsgoCw3lC20iW8UH/7vdY3FPonF88=; b=u/CHsgawIIsbLlNabTuikrK7CHUXWF1JuTP1Q6DdotC7kxphR678DMniobsDaC7ffm rVITZvrFSGMHWy9U7/23c5GFlneQCSjQGYjcnmtHvm1t/0zesRvE6auPpNE9ESR1ypkz EvdkaqLfVhOKfCzYtgChjTqWRfMRgOoetgFOBaSb+3X3kE05gMhbBfT7CCcSIG3gj+pj CqO1MYgntEsxPRX8paoxyCR/tFwJ1eKXMuVnUK24fQHIxczjeQaQH902McmQ17ex93e3 XYE/XU1fZg6VEh0djzl4aDB2Dtikx3pXAvsSF36ZA9taEiPxkRCKb1x9uRUm6BkiJmkf ALIg== X-Forwarded-Encrypted: i=1; AJvYcCWKVO/V/TkhoqWBmnY/dy2ANX7nPBkxwumKKfNCn+grBTJpewDvBPyiiYcPc6hs0eEJNNw8yBwImgg+y7NIzqUdjAA= X-Gm-Message-State: AOJu0YwjVA73q+998gUgALTkgCbEE9hQGIIL4SL2cJmoLmm06UcYKarc c/q+Xt34o9K+Dy8FhbBL5k/w9R4BmBbkfHAe0Y/Enu97jF0lku+cCjmPKe2u1W4= X-Google-Smtp-Source: AGHT+IHD+XnKjNCAF8dzli3R/mIEHTrgOWVGf53JNuRafUP3Rfz9QB7P9TlGbdcWMqYdzpV1ApOe/w== X-Received: by 2002:ac8:5fd2:0:b0:44f:ee96:cc80 with SMTP id d75a77b69052e-4518923dd26mr163577601cf.28.1722877585155; Mon, 05 Aug 2024 10:06:25 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4518a75be2dsm30774971cf.61.2024.08.05.10.06.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Aug 2024 10:06:24 -0700 (PDT) Date: Mon, 5 Aug 2024 13:06:23 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: Andrew Morton , Nhat Pham , Chengming Zhou , Takero Funaki , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: zswap: make the lock critical section obvious in shrink_worker() Message-ID: <20240805170623.GC322282@cmpxchg.org> References: <20240803053306.2685541-1-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240803053306.2685541-1-yosryahmed@google.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: ED39F100030 X-Stat-Signature: ykscxfcciskk7a7myg89bxdutcu1qtdz X-Rspam-User: X-HE-Tag: 1722877585-347430 X-HE-Meta: U2FsdGVkX19KFn9hNjIhK+DAnucuNdufwWIL88JrdTdecGD5LYuqQZD4wWqLV074Pvn/nwdmBtsmLQYopeGN0VOEOQ9PdTgjB/WCJiIxprMO/Yhqcvsjt3wzgzQv1Osj7k7GYfWy8Oszhk/3vwjO7QTFE+lHSWf5Pz2Lf6/pKFIsFnlZyyFYZ1RGLO4KGNRO6wpe6T/fjI6+Ye4q/UXlBYuuEFjJ3mZM6hlV1/TnIXXvu0B0eprjovLmgQWJAGQNfEda0z41UsHi5tRFRImChCeYxNu65E/ZAHFlm45gKpx6Q2PpivmWos3j6+9Vn7YOzxTPIhwADfhyllUDytna8Ufn6Fa4CH4BZFYCwZ9M7Ml7E+iksov5r3memqmqmMzbVqx7gvEokmotsC4tm16gsQeNddfGLbpGAP9hrlrwvBl7ulqLdyiACVsfUKCXBnmfnnF9vzhPt2K9OTiqrh7vfvsVxk64Ag0XaxWChHEr5ktg9hHAhS72YmRoG0QPG7B4kDW25w2H2Rx7UIA0isF1A1NHdgRtzQFenLAbzUhwn/8W6JEeVHRr/OmOeC9EC9ZhK3BjU0Jh8XZpHLzxKDEWV3+qEJGV1obLzH0aSvU1wAKWBs29KHTNn3gnRf6BZQvUB+E/Af4RSh16B8NSHjjjxlFA1RPGd9Mc4O/TCnWNPq6eGtZmLynQpV3oylZQFi6Ic/7iAeeMuOFCXsYLmrvPgIIIaxj9LLt4+2eh3+tS1zE5huVhoiB/Lt7xcQ9vFYHeVYjdNSdREQN8v948eFNy6PDRVag3sp4Q21NtiIzBnMfwvl9lPEWuDxptOwqfjiv+vvCQdds3gvTsi9rhKSbfQLVmATIUHJuDGpt0zLXXMGk2qzAK1Vm5JdaVZ7UzZSKpgOjqUSAH9yAfFMnZln0riZCdAQmg6nGgKhC5X0O6gLHYIElGo2VfDX3xaD61SvxcZX2fhbpnM5fAhvrDDN5 lqpWgc21 GYTgt8P0Bas5Vl/vUaEbzLNnla/LQOOeOVvy/rHvuu/DU47sLRaJL0Qac+Clsh93FnekmlrkRVB3AJ+6XgLENPdcoce8DnbwuwI16w8q2YdmADyxvFeKkwLzV/OwNuvmQe5/OFrcldEPcijGNfIXs4DDzZncVy6PAqpLATuWh1Oh+Nm7yKFEHyt/R0G2xoCQ4bLZMlVHN2XZ2UV9vc8RIeNIsPOIe1jXD/mCacelhjvLqZiP3VO49HiwgqSBTtuqvg8U63wJJLjfvYOoLY1liPrOMj9MjDQwkR416qmDyWiUzqxnkwpCzrktMHssQIc4OtNjqhuHwVMvXtv0W+2uaZKFGWXRSTn6ryHvMdFXw2hfHqI1rnGsV2GH8YiNSNkarSCfp0/tOR/WlhvuDFPbBxYK/DzW9g42R4q54CsJoiN4Uli7l2cJjzNlZ4YpDRaYA9HYJPlm23KiaUzjcbTvXaqvDxO6YseqP7mTMXlzFwrUlV66CJUzoeq3uBLN9eAG5QTU/Q6wQzSR4x9Nr+5xKW8/3qg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Aug 03, 2024 at 05:33:06AM +0000, Yosry Ahmed wrote: > Move the comments and spin_{lock/unlock}() calls around in > shrink_worker() to make it obvious the lock is protecting the loop > updating zswap_next_shrink. > > Signed-off-by: Yosry Ahmed Acked-by: Johannes Weiner