From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B34BC3DA4A for ; Mon, 5 Aug 2024 15:37:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1B786B00C0; Mon, 5 Aug 2024 11:37:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA4106B00C1; Mon, 5 Aug 2024 11:37:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1E016B00C2; Mon, 5 Aug 2024 11:37:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7AF4F6B00C0 for ; Mon, 5 Aug 2024 11:37:27 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 07CC441D6D for ; Mon, 5 Aug 2024 15:37:27 +0000 (UTC) X-FDA: 82418596134.19.7D80E61 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf01.hostedemail.com (Postfix) with ESMTP id 06F5240006 for ; Mon, 5 Aug 2024 15:37:24 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KtlEhGgk; spf=pass (imf01.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722872214; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vrBwIGwG3+u5FlpRUxtjBR8VlO80V8brLm+1GYvIpgQ=; b=AyCjKUpEqqIsskFYSPvDCMgirmAIONvahKHzT+NGLU3yk3lVrdeKZuvCvx3nAGigFUOcvT KhuR9thSn2uJ6sJ9tNOaWun6VHu8BtoXjE5f+aFF6RVM5WpeJ2nKomnnOYfncjFoH4J4t0 GqZ+5tjwMKq2OFx/NbPRa3uRumwXzBg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KtlEhGgk; spf=pass (imf01.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722872214; a=rsa-sha256; cv=none; b=Z4kAVJD+N3p44Fft00m7d2Y7l5NwajoiwwnzEMsvBAnUg41YgYdG44w+bbudvwstIdGsSv rYhwvo3LD5DrDSgANKxECk2VVP3aIgR/Ks/iQOGrR66t/cxYZC3fWPTuQwXCI3zSCWVDyE iLryOqPdJEFAkONHO2t3rf+UMQB2Q5g= Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5af326eddb2so9154161a12.1 for ; Mon, 05 Aug 2024 08:37:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722872243; x=1723477043; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=vrBwIGwG3+u5FlpRUxtjBR8VlO80V8brLm+1GYvIpgQ=; b=KtlEhGgkfrDjsb/hdAttg7I4lC2cbTxW+gLIKQ2fAkvQ44PdxRFxEK6UHk4dMq5+Al AM+tW23HixwD6GmGsMLNKOTjj4udAY0fgT2MGg912anXkTYt0hvkPmz6Nr6OEIaHKulX hFjAL0PoqpZD8QAhOIbSveiQOE+3VtvTtuBeeNN2PFcO8yl+dOKfwGcq2R5o8WLJhFlJ CtfVoMZdhx0FSSMvbHiD+hjXnLG8pk6XQ4IEB8k6yKUgHTgxgleVXmW+7hx4Bnasijx/ 25aoIjEqXOXIckN+/mQToe8ctsPctfDKSlkPFArjXjs7udv9AK8FLmgv7TS6x4FVvxhu C7jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722872243; x=1723477043; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vrBwIGwG3+u5FlpRUxtjBR8VlO80V8brLm+1GYvIpgQ=; b=cf4Eph8EgnopRfk6+3RNpA7KholFicBsUCMgY6Z+uwJpy4qqtafbobkbglsypZeHoV 41XgdtrBvAHaf0ciWqWDjvVINRoX25nHHLDf9I7OotlSq0ucpfDPuaRR/MRHq6Bluiki zjNxrf3oUpAe8gz8cKdoMS5hCZmhh/EAVfWL3e1l1ZimOIU0Y7NqPrZxcLZ7zvpvJcw3 jCcKPbSrexDYDjM+Y/AwO5H+WNau1FitiJmaohCEV2jEGMWliQ179vl6s1hiFcaaNwhJ pqxUGELo+XzY/yCXSTlIrKbHl3SXH0OD0woiALDHqStzbs672u7hYI3Qd0VTVWb08asI tmSA== X-Forwarded-Encrypted: i=1; AJvYcCUs7xtqOy9ZoWjO+faO7tOfrtPp0tq2GsyzZRmMan16xmdfCHuQJQa7cfeJEF6SN3vZotOKqjBM4pSlby7Q16FVbNE= X-Gm-Message-State: AOJu0Yz1LWG3qTacdPjHk1RByIXEhTI95Q+EWr4jQrgBt+jv3JQXX/tr FqgHwSsovT+pV6kWflu+uYGD/2AGgC6m1qysZl9s8ue959VC7LaV X-Google-Smtp-Source: AGHT+IFSwaBAMaiQnJ9beyzCMDN+8VuoJz0ozS1ktq4fNAlJRGsO05WZ0a5nCZBmueoxzL7cEC+Jog== X-Received: by 2002:a17:907:2d29:b0:a7a:b561:358e with SMTP id a640c23a62f3a-a7dc628d37bmr1080912566b.33.1722872242953; Mon, 05 Aug 2024 08:37:22 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9e7feecsm468897266b.176.2024.08.05.08.37.21 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Aug 2024 08:37:21 -0700 (PDT) Date: Mon, 5 Aug 2024 15:37:20 +0000 From: Wei Yang To: Mike Rapoport Cc: Wei Yang , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 1/5] memblock test: fix implicit declaration of function 'virt_to_phys' Message-ID: <20240805153720.myjqd6ur65x5ucsu@master> Reply-To: Wei Yang References: <20240802010923.15577-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 06F5240006 X-Stat-Signature: u9o48obajt4145tq1hrqa8gzp476bux5 X-HE-Tag: 1722872244-92089 X-HE-Meta: U2FsdGVkX194EYCb6cnq30N0ZO+egDbEBZqNYQKtIuUmbDB60yIAIQbLr3E4byyEG4mL0vRaSoHJxdIBNcUnKxdMGdhyrqthKLp22FwjZBCGwz9OL1jVnK/VVPkLPrbnSe0+0wRK4N3Ea9hQjnGU0UrdR9yHAonhZvBocPNjSa+gGhUw0JcIPChHvgslmfaZNJJggILwNqJYuTD5HcbD/pEqsO+BmJhBoxfdVkLJJo/rDpGnL7buuMYJVvwSwXQ3iwOtS9oC3Q5gl/8Cj8/ajQwnbfE2jc6szLsZ+CWu4ANsJkr7AEKL84bOYKuOvGIsCupGf6Ky1BCVHVikSQb/CjTE8zRpBvjruGKqzSmCTFgfKmn9vQxqM8fIOePD9SxXUnNz09DLPGMVY15NRuHi0kRiI5SGf7WNctuB9ELr7EEVSciIIFEAzYcwYgc3H96OUPtXwxjEGWOVtL+72/YRIS4KAvEnbuWohhPWnSx7WWUYO7OJnMTLEyJ5IRgM+S8eS4XXP1gSSzAd8YILie9HIkWV4dez5Ao5o6R+oPS/3yVZzyLnIjJTEgDVG8CGSQj4BNllZldIuchrBAi0MjZABHZknzdCf3kHTji2/KpzduHeiRloD7gI3Iz85ziQ0pm4iQNWaQwMeJp4Pm4e24335uzQzofRckn93e5i2jUFlT85sTMhnly5ni82y53cvaMxv9vgjvWrBp/Kk80Jrv6ttPdaiIL3Wv9kITyc0bpnVKGib7M9rf4ROzqTzA9bLlkv0TS0Pf5ir58v38aaep+VIVNUngzKMPVsxNGHBLQo6oCTx32ZCSw1c2TZZmsJBZRyNuBdkBkpNmZ6KnHmKQoRKusZJwf3S5IGXAm5WKkwSm2cWUz4LgHDBWeiJ1u9x1db0P2femfMI5X2IIt3LIGf9q4YDe+h/eWGM18Z2SUale27bE0AekDXmdsT1xg5rv8dC0eF1MCtiWkdOhufmIe qYuA11UI 8jKWpzMFO/sI2vkuEj/iM5wWmoBxMZMxkYMTPKOfS+AEOHk5j8dwK49nYaigit5o4wGWf7Oi2vZj8y6S8pauQ3AHdPRiZxd53nlBLOYs+w5y5mirn5Y44esp9dktgEo1J1WDDm9ElzeV0fd0Vxf2ThyknNCL4IqQhcBMO9CdDZaPGjSx4z3z961DgGqtNN2w+M+a1sSzxPMPLz+y6D6jePm0LnfIUHvraWtnglPJFPZLOZjemfPe+wC05MEZtbVKsz+wabRjhAKnQO287mypqxp0BAD9V3bP6tP8ZuviFgT+kETqQpGJcL1NyUlnLGsBaE3C8rIJ50O1dlFC3llpQ//F3nzQa0DpG0VGX0DeBUveBIzwv41YWaORedLMLmjo8bRVBflTZ7mH5o5XTNe31kCp+/pjFXEnS7GZVcScPTG/DFTQDyWNaO+bQbHZlflgbjIyl+JaLC3iXlbKeCbxauxsuMjwodJiqw4i4isQaLdtO4gNLLcnRwpg7CBToL6wLIiTIfpzDjPERUbiTmkyP+cl/pLB2Xrrfg97C64NNb6cIjSrzkH2TAnZLePRVbKGaAWTegpndH/gK21pEwSXNsghGtQww21NhXUy9vedmIqDXaJKSBYvwNqr+WhQmhr/z/q30sw9U178HV2dV89Z/rG566XhBGMnA3URB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 05, 2024 at 01:03:14PM +0300, Mike Rapoport wrote: >On Fri, Aug 02, 2024 at 01:09:19AM +0000, Wei Yang wrote: >> Commit 94ff46de4a73 ("memblock: Move late alloc warning down to phys >> alloc") introduce the usage of virt_to_phys(), which is not defined in >> memblock tests. >> >> Define it in mm.h to fix the build error. >> >> Signed-off-by: Wei Yang >> >> --- >> v3: use static inline as phys_to_virt >> v2: move definition to mm.h >> --- >> tools/include/linux/mm.h | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/tools/include/linux/mm.h b/tools/include/linux/mm.h >> index cad4f2927983..c9e915914add 100644 >> --- a/tools/include/linux/mm.h >> +++ b/tools/include/linux/mm.h >> @@ -25,6 +25,12 @@ static inline void *phys_to_virt(unsigned long address) >> return __va(address); >> } >> >> +#define virt_to_phys virt_to_phys >> +static inline phys_addr_t virt_to_phys(volatile void *address) > >Why volatilte? > There are two definitions of virt_to_phys: include/asm-generic/io.h arch/x86/include/asm/io.h both has volatile. I just copy from it. But I don't 100% understand it. >> +{ >> + return (unsigned long)address; > >This should be phys_addr_t, look at its definition in tools/include/linux/types.h > You are right. Will fix it. >> +} >> + >> void reserve_bootmem_region(phys_addr_t start, phys_addr_t end, int nid); >> >> static inline void totalram_pages_inc(void) >> -- >> 2.34.1 >> > >-- >Sincerely yours, >Mike. -- Wei Yang Help you, Help me