From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D88C3DA64 for ; Mon, 5 Aug 2024 01:53:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DD726B007B; Sun, 4 Aug 2024 21:53:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78D676B0082; Sun, 4 Aug 2024 21:53:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6554D6B0085; Sun, 4 Aug 2024 21:53:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 45CDD6B007B for ; Sun, 4 Aug 2024 21:53:46 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A2E7CA178C for ; Mon, 5 Aug 2024 01:53:45 +0000 (UTC) X-FDA: 82416520410.13.F7CA7CA Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) by imf17.hostedemail.com (Postfix) with ESMTP id C41F340021 for ; Mon, 5 Aug 2024 01:53:43 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CHjT82A0; spf=pass (imf17.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.160.54 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722822762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gGamAjYrrdAEeItzP4qz2BRS5pecyfrdaiZ5lvnoTEE=; b=mkCU6x4rvz+KateMsqGmGjMnoqj9GpBz7+wk8mW5q+omWy8B5voTW8OXEjb3Q9pIBm698y g9WFQQuLSuN9s3Qofblhi4WtSjnSpC1vi0wz/Q0k3aYHHsp/XCIj94w7Ge2685sGQ/Ahfa hC8ccR7mUtUwBwKaIJ4eQPnBHFL6wbc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722822762; a=rsa-sha256; cv=none; b=gUytEzAvAPB5XeTdUZIKz9RTlnKs7wTxSe9SzIAhKeVgHFtW3XFCrt1z5cOPdv9FJm9/WY ZDO1KRSrvtDtq+bRQMpsICEFPgEyUm29eMq2aWU+7XR4KEhlY1GEGsgqDFSHvnM4Bn34j2 5q5z5pLcGv4cx0Lvl/EAfT9D5KSy+O0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CHjT82A0; spf=pass (imf17.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.160.54 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-26827ec5235so3499669fac.2 for ; Sun, 04 Aug 2024 18:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722822823; x=1723427623; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gGamAjYrrdAEeItzP4qz2BRS5pecyfrdaiZ5lvnoTEE=; b=CHjT82A0h5ZFKaBQdzS8ZAoZY+Gxk200oHa4NEEUQXLzSKwYCrNwZ8TrBqN7CuWJUm mIp/lkEYOi+uUOLAYNyDK6yS4WqWJi7wWijeNtX+ts1smUccoizHcXyb5LMzZbImWa+/ guohjt2ryRDvxI9OA+Fh84lcYPsTg7aNFDDA7iPnyWXGOkGEqv3zTu3Hub4b3/5UQb96 iVZpW8zK2KpYAFBI4KfOCaW5Mm/7Uu8LhXe1rTuxggeY+2IYvykab+X3JrJ9bsbkPdGt Yz+AW4ERHeA8zPffZJi+U1EACGTptC8ggSrqOXROPlRyPce29LSaaV0RsbJ0EQ6I0hCh NHCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722822823; x=1723427623; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gGamAjYrrdAEeItzP4qz2BRS5pecyfrdaiZ5lvnoTEE=; b=nYfbI1Zoz+y5QlyOhm8VE5DSCgK6N+J9a7e/Hdm76aXeV8BKSa5i1NXoqgQ0kbSF0A 6WxGH2QjfL4+svIURCwmgFR2B/+9H/+weiEz1E0SqjULPXiX8wDMoaTEoXJfAHnYR0em YOhWxqzsFe8pvxgl6WTmK0ZHk3NG/wKK5tkcn9fmch6/GKbnKXysd0DbkqhQeun8U0LU 26epu/DAes55va93LcI4lMlC3TG+Yc5TeenQdwQ7qgVTfvHQgLio1N6YT3hnpiVzIVUr TssfTMA9lf364WDjIoGOr/Ue+c/eZOLObA7aAMxxDxtMpducQTZLlXL72PEDnXDtiygF 5XrQ== X-Forwarded-Encrypted: i=1; AJvYcCWt5/7iPcBNAmCAx2r9htczMRr9i4658w962BVXYmcge21ifXgetD5EvmfRyY+a2IxTOMrQqaMPSWiIXhaqxHn64z4= X-Gm-Message-State: AOJu0YyCXUdze/WubYe195G6KFhCg44lkV+pxrmUfY+Dn5ajC4NPHUBH J+ENV8RhQMP7j9ptxW9KVdFfgHM5vzQYU4qC2jpN38MBLLu44x6s X-Google-Smtp-Source: AGHT+IG9woPy8kOXY/EJAb0+8U2sGMNdAM/SNhh5aqT1feM8mWbNKoXnsgHxbcVBpRcy7bL+Ua1FiA== X-Received: by 2002:a05:6871:79d:b0:260:ffaf:811b with SMTP id 586e51a60fabf-26891b27a2fmr12643856fac.11.1722822822639; Sun, 04 Aug 2024 18:53:42 -0700 (PDT) Received: from localhost.localdomain ([2407:7000:8942:5500:aaa1:59ff:fe57:eb97]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7b762e9c6fesm4456632a12.11.2024.08.04.18.53.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Aug 2024 18:53:42 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: chrisl@kernel.org Cc: akpm@linux-foundation.org, baohua@kernel.org, hughd@google.com, kaleshsingh@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ryan.roberts@arm.com, ryncsn@gmail.com, ying.huang@intel.com Subject: Re: [PATCH v5 6/9] mm: swap: allow cache reclaim to skip slot cache Date: Mon, 5 Aug 2024 13:53:24 +1200 Message-Id: <20240805015324.45134-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C41F340021 X-Stat-Signature: k3coays6q1m31oo565rzo97jh5eofhfc X-HE-Tag: 1722822823-683902 X-HE-Meta: U2FsdGVkX1/q+35Ae1I8+jm/UVqG48aGHm9hDAYdqtTLmjQLEPiXh4GZf7mSEictKfaZNMsfQtfNRptfxwBm/0BDsz9R2ScqOsWsaya/sgEBzaDVnlUUVjs0WU885cGovpCjgOPqBf7ckjQhpgar6SW6r8IgruDf1fMV1dL25GZulzD7IL65HIM6hyvkAUsEPs0Plw00a5D+K1ZIXSMIDU75NUV5Btf/x67hl1KWGbkBx+eiVdu1l0hTzkABGPMKmALvF/NMclbSjT3AbXKkWM0tMBG0vhtbDwN1ch+alKNkcPU59u9BHpq+ZvllVVbL73ovvh2pFelw+u+e+/jlQMg4pPDiWqXhsXQiIG+r2bMGANFes27Io0JInkzqpAUx0tMPm8aHDrXE/C85jnaIDO9u8Pez71Z7Bwvkdz+jow77SJ71hSgUpJ8HeLuzcv2bA6MNkKf0QsBb/DjhxGynQj2aNcApibbQLJgzvRuCC22n3XSAJ0Nduw70sEcLq6MoZWbkFyPc6G/ky9ElpgPIoFf57SOo814cD72lbqg5qkh1ED2MthbM6OdbP2MsCzxrhvzS9x7XKyeIDE8AJB7HEog2ZjO5OasXb4Aq0W+8b9RlK/tvgV6n1vmx0NL/xWQyIwF1cE2X851ISe5nTp+6TnEydnfniZuwbpIfQT47L2whzduS28QfQrcpukTppzAUKmhl76302TUwnUuPMzBXNCwHBljhisNH5Y8o30IvlU1eDqHBLFkpuunO2VuyN4KOtmtMsHTDVmUestjiXnfMoRy5fNazqtN3j0DbHXFth/Bd1/024IEQU6sA0xUoxP2Ls0qyXax+zFInOEb94W23EtRKGx2WoyUjOxtpmZxTiK+PzEjH8gfkMZHRKfnklXOsyrubH4noGm2cLBiKyoD8D1sX3idWNWMjGsbuMJFHQJrpDsIW/D8JN35hFCO8OXX+ER0HbtdIi4OZG9TvRwq aHXlP9Ug IquypHSk0zWfPu4BzBiN/7EkZTqMjXBb9PPbKEq424uTiZZs0NzLo6uy9znTkGV6BMeL7BjZbIEjsOucx5D4am4xGnZyHjHAda68WFMDWsAuN6PXdUN8++aT73EJrNPABfxj/37B+rACmqDwUhBBW0uNVN1OIPRfKmauOIgTPfE4mxx3UbokUjTNCO9JFeKESyPIuVOYq6YJgzfynque660iCABR4HZw2aQYoqp+c2xozBpaZ8ukp1x8zyYyiGAWmlICSimaDxAq1VBWfezQJUdkw16wWJhMtkGKT45E2YCqu3oM02vzqXp36VCxRMt1Qr6AUQdXjsSbVoDxwlrMYPUnUleOFB6fKoE0f0uu6F4yWaOuk19S5+2GMcb8L/Z0JaLvD8eVKmmRwJFFhL7kRTHwelWs7Zayl4cND0hK4WXOpcwSQ8uZ5g8DkO3DZ3eCI9zTCVH9iTO1HRnmQLH3uSmg3Qg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 5, 2024 at 6:07 AM Chris Li wrote: > > > > + > > > > +       spin_lock(&si->lock); > > > > +       /* Only sinple page folio can be backed by zswap */ > > > > +       if (!nr_pages) > > > > +               zswap_invalidate(entry); > > > > > > I am trying to figure out if I am mad :-)  Does nr_pages == 0 means single > > > page folio? > > > > > > > Hi Barry > > > > I'm sorry, this should be nr_pages == 1, I messed up order and nr, as > > zswap only works for single page folios. > Ack. Should be  nr_pages == 1. > Yes. Andrew, can you please help squash the below fix, small folios should have nr_pages == 1 but not nr_page == 0 diff --git a/mm/swapfile.c b/mm/swapfile.c index ea023fc25d08..6de12d712c7e 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -224,7 +224,7 @@ static int __try_to_reclaim_swap(struct swap_info_struct *si, spin_lock(&si->lock); /* Only sinple page folio can be backed by zswap */ - if (!nr_pages) + if (nr_pages == 1) zswap_invalidate(entry); swap_entry_range_free(si, entry, nr_pages); spin_unlock(&si->lock); > Barry, thanks for catching that. > > Chris Thanks Barry