From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E08CDC3DA64 for ; Sun, 4 Aug 2024 18:53:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A7436B007B; Sun, 4 Aug 2024 14:53:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 057AD6B0082; Sun, 4 Aug 2024 14:53:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E618C6B0085; Sun, 4 Aug 2024 14:53:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C883E6B007B for ; Sun, 4 Aug 2024 14:53:54 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7608F141AE9 for ; Sun, 4 Aug 2024 18:53:54 +0000 (UTC) X-FDA: 82415462388.14.2FCAC04 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 7DDB8C0006 for ; Sun, 4 Aug 2024 18:53:52 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hmdq4Sgm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722797583; a=rsa-sha256; cv=none; b=zEDEt+9z6GJB5THc3ZUvTfvDzXKA/ts7nEYNGWay794dZMzrhCftsgnKy2kfkXBxmgszEm OSLmpHysHK3irxpG75AS8Jpxc0q21BwU4T6rrZUpx4qzgqBSV2FJIvTCFjj/TDiAWryOBV 8XmGbPIk1ljgDu241a663QIcFs3/3bc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hmdq4Sgm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722797583; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GC05VjOW+Ud/zQn9u1M9aJNEJiu5D1z6sqv5c4//nyo=; b=VJsq6USFc66+VWLo0JcLw/2oTBWrFuiXZ8jrdBmPMh5hsg2M+SAiErKt6ZOx96nUDqIyf8 UFljneRrHYM7voMaDiMSug+SVaEbIYoYEkwbAVTVXbEIqP725bXNq6hN0dkW9EDeu1TSq8 SFKuqGDk3XAyldEqWrytCYz520CMEQM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722797631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GC05VjOW+Ud/zQn9u1M9aJNEJiu5D1z6sqv5c4//nyo=; b=hmdq4SgmqhvQD3chZxRtROvJwQvjzc+lhoPRYGVnX5MKB3ZE3qxBcuc09+8+8TYAA72xcF 6yKbdLMo+0vHJMJoQwpDIytmSBnYdYH7ooziwvX5n8Z1WMaeFg5Wb81P2Gesm1zEdU2OUc 4eZzG/JYc5JnvlSsk/I4hctQ5Vfnj/U= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-HL_wgFG1NxaTife3_w51DA-1; Sun, 04 Aug 2024 14:53:47 -0400 X-MC-Unique: HL_wgFG1NxaTife3_w51DA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F3F3A19560AB; Sun, 4 Aug 2024 18:53:44 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.47]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id ED55E1955F40; Sun, 4 Aug 2024 18:53:40 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sun, 4 Aug 2024 20:53:43 +0200 (CEST) Date: Sun, 4 Aug 2024 20:53:38 +0200 From: Oleg Nesterov To: Linus Torvalds Cc: Brian Mak , "Eric W. Biederman" , Kees Cook , Alexander Viro , Christian Brauner , Jan Kara , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH] piped/ptraced coredump (was: Dump smaller VMAs first in ELF cores) Message-ID: <20240804185338.GB27866@redhat.com> References: <20240804152327.GA27866@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7DDB8C0006 X-Stat-Signature: 9ibfsnjh83qw9y46mpr16t3sakfkszph X-Rspam-User: X-HE-Tag: 1722797632-419970 X-HE-Meta: U2FsdGVkX1+zyXJTezta2GaDR/dKNw8U9CnHgyX4N1eqrNvYABSFxnFaLvyjTI0soTspfQYShk7MK0mzUyeow7CwBjB6SPo8qD9R1EFQSVrC7CsiYFfkyqqoGmo7EcrX/6y5q4igU/tSYInUT1K5vyxWr9cpUSga6pb4qr+S3SxEpBFlkXLtaJxPuBUdZhfEp9U/ZZLPwWxF6ZJnBpf7frKT2FzKACuqLtRmReGfVqmjTa4vo7VWurDwNX3u8y7Lw9wioEblXDfPcWqFNegeV8W4KC0OVJjkjDjstzPnKhADgjllubGC+U0UIOLuLKyfK7ZlUS1oX+bITcnK0u533PAsd35aFPnnySaoNCudIOqzxLz9qgHKTw3w5j1JeKU4o8h9pubSylKJLdMU6lH32LncIiV23Q5BECbDmB3lze37qEZa5JMCjgJcVYyAQFqHAaP9C+77Bx6dFFeHfOy6mZsPO+0PG6JVZw5aX6XwkJiWaG3sy0/FYcCZHNmx23fpb2+H/4+uqt+A7yrHCi8WEG568u/pqZLVELYbKeiTzcvtoumNs09L3yL3VD2kHdFHGGa5bwnRh0k5ZttDfg5FYa+uy3z4Bgkd3FHaaIEcH+UP/+Q98aleQ3+HOvJXmqCaTFBJP1n8ilqofxJ6Mynr+Lc1zxLoc3j/Xl/XsvIA2u9QxD23iPbQTcps3mRroNovzwpxdbtjkEqxU0bkUCvcH9RRkn/NWnpbc7IhMX/Kgdynd+bMZXLtxiK9i8RnivL49nwnUWUP1D/ttnoy6AC5FtSfkpednHL/i4KURua3+frAX/ztxpwmOuQ6a01hYVi17Hz8cteiCOteYIJYgJXNMzB7mBerZznKF3VI759BZAe9+haJ2++Bz7PEqFDHe1rrkX3njwA5HhA2L6b0AQ1+B8RP2b2WVy11jhAOGb4mceGK5kz089YkDwI4sGStyg8eL5cNQ6cNFBJ4oKbNGwS P6SzcTcZ JvfOfeQligDncSc8uTb0wbbHHwI4AnqGPNyB7mddMz1D/AWM1bbmCj9NqGEyJxCNmywHebEz1NV/FYjtSx7P/WDQuMj/nswi3xF5gf/Y5rhq8MH8MwXKmQ4G1MuMoiJmfFxxZEXJlgH2xL6LnGTXeAn4QdXyA1BDGVHb0MJhsY1b/HJbvUNrXBBd0zGzKZpgGjNKgfKPqKPBf8C5bX7k/Ya2eiE+xUd3xJnYs72xa+tHutwDJWZvKQsj6ae4tktFRqSRR/WRnYgsPk9L3wa0JeGHGc3YvDCcTRXpOE3bDCRCF8aL8nYP8FylvEtZigAqBuof6FBEFO//d+vgypQvrs00c9LqOzWUFsRWB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: OK, I won't insist, just a couple of notes. On 08/04, Linus Torvalds wrote: > > On Sun, 4 Aug 2024 at 08:23, Oleg Nesterov wrote: > > > > What do you think? > > Eww. I really don't like giving the dumper ptrace rights. Why? Apart from SIGKILL, the dumper already has the full control. And note that the dumper can already use ptrace. It can do, say, ptrace(PTRACE_SEIZE, PTRACE_O_TRACEEXIT), close stdin, and wait for PTRACE_EVENT_EXIT. IIRC some people already do this, %T just makes the usage of ptrace more convenient/powerful in this case. > So I prefer the original patch because it's also small, but it's > conceptually much smaller. Ah, sorry. I didn't mean that %T makes the Brian's patch unnecessary, I just wanted to discuss this feature "on a related note". Oleg.