From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B459EC3DA4A for ; Sat, 3 Aug 2024 18:58:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 748356B0082; Sat, 3 Aug 2024 14:58:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F7D56B008A; Sat, 3 Aug 2024 14:58:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E76B6B0099; Sat, 3 Aug 2024 14:58:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 40CB46B0082 for ; Sat, 3 Aug 2024 14:58:19 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B641F1C5082 for ; Sat, 3 Aug 2024 18:58:18 +0000 (UTC) X-FDA: 82411844676.06.3FC9E1E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id D830520010 for ; Sat, 3 Aug 2024 18:58:16 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=o5Y2Rmax; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722711490; a=rsa-sha256; cv=none; b=UUX21yH1NHJ6x2lcV9YzaACPnnm6jg4m6dtLJZLG8V9W6gNHPDLZebqDB30BkNRb2Hr6wp eXxOH/mlNvj9OYApXzm3oqO39yTiu9ViOuZ30WcyV2ov1beH7OFzv/sRlGt4PB4w83iaw/ NIJPjSWB+dhGja4De7o9+b21jIX/PLg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=o5Y2Rmax; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722711490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qZKREz3/vk7QZ2ALsDIHZTU7fuD6PXs5PnhzJoLrsnA=; b=GHieKx6mgqtXza9DYz3AJa+LOaTmfJ/55L3O9fmQNBK41t66UpgANhu6V2gFQe/KBKxJGp VLpzbQS/Y10l65GAId54ygsydONeTFEni5hRFIkAE5mIuTcSM4LEY30cyA999d0o7rzGUM 8dFqr4yn6OQtEK2NfPblRK+xlLY1qnc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 45FFA614E5; Sat, 3 Aug 2024 18:58:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93706C116B1; Sat, 3 Aug 2024 18:58:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1722711495; bh=Tpqmomamf68VJd3BX6Aa+aldBw76MPQW/c629qHRnbg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=o5Y2RmaxDgbz57iITn10F1azWivNnKphArt1mFz2o1k24QgUghcLPFcCl4Skc3J7n 2U6mfRYJicjGnJ/Lcha0tyWotwjt/73kHML1EvfQheasAaHT4z+JnEhKa6yfFin34R FpUPzEcCObDFHQbrY87xJxqJmIAHp6RYNOzd/x7s= Date: Sat, 3 Aug 2024 11:58:13 -0700 From: Andrew Morton To: Jonathan Cameron Cc: Mike Rapoport , , Alexander Gordeev , Andreas Larsson , Arnd Bergmann , "Borislav Petkov" , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , David Hildenbrand , "David S. Miller" , Davidlohr Bueso , "Greg Kroah-Hartman" , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , "John Paul Adrian Glaubitz" , Jonathan Corbet , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Samuel Holland , Thomas Bogendoerfer , Thomas Gleixner , "Vasily Gorbik" , Will Deacon , Zi Yan , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 07/26] mm: drop CONFIG_HAVE_ARCH_NODEDATA_EXTENSION Message-Id: <20240803115813.809f808f1afbe9f9feaae129@linux-foundation.org> In-Reply-To: <20240802104922.000051a0@Huawei.com> References: <20240801060826.559858-1-rppt@kernel.org> <20240801060826.559858-8-rppt@kernel.org> <20240802104922.000051a0@Huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: D830520010 X-Rspamd-Server: rspam01 X-Stat-Signature: tjecxkazebey8ryfq1aiz9ufan4n8peo X-HE-Tag: 1722711496-314077 X-HE-Meta: U2FsdGVkX1914hIueuBuZUInPB6RHv7sZqDEjw4/G5V2tC9zk6w5TezhdA7nfTwCsqQ7vSZkQtjfR0NSAeql6fChKlKnYdmcCIGO2rpdGj55Wcpjyil9r6suDLUdBGHrOACwhGZpHrFFAjkRGIlWgoMGN0NBKZiCSNa9ZBHgo1RzGsqQXVb3jQLYA/0OQ/MVDwVflcdpa85XwCEiu3mOfXhVtvgD/Xws1NK+i/8nLmVXH/SQQX3p+SJjOEqI52VMY1FwpG8nZ7yygE1w3AyKVmLoZdmKEwRbCtYRG6xMDUJA3SUZYOsVvU/jYOCgoPCHUhJUTnyEFOpZPXLYXCFbKWqhZw07VELd+i17p/90Xkcbn5ewJxwfsL4coBGfu2PRH41d63fZV0ODpWjdHKN2fGmgkh8mYnohRI7TvIqFfYT2T21yossLlZnCd/OHG6eTXej7Q4Zym8jvG446MUo9o5wLQbEkPGOOtKlI03r8/S9crhhWubZYO6xtJJ/fX0Z2+IP4KzkmEQcsXCKNXCPc3pPsN1QsH3OCp7re58d7jYs0EGgrh2B7t3FhRpUbNx1dH3DARedklLpmZ2lkN4vpnqyDM7CMH0g86sJtPTHpbm4v+V5ebSoPlAmEhd6er/eeoQn7euhzplUd4He5z8X9sC+JgFOthpOMwt4oHQH3BYl4NEDEAIQNbmzGwxiktTIWsUyztd/Bbr/jfY6Da6fAZTju6aHNctYw3Kzl1nbXcsBUCXfz2XVaH/rSzw0t1cuyUzbF3GDE3yZe/7uUqEtfgQ+aZUc7wIfauzX37dY1I2RQemAU7mCWJzdBlYFU3rDmnbFi9G9pKiBMjrtvklDcnFfaPx4fz1sSgBCT6pMKAeNQklqvgchTEsONwwULYoJUSOVcyK1LzBrx77beGGkAv7q70axjOi5pqIaCDIPX3HgObeMIJ9CbK1DTW+4GKSRAlyM7v/JBqrjvBxrOefK y2QKbUT9 2EsYjf0ChARSv/lalQcCHk26E7qPpOb3U26Tbx4zj9n4XGKyz7URIXEMgLDPEljSG/1riP1XfMws/laJEjhaWFK7yx7DXeZqKnmhiqyHCPgh6SpKPX5wRf6UK1hAzO8VNl691qInl9MgQwVXTHa7SnnqK1M1LYAOS+Qx6HeTFcGQODigttc4hMdpNfSxWCHjOtrDqDBju7q+EbmdNSMj7+6nF0CB626OIpTKRVw7SJ4Uz450/srLgLatyW3+e0JdBMKft7misxvWdRb4taB0Oj5XqhHwb5shWyaUsg2pL9HnQ69AxgsK/FYmvQOk/OKKazxiuxNyP1tSsBN57TiplEKX9ew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2 Aug 2024 10:49:22 +0100 Jonathan Cameron wrote: > > --- a/mm/mm_init.c > > +++ b/mm/mm_init.c > > @@ -1838,11 +1838,10 @@ void __init free_area_init(unsigned long *max_zone_pfn) > > > > if (!node_online(nid)) { > > /* Allocator not initialized yet */ > > - pgdat = arch_alloc_nodedata(nid); > > + pgdat = memblock_alloc(sizeof(*pgdat), SMP_CACHE_BYTES); > > if (!pgdat) > > panic("Cannot allocate %zuB for node %d.\n", > > sizeof(*pgdat), nid); > > - arch_refresh_nodedata(nid, pgdat); > > This allocates pgdat but never sets node_data[nid] to it > and promptly leaks it on the line below. > > Just to sanity check this I spun up a qemu machine with no memory > initially present on some nodes and it went boom as you'd expect. > > I tested with addition of > NODE_DATA(nid) = pgdat; > and it all seems to work as expected. Thanks, I added that. It blew up on x86_64 allnoconfig because node_data[] (and hence NODE_DATA()) isn't an lvalue when CONFIG_NUMA=n. I'll put some #ifdef CONFIG_NUMAs in there for now but a) NODE_DATA() is upper-case. Implies "constant". Shouldn't be assigned to. b) NODE_DATA() should be non-lvalue when CONFIG_NUMA=y also. But no, we insist on implementing things in cpp instead of in C. c) In fact assigning to anything which ends in "()" is nuts. Please clean up my tempfix. c) Mike, generally I'm wondering if there's a bunch of code here which isn't needed on CONFIG_NUMA=n. Please check all of this for unneeded bloatiness.