From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 590B5C3DA4A for ; Fri, 2 Aug 2024 22:22:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79FB66B007B; Fri, 2 Aug 2024 18:22:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7508A6B0083; Fri, 2 Aug 2024 18:22:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63EB66B0085; Fri, 2 Aug 2024 18:22:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 44C9D6B007B for ; Fri, 2 Aug 2024 18:22:04 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 93A5940580 for ; Fri, 2 Aug 2024 22:22:03 +0000 (UTC) X-FDA: 82408729326.22.714ACB8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id C7525C0018 for ; Fri, 2 Aug 2024 22:22:01 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cqbn59rk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722637274; a=rsa-sha256; cv=none; b=vSaVjOmSXNetkbPJ0t33jndJT5ifbJo8rzEHpabv+0WrNCQMtiK8QMzaASqM8JEqim4PLv Wq4gjxB3G1ZjSf8/BU0YOhLe/C9NWydU2m0W34hA1OvarW0omqmoNxjkHqA71uBdj+tQDY X0lambDIVlPNkyz74kGeJWECotkE+t8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cqbn59rk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722637274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aWddOL4huCXK8ZmFVBtZPClQfZwV5rM5X8tjOAmTyog=; b=o4+XIF+eZdRIS7WN3WbT72sTnryrBF/z/MoeBOqDp5ONEqqGnTeUytD5MHzklHn3bqQqzC mlEIsETEZ+3C6XEfe3BBtbEkDtRQ7+8OtDxWpnQUtUSZDJ3qMfwynj+i/GMFtG9kwI3+8H NmU4OYV909TS3z1PgADoRPcEEhg3ARM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722637321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aWddOL4huCXK8ZmFVBtZPClQfZwV5rM5X8tjOAmTyog=; b=Cqbn59rk+8I6J750OuU/vEbIZhMTf4G2ZoAaqZtU+sqkPh31tN79mZ4+Z9vvggmMnQZeaZ Wqwwl/KGNU61foO6vZ/zi3pKXdIQEFP1jOwPk/6FZYKushbB/ZF8AdQSAj14B1QO8qto4z 3C/k8ybC+1zMZFL7BvRmwqntSh++90c= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-271-kC7maBpROvmsyDx2ahMgdQ-1; Fri, 02 Aug 2024 18:21:57 -0400 X-MC-Unique: kC7maBpROvmsyDx2ahMgdQ-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9E6061955F67; Fri, 2 Aug 2024 22:21:54 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.3]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 9958E19560AE; Fri, 2 Aug 2024 22:21:48 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sat, 3 Aug 2024 00:21:53 +0200 (CEST) Date: Sat, 3 Aug 2024 00:21:46 +0200 From: Oleg Nesterov To: Jeff Xu Cc: Kees Cook , srikar@linux.vnet.ibm.com, Ryan Roberts , "adrian.hunter@intel.com" , "glider@google.com" , Matthew Wilcox , zokeefe@google.com, hughd@google.com, luto@amacapital.net, "jmarchan@redhat.com" , "rientjes@google.com" , Thomas Gleixner , Ingo Molnar , LKML , linux-mm@kvack.org, Andrew Morton Subject: Re: question on [uprobes] special vma Message-ID: <20240802222145.GC20135@redhat.com> References: <20240802090040.GB12343@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C7525C0018 X-Stat-Signature: 36o7wggh9o7ukfjjpu54hh9bqnjwbx9c X-Rspam-User: X-HE-Tag: 1722637321-775967 X-HE-Meta: U2FsdGVkX180Io/e6aXY1NJ0At6LO4ydHJxbGpGP8KNud1kc+rMdFZq4mN+abyuZcfh1y9ct9wOXdCStigwM2KbOEqxp7W4G6IY+FMoagDLrldOgAyvSFmdTsWT4chAfhzqOqyYzOdU4Ugun2149l/BYGwwnoDphnSLAAP+kFjRon0RCP0kfQtFQixfvL+ppw5SQr+UB3tDCc3oVbn+UmzfEkb+K8wZPHW4hC3N4ReYzbLakiOOn1uDVyO0kndQPwUD0ubkCiiUdUtcjLm2grwkLMh48sj36OuECqsxPawDGShty8GFFeEJgXmRGAFJlpK1B24x+c3Z/HW6VOLUuEMjdr+jfN1X61VsVusXoVHiwXutCEKmeFrTfrGQbfJQvUJO0NQ8wvTCeOyFv7h5EJYa6Tia4IE/LyJq4O8L1QTdbK4LMNv/grpAZd5BadQ1Mpb1ELODtX8uE6gOZPiakd9l1AzgEPvEZoGEiMs2lg8/jMRoBJI8NnVchFD7Wz/0hoeZKJPXybVrvwhZ7yCDb72AWkjIzVxbrUODDn/PpciBRzeNN3V0tY1vlIhI6//2mjgqdZ6uQ4w2nH71j1lPZ+AYE9wi3gNwTt7wucsn5fQkH/n595Dy5SxAGrUA/mnSSnDd3CAbmzBSjpePwokVXKe46UE3sUqO3BV/RSEwRtfi2tRzJx3EGX8DSFmpHJKp9O2mOydWhjWUiElKLtJwU817Hd3/nP15TOSF9LgS127V4jGXm2ZZ6FQLhCAJXfdsqwBrkWKSrZnYlEMeVK8oz1yTmMnm+TQ+8M1mexkP7OwG1DnzrGA0NfkIvQi2UdAHCQAg65vfC8qLP6ghX5XOgvJ3jA4TNZVgtVr7zbWzAL8rh177pRx/2c01b+exV/B1VZP4AsEbQ/V1HAzN4RWbghjEbiqPj6RIFEMgIuoKXTI7NW9WHorgeiedI9xsCLfp5jdEid2elSoVefawwDlM zsg7zxbR XsmGMIy23rzk85ThdWBsZmriz9TKPXCR2YSd/QMFZIaVUu+Le0r8DosxF7xq10XtG9BXOagEgzu3LsYplbZDUSpjID4PO2LAvtULCjdx8Z4nlCM34lyMYic1U8gtQu8zK7qwpsFqBUCSCTKG5shG06JQmE4WWLJccZ7oIi6YuyGCwekWfWyh6FQfmVjkpKQcftAqB8z85ur8iuLNKHtE3GsS7ASYVpYif99bm1HQwtziEsfoFnYjFJGz37SkaCjZFsLubzMK73IHJgeW8otFBP25t4B8tSG+6bb8jBfagW6Zw8tWoUaiHvfiL0muyb/iyQdzKGUmZnnpWFTb9rrq/3xpHKIOAnLilCjZm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08/02, Jeff Xu wrote: > > > So it seems that xol_add_vma() can just pass the additional VM_SEALED > > flag to _install_special_mapping(), no? > > > Yes. Before I make that change, I want to confirm that [uprobes] VMA > is immutable during the lifetime of the process, hence this email. OK, thanks, > > But why it depends on CONFIG_64_BIT? > > > It needn't, but the vm_flags_t in the vma struct for 32 bit is full, Ah, indeed ;) Thanks! Oleg.