From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6958C3DA4A for ; Fri, 2 Aug 2024 14:01:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28B476B007B; Fri, 2 Aug 2024 10:01:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23BA26B0083; Fri, 2 Aug 2024 10:01:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 102F16B0085; Fri, 2 Aug 2024 10:01:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E701B6B007B for ; Fri, 2 Aug 2024 10:01:51 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4AC8E81287 for ; Fri, 2 Aug 2024 14:01:51 +0000 (UTC) X-FDA: 82407468822.23.0A7C7DA Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf01.hostedemail.com (Postfix) with ESMTP id 58FB74002F for ; Fri, 2 Aug 2024 14:01:47 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722607250; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AIP3OuRBlnIr3lgE5/Fael2xwm96YT0IH5qVhAMsZCs=; b=jdSQjKzAGaN5FxE28w8ag6n7NnlllLjbMr5bjk7cPz5FcQXY8Si/MYo/TQXYke5p/6DgPg bIFMgaDu/xcNV7A4rJ33KnOlZ7B5O5aRz3XEKUBt/KquSKnDQPh97BSBb5FsWdS7HJ+lDv nU1kNKcKFUhRJn4BrO3ICHeapOV/t9s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722607250; a=rsa-sha256; cv=none; b=SCD9X2KvfaQQEM7drMUysWdN+bpuN8vkMK/UxvwRXRlsJfubdgjXQXzSRdyc95JyZu3PuR Zvy3lrzzhd9AH3sbAQPOAKZa11uZx8Uc2VlCbwFC5j9pEDU4q9IjDUNXF1H5ijQ7oPoXZr Q7lthmE1CseP3imtdnEfKJUlEKRJC+4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wb6rS3QPSz6K6ln; Fri, 2 Aug 2024 21:59:04 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 429D2140A86; Fri, 2 Aug 2024 22:01:43 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 2 Aug 2024 15:01:42 +0100 Date: Fri, 2 Aug 2024 15:01:41 +0100 From: Jonathan Cameron To: Mike Rapoport CC: , Alexander Gordeev , Andreas Larsson , "Andrew Morton" , Arnd Bergmann , "Borislav Petkov" , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , David Hildenbrand , "David S. Miller" , Davidlohr Bueso , "Greg Kroah-Hartman" , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , "John Paul Adrian Glaubitz" , Jonathan Corbet , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Samuel Holland , Thomas Bogendoerfer , Thomas Gleixner , "Vasily Gorbik" , Will Deacon , Zi Yan , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 23/26] of, numa: return -EINVAL when no numa-node-id is found Message-ID: <20240802150141.00002143@Huawei.com> In-Reply-To: <20240801060826.559858-24-rppt@kernel.org> References: <20240801060826.559858-1-rppt@kernel.org> <20240801060826.559858-24-rppt@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 58FB74002F X-Stat-Signature: uufx6jy8yig7ykiebf9f1gcf7r7xmfai X-HE-Tag: 1722607307-46244 X-HE-Meta: U2FsdGVkX1+xEKkTME85uHJiglKYZntih3NqrbEf0vNPgVn7XipIKRTvyQ8oyVssG+q+N5b4Tkivn72aylGXItGk0lq0bwCWbtHcIxCO75Ed+Jw7Q77hsIplWNXyxUnNw6YhEmfOb4m2w+kztFaB825EMShvTYfQUjyojNwOw4sNnLF0v7TgwTkq2K/1jKTNCk26sNskzCX0RQuA45J2xZPUvFa7Uy6RDCeHl0xHHLNOo0zYxBUS/ePlryuN2tFc6wHEUon7unhqP+4uYRPndbZnPa/BBU3IpMGBBW2b/9VPAITApMhu0eAyNHvgb+8Gzc7tA0BHqvEXqCRx0o48IcDwPvGWAZUo9s/CQEz7YO8G11C8TC5PVU0/k+0TwHWI9zi/nFwTOvnRBaecE6ZkzmKBbfG75UpiTKSpxr18+wOf7xF0UphG91BmXcRAtvbR4gwhYkwVC5awqqyGphKZtUJ17oo/Z6ERQE0MZwI+iU8NCLNRr+4nUz3crlzUwK2wR6gHhCGwlAZHiTXIlGM23pOavRdvSSkZuJkL5kEiS8xNjbUXCYiSZ/SQU7e4SE8X68QEjdw70SC1vR/3ywKgiHasGrWEQQnKCbO/8L4Kw6LNMcJEgMoPXXmgvoJsDpAbuz1pCEIl3CQ0Z+Myner22122SBxUvvlLZCDFOolMYFKc6J1GRn5NtgGGar2UPhWwCxGgGuSFzX31pD9jbG2K/XoL8wljzPnwgIhhEJkS8t3wgyAdpXaZN1siaYmvQ8Wh5nQkPLF0nAhoA/olZAghNJpJjWeh2tIl0Uc7t+jZ9ZgiOs5016Dd/jTuM6t3o4cRCeuRqRiVklYs7XJyQGsW4LYYDlrcl4f+POq7mnNRGBWuWMloYnkeiGbOWuJCtu5ZLAEHzSnBjlTbAacvJzzQfSIIwbRFI+Oj3JI8onVq6gS1PGSRSAyCyFrbUis4MWmNNDH+wYmJSpZ1dIYMc1K 1I4lSBKl rQg/Z9XbeKfJGa7DwJO1IPm21AxOtMcOl+gRkqyQiHMV7XosLn4/Fs5E5RQv7ebJlgkaUA++SOJ04JzpGtPDZxz7igcxQ1Hbe3cffv3IGWyG59W6wLiEnInanXd5iu99z+KVYo6IQ/bDn4aOCjT1ldPysp6zZTvy4B6mxguhEz095OYAq2t3eMTCk526JhO/JDXWVRea0vPkP2H/g2pkkhgMr2AwQFhErN0My+a8qeTAtnFiWWhU25fOqFolcQBUWJNxh3R2oLoYaPcwhMaDPAZILHquzhJPF3g5wYFMDfc8zznzvER5R/eH4pQshCYn6ff3siBnmPEaH6Ew= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 1 Aug 2024 09:08:23 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Currently of_numa_parse_memory_nodes() returns 0 if no "memory" node in > device tree contains "numa-node-id" property. This makes of_numa_init() > to return "success" despite no NUMA nodes were actually parsed and set > up. > > arch_numa workarounds this by returning an error if numa_nodes_parsed is > empty. > > numa_memblks however would WARN() in such case and since it will be used > by arch_numa shortly, such warning is not desirable. > > Make sure of_numa_init() returns -EINVAL when no NUMA node information > was found in the device tree. > > Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by: Jonathan Cameron