From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E45C3C52D6D for ; Fri, 2 Aug 2024 11:12:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75E146B0089; Fri, 2 Aug 2024 07:12:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70EE86B008A; Fri, 2 Aug 2024 07:12:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 623876B008C; Fri, 2 Aug 2024 07:12:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 440CF6B0089 for ; Fri, 2 Aug 2024 07:12:39 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A8D4DA7DB1 for ; Fri, 2 Aug 2024 11:12:38 +0000 (UTC) X-FDA: 82407042396.01.C02FCC9 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf26.hostedemail.com (Postfix) with ESMTP id A2E50140003 for ; Fri, 2 Aug 2024 11:12:36 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722597099; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8b9A5BZfBQlUA+9ZExC0momrTSS04EJ+khHCDZ39nyQ=; b=qwKp1q9YXO0Whje62sG7+tXNZfFowuunNXAfCJ5VUXfPuXjlglf61lqongredxvG7+TS5m 7g0WoHcNI6/JcoNS2r2APEPZW4isIZ5hQ+mu+GmHBS9XKX2jMzEQGd6JhQzFZh1SENVauf 1eu4cLGe53iLDoxEzdMDhNitvRtdYf8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722597099; a=rsa-sha256; cv=none; b=EfvQLdNK7J18xlNQDelQFPsrsIcvkm8S9Aq+Qt8dWv0yRH2areerSCX97nLcxm07L+t8gp Yz6WiKv0AqZ5IgxPLC9+Yn0lXqJdb7zX8nJ1098UJNK3biMlwNBVACMxblowxd+gc0cFVF sWR+Ny/OqegNlyOSEUsVpbmKp8LHEuA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wb35J7183z6K9Db; Fri, 2 Aug 2024 19:09:56 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 5BD1D140A08; Fri, 2 Aug 2024 19:12:34 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 2 Aug 2024 12:12:33 +0100 Date: Fri, 2 Aug 2024 12:12:32 +0100 From: Jonathan Cameron To: Mike Rapoport CC: , Alexander Gordeev , Andreas Larsson , "Andrew Morton" , Arnd Bergmann , "Borislav Petkov" , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , David Hildenbrand , "David S. Miller" , Davidlohr Bueso , "Greg Kroah-Hartman" , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , "John Paul Adrian Glaubitz" , Jonathan Corbet , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Samuel Holland , Thomas Bogendoerfer , Thomas Gleixner , "Vasily Gorbik" , Will Deacon , Zi Yan , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 22/26] mm: numa_memblks: use memblock_{start,end}_of_DRAM() when sanitizing meminfo Message-ID: <20240802121232.00005b2c@Huawei.com> In-Reply-To: <20240801060826.559858-23-rppt@kernel.org> References: <20240801060826.559858-1-rppt@kernel.org> <20240801060826.559858-23-rppt@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To lhrpeml500005.china.huawei.com (7.191.163.240) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A2E50140003 X-Stat-Signature: wncoika4x17w9ihr1dq6crwx1yhwis49 X-HE-Tag: 1722597156-867557 X-HE-Meta: U2FsdGVkX19DeOH+KxfLOBgQxrfEjxap7ZTmvZSuIqPUwPXa4uMSZ4B5CdsvDCQqpltzub15qivF99V4Czr4FYDfRgKB45UlxFq7a/qaQKgLg4JxK0fnjSctfSKZYa874uqbwoinU5xxCP9A7kQKpkxfLmeXd7ylMEm6LgQQIAC+EfSHQ9nH+5VU44GFjXR7j/NMo9ZTJY73HyegGJn2y3qlybLSZGturhvKguiFPyM1XK2WVf78oxG5IbhahoTebhndLMNwPeqEzj1XU+SveBnaYwpSE6uXjZOxY6dAY6ilv5XeN87en2+Z/pvGP9/KgkmXhgauIxecQqWwVOx7JvBdKB90aob1dZViD5v4ErnR8goD+cVcnJ0IGqgpsjPjQSbOrPijBDc3mFqTeqes21nwFGCls08ZC+V+pzQkwOo2vHTMnpcgdaYIR7R2EkAG9cnbdXohvekp3ZckUSVDBPQMlz4KbWU1CbBQZf8Q08cmr7uk8ylGckJo8Vth73dQ6wR1Z4AWm5KrZhhmO/zNhw0AAkLgJyVl5r3T4D7mf+YzpECBMsms+x0VJC2Vl0h/mWgHsqJUjvwesArLIfASQztHZVgPtnR2zWK9kz3HDXpq8eu3EyUa7IrVWCRGKcHwVFaqvjubxP1a+4zrHYIrUPccUZMzOe6lzXFpbkTybDjT2mR9QUIf3sSub2Cd+lidwEyFitIi7UPPjGXkRY5YK9mN3Mp7mr45j8LxmtHkzdz95K16DbiEQI+hHiOhY56+b52/GbLcqYL6Ik+ac9xc5qM7UuceFAWmwFH4V6tRcxKj2jWDH7qRtEoTepC88NOIyre5Oy8gRNZ96UkG6Zlq48/Xo8nizBcswcUaDf4Y3mjx+jSZyZgX0NlsSr9/Ll0NMGZUXcCS7C2dfXx++tXYSmqfzYqNHjA+rPob9FYznYJxRb8g9gnmCUTq5E0lFmbvBjhNVR47xqKOq6AnuVj +GmegQJM X22ZxQ8szEv0XT73ELFMI9mtQYBEoYIHZFjhktLe11KZ+Phc1t6HJoypv1A3vy42X+xlmo9oKhgp/E2Jp5GleiiWM4xvfmXjuj+H9vF/vCsEv9lAZbfUA9QAreqYvZrC11TaU41UJOS/C3zRsac5XCZrPh/WOWk94YL16LwOK1aEFknWU31yCXjCCnfvyulDTS+ofXWn+u6+ifmvadKyQ+coPiHSsgF4ZGGyx8JDmzAMZKsAe8ijNxa6UtHSq0/SKINTZkY5/Vei+hGi7wZ/qHlMwUFC9CYjpB+CqyMTZexplXZl14JfiIIjWKnAhgUSRe9guaT1pE2BVDH+lAbIlRrxWNUo8wd/B7lg76RVhdPkcom7alAXKT4U88GeYoHiCKtI/V4aAVyDY6dZdSsij1b0piA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 1 Aug 2024 09:08:22 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > numa_cleanup_meminfo() moves blocks outside system RAM to > numa_reserved_meminfo and it uses 0 and PFN_PHYS(max_pfn) to determine > the memory boundaries. > > Replace the memory range boundaries with more portable > memblock_start_of_DRAM() and memblock_end_of_DRAM(). > > Signed-off-by: Mike Rapoport (Microsoft) > Tested-by: Zi Yan # for x86_64 and arm64 Makes sense Reviewed-by: Jonathan Cameron > --- > mm/numa_memblks.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/numa_memblks.c b/mm/numa_memblks.c > index e97665a5e8ce..e4358ad92233 100644 > --- a/mm/numa_memblks.c > +++ b/mm/numa_memblks.c > @@ -212,8 +212,8 @@ int __init numa_add_memblk(int nid, u64 start, u64 end) > */ > int __init numa_cleanup_meminfo(struct numa_meminfo *mi) > { > - const u64 low = 0; > - const u64 high = PFN_PHYS(max_pfn); > + const u64 low = memblock_start_of_DRAM(); > + const u64 high = memblock_end_of_DRAM(); > int i, j, k; > > /* first, trim all entries */