From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99BBAC3DA49 for ; Fri, 2 Aug 2024 10:36:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E69C66B007B; Fri, 2 Aug 2024 06:36:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1AAE6B0083; Fri, 2 Aug 2024 06:36:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D081A6B0085; Fri, 2 Aug 2024 06:36:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B6EBD6B007B for ; Fri, 2 Aug 2024 06:36:40 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2A10E81198 for ; Fri, 2 Aug 2024 10:36:40 +0000 (UTC) X-FDA: 82406951760.12.F2495D7 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf01.hostedemail.com (Postfix) with ESMTP id 0727040009 for ; Fri, 2 Aug 2024 10:36:36 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722594952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nJW4jNNQLmtnlE7ahmg8OIhyWw5dpzxU7vPlkNyo720=; b=r4OEt1BU4cPM5p+JALoErEr2oWEoL2K8MaaYVAs6zqDWkZpJnFdsVMZKN6wBtu07S11KAb pTYAioQ3u/evVgLyQOps7Ug3zYpB/r0NALtxlAKLkrVZsGn0n7M4kE/jNwqa7uEw4mUMjV TXVs3Vg4SBNbA0y0RSn4op9dX7SmBzM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722594952; a=rsa-sha256; cv=none; b=r5ywLY3Ciwe7l7pXbaLO9m2sSwYc16PbxsyH4w3Dhfnu6745Y5DZpOuwJmqQFwzbUro2ht tvmHUaLpgBuup65P7Hrl4p+ygpTBPIAV/kMy5ru4zDuz/afAF1UejLx+66c3ypJI48D1cK xe57tYiMRoXjNgsTQpiVj0A4wz0lUe0= Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wb2JN02Stz6K5nV; Fri, 2 Aug 2024 18:34:28 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 90EC81400D9; Fri, 2 Aug 2024 18:36:31 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 2 Aug 2024 11:36:30 +0100 Date: Fri, 2 Aug 2024 11:36:29 +0100 From: Jonathan Cameron To: Mike Rapoport CC: , Alexander Gordeev , Andreas Larsson , "Andrew Morton" , Arnd Bergmann , "Borislav Petkov" , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , David Hildenbrand , "David S. Miller" , Davidlohr Bueso , "Greg Kroah-Hartman" , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , "John Paul Adrian Glaubitz" , Jonathan Corbet , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Samuel Holland , Thomas Bogendoerfer , Thomas Gleixner , "Vasily Gorbik" , Will Deacon , Zi Yan , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 11/26] x86/numa: use get_pfn_range_for_nid to verify that node spans memory Message-ID: <20240802113629.00003069@Huawei.com> In-Reply-To: <20240801060826.559858-12-rppt@kernel.org> References: <20240801060826.559858-1-rppt@kernel.org> <20240801060826.559858-12-rppt@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500002.china.huawei.com (7.191.160.78) To lhrpeml500005.china.huawei.com (7.191.163.240) X-Stat-Signature: nwi6omq39oio3ircxsynd7u7f1guwmb4 X-Rspam-User: X-Rspamd-Queue-Id: 0727040009 X-Rspamd-Server: rspam02 X-HE-Tag: 1722594996-609446 X-HE-Meta: U2FsdGVkX1+ArfHGVnZPd52UkOh0qD81NjRd8Nvgwhh/2+UeU5IYeaH/rV1FUvhK+fMISINcVTe6NEkkZ3OuT0tLiQafBTTgnHlHjIsXW5tR1NpdRTtqEkuMgvWH8wJKDcv/F2CHsZpnIGd9kQ0Fi3BysEwswJrgq63E3b1PpP0SkeDaq6YPEDiQwtqlrmIFejnEXEe1HGJ0tVF81yUMNkG1Ullv8HaU13TalMmEW3q1IYjvPTeRrdGV/C2IZui6U7JLVEXQJd0eeKIHgjttWBqGInfBxk+PmjquWaIC21QX6tqJ4UrxMLpoAV1rZSeHFY0AqkkuwNJlrCxyz6iy75m4nkK5QvwdimFwkV4KCWLwxNXfIfYbPjwxT3zvCmy9/aTHbHoXrnnHDi7kpZ0r8lacgycYgzl+PFaI6mnd2aZuYkxp2WAKDYWjGJMswbuIMUgX7vNAoXRR/+cDmVX7k+Ain9u7/DK0KAMgrOMbNGTrKCnUgd3aFD3qC7mUYT0gXQsQCEMKkWUg5C6FT+yJwZn9yp4r1bJ3bAQaEE+XEik8l5Z+CnNclZsFP14DNtuTkxEmH91Ei15IwO0C1RS/tffwfclXC6xaPr6ITuQ62iPaKEuPb5NfUOfe9Kk1y6GgZkR5htb+d1GKGyUh4EpruXRBwJH+xmuqDhrLh774DwfbQQzzP4KiPwCdfbjE6hcuEAWugdHEkgZwuKj8gzSwxiBW+9i+x/OJPdM6krGuN7hBCZlScg+ldcKrYYqlSe5QV65BJ2tcJ5bUoK4b8erPCbJwo4VNhsShYmyDXtL3wgt3Gm7bh64xExI7dVq+t17G2s+FAC6w4s4lgJ7SxFe96UrxYC7KXoQbhYRjuPKr4f+IQZ/ctnsmgW8V8HRMHWit0bm7G/qtEp20reN5BWYIkHwHCepn0eVNS2JxOVlg5lgNMQnSb1ErlKmtqZjEIajxeebOq0JBy3VwuiZaI6s FINAF9Pm OLwMqYcYPSKzFJnOU5CiFUdy8iwl79PLUNEBD5udvrQibIYlLJkto5J1IgJmKXytz0SL1QOngu8dIGtlj7+DKCkWBgopJc1z/IRPgqP0WiGNurQInl5ll9W3vzAVRJ4njTZelTLNBszZbEYoK8H5+CoK5qyDdHiaCNqsJ8lOIugQaZBfg3G9yJD8yXWAsmr1Gb9UFvTHiCd7xOd+VtMU5NVVfmXz++813GR7SrD0yGxjrgTDvYvb1qa7R57mwGdZ4K76CFgKuDlONRxZyd4AB8HLKGVGQ7gu4fHYuT1ZW2y9gZD796xTylBdXp9quvkBSxltB+ql2Z4pW3aNS1rLI72Pe+1wYvW1GF4o6j5EWx+jsJ8m34a0+0T90Gxb+yPHBgeeP/6/2Z9RRLWSipNoV3Ul4DA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 1 Aug 2024 09:08:11 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Instead of looping over numa_meminfo array to detect node's start and > end addresses use get_pfn_range_for_init(). > > This is shorter and make it easier to lift numa_memblks to generic code. > > Signed-off-by: Mike Rapoport (Microsoft) > Tested-by: Zi Yan # for x86_64 and arm64 Fair enough given code a few lines up has set the node for all the memblocks so this should I think give the same effective result. Reviewed-by: Jonathan Cameron > --- > arch/x86/mm/numa.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c > index edfc38803779..cfe7e5477cf8 100644 > --- a/arch/x86/mm/numa.c > +++ b/arch/x86/mm/numa.c > @@ -521,17 +521,10 @@ static int __init numa_register_memblks(struct numa_meminfo *mi) > > /* Finally register nodes. */ > for_each_node_mask(nid, node_possible_map) { > - u64 start = PFN_PHYS(max_pfn); > - u64 end = 0; > + unsigned long start_pfn, end_pfn; > > - for (i = 0; i < mi->nr_blks; i++) { > - if (nid != mi->blk[i].nid) > - continue; > - start = min(mi->blk[i].start, start); > - end = max(mi->blk[i].end, end); > - } > - > - if (start >= end) > + get_pfn_range_for_nid(nid, &start_pfn, &end_pfn); > + if (start_pfn >= end_pfn) > continue; > > alloc_node_data(nid);