From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E0AFC3DA4A for ; Fri, 2 Aug 2024 09:57:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C8BF6B0085; Fri, 2 Aug 2024 05:57:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 178FB6B0088; Fri, 2 Aug 2024 05:57:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0403B6B0089; Fri, 2 Aug 2024 05:57:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D80496B0085 for ; Fri, 2 Aug 2024 05:57:01 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 87BB614112E for ; Fri, 2 Aug 2024 09:57:01 +0000 (UTC) X-FDA: 82406851842.20.7DBDE96 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf09.hostedemail.com (Postfix) with ESMTP id 9376A14000B for ; Fri, 2 Aug 2024 09:56:59 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf09.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722592572; a=rsa-sha256; cv=none; b=IMVzam+Cup6rfPF9Msfc178BVlY2h/PbkOs8AFL6LmzQH+rDtG98Q63cmZ7SEsx4ycT9Ej tfA7+CuVf7+dQLOF0gzuk89JsIg7dNfaEl7hFY7YwvdNHqyuQQKRT0bEmTFk6G33+icWwH pz8/ir9eidtgT0BbWnFidhc+rg0XHd4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf09.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722592572; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QP8i3MWZSpkMfGe+UgTBPyps7S8ifaNhGFycbasj2LQ=; b=dNPehWuOe/zlsqzeUbJv8qH3V58OOyi8qb8ViaT/8xODpUy0gre2LkBAxXXF0HMogVvK9h VwCCvNqBv/LfQwbPj7Px2LLKtP1JSDre6uYnubmJEy5Q/sdSpEm7EG7FlUVuniwWK8e5T5 BQf7ZaJx+wAEryJ8pb0dHz6Lbbs+kIA= Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wb1Q24SDxz6K975; Fri, 2 Aug 2024 17:54:18 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id E41C6140A08; Fri, 2 Aug 2024 17:56:55 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 2 Aug 2024 10:56:54 +0100 Date: Fri, 2 Aug 2024 10:56:54 +0100 From: Jonathan Cameron To: Mike Rapoport CC: , Alexander Gordeev , Andreas Larsson , "Andrew Morton" , Arnd Bergmann , "Borislav Petkov" , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , David Hildenbrand , "David S. Miller" , Davidlohr Bueso , "Greg Kroah-Hartman" , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , "John Paul Adrian Glaubitz" , Jonathan Corbet , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Samuel Holland , Thomas Bogendoerfer , Thomas Gleixner , "Vasily Gorbik" , Will Deacon , Zi Yan , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 10/26] x86/numa: simplify numa_distance allocation Message-ID: <20240802105654.00004752@Huawei.com> In-Reply-To: <20240801060826.559858-11-rppt@kernel.org> References: <20240801060826.559858-1-rppt@kernel.org> <20240801060826.559858-11-rppt@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100004.china.huawei.com (7.191.162.219) To lhrpeml500005.china.huawei.com (7.191.163.240) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9376A14000B X-Stat-Signature: yxiqfexjqe6r4e8m4ir7ro77wmffxzqb X-Rspam-User: X-HE-Tag: 1722592619-89598 X-HE-Meta: U2FsdGVkX1/5TYNyszylGE+jv0LwYrkAGy/DQWhsbd2H2znJFhDWJ98O3Wwu3piQ9/+IAzY/DR5CNLklwUp7422mvQR5XFKu2RCmz4sY7EKCSQbO3ErkRTOyS8bNjYAhPcSma6NDpyAXXo4rwfHycKyP7aQ/N9fgtJl3dhnKSwry+YH3HfXv/3BvBtOXWWQPaDWzLB6VZxEBQwE8egjIZoS6zcYRATfYRmTO69zA7Bz6WGtE8qo2YWqM8Boi75NzABysEwBXUaUWjj+L5yN5G0QF6T9NARvwnki+Jm7FYBh6b6k9x2z4eh4RvRdHOYlar79HeU1/knq4oQwjVT+DpPkwalx0bEswXkuiw7CGqC88VulRLuBuvH2WrDJ2NRrax6kKa+mJD9CbUlPYtVPjzP/tvZDr4IFmXRhGuDF9XoqanwH1F670ap6bULs6bAIFrCif/8L+SS5/zeY2DwMY2EIk+F0ZM5pX9NGizfA6iOdGLWo5pRfaP7Jcay7XZddaHLaTTOewz8t28dux3n0n6BAmh1WfHhyZ2VaO0WPjjTJheLVvoPJly13N251e6L6VaGFroV9bZhSk2fx75wdbWs4FNzZzwS/H5fO9p4wsslWuQLfdo/INZKNTFjUlMi/L/s142nuYcjdv59OurDAgHjBNUWu8uDFY4g2hHH7A0lHwShWx4C1o2NVVmFsRSduiTcc4ZrOKCP/TfIiURIm7G3c5V2ZPj5TKcwq7aJA44rADI1ftG+4zQTVtoQYBewO12zwIlSoToagZOh3RY/LxqwRKhAKr9KN49nPrUorSukIAiMVmFnwE5tqxRvkdUNm9Q/bSqj9YG5NAHd7m8LXlDnZ9oUKmzWYw8n3yh8/L3/z371L4P7DbovSkc1pkIiMtGZZT07+xidKygti/hCC63ELH13ZMWjaqK7oGev1hTkXVa+AQkbg7PSDnsh7gyA2MSb2fGd6DsDmd3nx9z0A VVHw0/Ty IwWUHnp4nZKtwabum0U7j6dzHRnSVCrTDxCRqP4AL7fH5PKGQfQkvJSQBTMJKmI8U+HE5lV3CqdFDkVfb1CG+WTMSDZY/GCi4UFW+ZJ7DYXSS7kh307Fiw+8hb670051n+DbBYw2FrtQchJDrdrRCmL88Ur3vmXK4vPnbS3gz6L41oG1ULpZccyIlcEa7j1dTITOkXyM7JMGw5Dd1lrE5JXFSOGHlvZZL45WJi+AW3UcYgj9Nz3FBE/8kqCsgLR2gMC8Jkwzkjt8Wr4emdBS/wfpgOKO8DQg+HR7Dpz/uyHKXeXMlio3dOYeusFYEkFFi+1MxjNCHD4FOCH42UZQzDQ/0FQOuAy93FamP7IliwyecR4JSHT45iZEQvO8d+IYz4oVl84zyMzDqGl+T1EtNwwaucg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 1 Aug 2024 09:08:10 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Allocation of numa_distance uses memblock_phys_alloc_range() to limit > allocation to be below the last mapped page. > > But NUMA initializaition runs after the direct map is populated and > there is also code in setup_arch() that adjusts memblock limit to > reflect how much memory is already mapped in the direct map. > > Simplify the allocation of numa_distance and use plain memblock_alloc(). > > Signed-off-by: Mike Rapoport (Microsoft) > Tested-by: Zi Yan # for x86_64 and arm64 Seems sensible. FWIW (which might just be me not bothering to read this one again ;) Reviewed-by: Jonathan Cameron