From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CACCC3DA4A for ; Fri, 2 Aug 2024 09:55:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4F296B007B; Fri, 2 Aug 2024 05:55:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFF606B0083; Fri, 2 Aug 2024 05:55:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEDB36B0085; Fri, 2 Aug 2024 05:55:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 90D3F6B007B for ; Fri, 2 Aug 2024 05:55:34 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 457E11A0D85 for ; Fri, 2 Aug 2024 09:55:34 +0000 (UTC) X-FDA: 82406848188.20.6D4633D Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf09.hostedemail.com (Postfix) with ESMTP id 37BFF14000A for ; Fri, 2 Aug 2024 09:55:31 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf09.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722592475; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6TyaTPJRqSaJIsJl/PPwJ6+a1eeu2JYS7IXreicj99E=; b=NJh7s+C1k6vOdrMJPVqeWAztL9H5FRDxYaYEOhUuUf83Rn9hWiivX/boQl+XJ3jIST7l7m 5CCHmjwrrNP8t71vZBy12V6/DCcu38UZs/yfpp298erUiR3HHzSqU9BOJfT+Ng3GEbhKnx xFdDQejv2XplS2KfRP7gim+dReUA+hE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722592475; a=rsa-sha256; cv=none; b=K+m5+BeAZYShI4s/GtBKjJZFyQZT3kHSgcm0NR7k/kXBfIG+vWGHN2i1J1MYLqClA+WiDE pUmJoCPvewiMo2FNSHcdhHd+N9TvsrhD/O4DU8jtMIyFwKvcAmAdnQtUeLJrLoRBzn6KPM exBOr6X+i8T7630OtMVnIBkHT+KMBi4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf09.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wb1NN08c9z6K99q; Fri, 2 Aug 2024 17:52:52 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 51A73140A86; Fri, 2 Aug 2024 17:55:29 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 2 Aug 2024 10:55:28 +0100 Date: Fri, 2 Aug 2024 10:55:27 +0100 From: Jonathan Cameron To: Mike Rapoport CC: , Alexander Gordeev , Andreas Larsson , "Andrew Morton" , Arnd Bergmann , "Borislav Petkov" , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , David Hildenbrand , "David S. Miller" , Davidlohr Bueso , "Greg Kroah-Hartman" , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , "John Paul Adrian Glaubitz" , Jonathan Corbet , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Samuel Holland , Thomas Bogendoerfer , Thomas Gleixner , "Vasily Gorbik" , Will Deacon , Zi Yan , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 09/26] arch, mm: pull out allocation of NODE_DATA to generic code Message-ID: <20240802105527.00005240@Huawei.com> In-Reply-To: <20240801060826.559858-10-rppt@kernel.org> References: <20240801060826.559858-1-rppt@kernel.org> <20240801060826.559858-10-rppt@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100004.china.huawei.com (7.191.162.219) To lhrpeml500005.china.huawei.com (7.191.163.240) X-Rspamd-Queue-Id: 37BFF14000A X-Stat-Signature: 6313b443z7ozjmcrgeo8a41h79p37smw X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722592531-966133 X-HE-Meta: U2FsdGVkX19+K+ZxxszjUUk1eI0oAtehpmDWCiIVPfzikG3DdieV/Xamyk11aHURTZQuRqxjMil/emiY04/O7hklUmB/Bi7NGZWCDbrUu/pKqqKZmvqlYZ5ggU3oCuvUVblgoYLsbe8rNTMFjcM863IRfyM5KXRzLebIlGgUhoqrcmfWPerS56nMjxdJpTM/Q1hqqJpRBEm/BdrGwjlIW4VQAtBm6IBYSlSyLALpZm8uR4/kbz8KD/SAeDpNqScbDU4ttB07v6e359+us42Bktz+vlHKux91egm/gBkvSWSX9vl7iFN5TuNQDVMkyFY9kazCpEGjt3phTH37lprrBqw8EsCy4RDMubyz8c+bj6GtQWE5OA2kgnywwup8z0+Z85Jam6UKC0JlM3cyLhLK6hbI3WGLeELtSWXs8jA369m730F//Qyuz2xo7+gTkaUiC2zqR0BX6XNhxRWNdl4LrnafSKIqchJxDrfpbuKUlF3rf7ejP4KGVWjmWuGdRCFLBKD4EDif/lsr7By0O39+6+P24jCdLCnH+lsirQZLwxexX1DAefWXnX1uDX6NHDHLdmt6mkO5+2C8Ov83x02EJi7qKd6Y2O6TEQmmz15GGyuXkvn7OeOaLR+yWKq9dlSLxMgLYVJFwMlHlDVWyPE1QlmhRmfRQN4+xaRo6PvGPGpRgaFi5dlR2EfLEJ1dl2cgOkCFweDCYD7JPinbMNpMPP7l9VyBqff3zQONryrthJXT18AhBYzv0yfI3GtzJI5lrOxbs7vLLqU8gdhI5nuRsR+qEwruIe/70WfUfKTuTnVnxRKSSBAeXawz22v8dov9iEsijmu1wx/ZnxRH/0yS6IYVPPZ4pXZj/UNfYfEw2ltxHdK3X4nwt0y/bkhcZaGx8hce2gvwjx8V6cFzW9YyO3kuF81EdZxOwZRwKvjBD2gxYFuTuJXd/0eETRWntGRQaO9wCUkh4u4vKbNj20G weC8M+x9 gT/cLtsXmyan9qQQULHQjwJfgU+8h5JnYw5iTSUvjNHSqsKWfFCOzSvjegMWZp56TOlwC8vdMvcjyB7HwAHAzOjOf1jRKSPh6rAJZJkmVyJNEfnMONg9VVxz744Dwf/Y44F9WE+uWqOhHTqHh+wr3OfkbUZrT9EnlHljvaR8PSVpp+U+0QNCnX+sVQfXOPDV+i6N+VeEALzoS8boEMv01NdzmXaZkmerFzZrBom/pz8uUGxY1C+RjqaNN0XVvjfNwnOr1AFjRISmTWayr0d2iyLnW0smgnkU+88rSvasmDojlGx0Y6f/1nrl3eyyUoZ91kCrkm22pDBnacFIFFNiZSsMw8DOPGIkWbKYEiOtKWLIcntNLY4gQmaDEoO7RcvQDW0t0DRcg1nTqPlf419p5zMe2i4bEHkDC/xFQ8OHp/Mb4b+o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 1 Aug 2024 09:08:09 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Architectures that support NUMA duplicate the code that allocates > NODE_DATA on the node-local memory with slight variations in reporting > of the addresses where the memory was allocated. > > Use x86 version as the basis for the generic alloc_node_data() function > and call this function in architecture specific numa initialization. > > Round up node data size to SMP_CACHE_BYTES rather than to PAGE_SIZE like > x86 used to do since the bootmem era when allocation granularity was > PAGE_SIZE anyway. > > Signed-off-by: Mike Rapoport (Microsoft) > Acked-by: David Hildenbrand > Reviewed-by: Jonathan Cameron > Tested-by: Zi Yan # for x86_64 and arm64 One comment unrelated to this patch set as such, just made more obvious by it. > diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c > index 0744a9a2944b..3c1da08304d0 100644 > --- a/arch/powerpc/mm/numa.c > +++ b/arch/powerpc/mm/numa.c > @@ -1093,27 +1093,9 @@ void __init dump_numa_cpu_topology(void) > static void __init setup_node_data(int nid, u64 start_pfn, u64 end_pfn) > { > u64 spanned_pages = end_pfn - start_pfn; Trivial, but might as well squash this local variable into the single place it's used. > - const size_t nd_size = roundup(sizeof(pg_data_t), SMP_CACHE_BYTES); > - u64 nd_pa; > - void *nd; > - int tnid; > - > - nd_pa = memblock_phys_alloc_try_nid(nd_size, SMP_CACHE_BYTES, nid); > - if (!nd_pa) > - panic("Cannot allocate %zu bytes for node %d data\n", > - nd_size, nid); > - > - nd = __va(nd_pa); > - > - /* report and initialize */ > - pr_info(" NODE_DATA [mem %#010Lx-%#010Lx]\n", > - nd_pa, nd_pa + nd_size - 1); > - tnid = early_pfn_to_nid(nd_pa >> PAGE_SHIFT); > - if (tnid != nid) > - pr_info(" NODE_DATA(%d) on node %d\n", nid, tnid); > - > - node_data[nid] = nd; > - memset(NODE_DATA(nid), 0, sizeof(pg_data_t)); > + > + alloc_node_data(nid); > + > NODE_DATA(nid)->node_id = nid; > NODE_DATA(nid)->node_start_pfn = start_pfn; > NODE_DATA(nid)->node_spanned_pages = spanned_pages;