From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6899DC3DA7F for ; Fri, 2 Aug 2024 09:26:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC8B76B007B; Fri, 2 Aug 2024 05:26:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D76F46B0083; Fri, 2 Aug 2024 05:26:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3F1C6B0085; Fri, 2 Aug 2024 05:26:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A5E5B6B007B for ; Fri, 2 Aug 2024 05:26:05 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3C17DA7511 for ; Fri, 2 Aug 2024 09:26:05 +0000 (UTC) X-FDA: 82406773890.20.A92F356 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf12.hostedemail.com (Postfix) with ESMTP id 0109140018 for ; Fri, 2 Aug 2024 09:26:02 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="0/1BlEEw"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DL8LoeQx; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="n/i3IL2v"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=J+pkYrpk; spf=pass (imf12.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722590757; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L9FasuiBoGtbyU4rhE2DKTVTHzWzbXZGxrQhwHOAKnw=; b=YsMgXpukgkkX/hWK3pvpz+9OVB7z2Jpr37sTg8rUmy88lY3YwtH9GLoa8fvzAX2JkumJdk bsa06kgadVzNAXDcvVpFJGVdF53HrLmPE/VRzwU6Rtis5LVssjEiVSFeZsJmIqbWtuTSxV 1rSaicdLG3PWAnjckO9kQT7+vKEfyTY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="0/1BlEEw"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DL8LoeQx; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="n/i3IL2v"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=J+pkYrpk; spf=pass (imf12.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722590757; a=rsa-sha256; cv=none; b=j6BRSjeRDjMUOdqVNNxm6QMcu7bewKefNHPnsq/Cl9H3C4cRhTXenEP+RH6kitSMr0MjIG OMwuFOqRGzjODgA+EwhkbQsprZgZ/i3Q9tnivCcoRZ8SfpcoXSq12MYbbkzY5VK/3S+bIL KJmgM/MW1xkEFARU1Jhdylt9smBIM9I= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C98CA1F38C; Fri, 2 Aug 2024 09:25:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722590761; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L9FasuiBoGtbyU4rhE2DKTVTHzWzbXZGxrQhwHOAKnw=; b=0/1BlEEwBnWJD2XkwiJn7+Zy49epwPP7QUyhJ3t56HRyyf/MkqFcogqyoIuj7SBAeuXZzn 5szw8NaqulTD2Kp8hYTZ2v3SxM0rGKUMfRS6HaKd4oVZbFwYjkCFeoX1XFCPosd6FlCegf NrdsNbvYEeb54/qZh3o2JpifXA2uuRg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722590761; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L9FasuiBoGtbyU4rhE2DKTVTHzWzbXZGxrQhwHOAKnw=; b=DL8LoeQxUubuMVQmC7AjwQ6OKPu1Rhxyw0+ngSyH6WPJfuoFoxF68BLNJ6hX7YN8gJE+w5 fO6sJRHUElmZKNAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722590759; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L9FasuiBoGtbyU4rhE2DKTVTHzWzbXZGxrQhwHOAKnw=; b=n/i3IL2vWO9iu1j+FsZI0Urh6iCGYg2QX5PBq8FGCfK6NVlDfaWJpd5hChiAbAzSvCM51n lb8kHx3w5o8wBjz0WuYjXv1QwAFnsos1R1jzYxKY8CIHwvXs57qpH/+dMic2RehVbYUJHe BgwtI6ZzO1ul+a0Hoz+sg6QJp4JacKY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722590759; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L9FasuiBoGtbyU4rhE2DKTVTHzWzbXZGxrQhwHOAKnw=; b=J+pkYrpkBT4ctpF4iGRejxG5YWGC/4EynK9oihvBNaO7MaUud0eyQ5ikclRnPLfNVT3vMQ 3G0jb4bn2/jd9SBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BDD361388E; Fri, 2 Aug 2024 09:25:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id q49SLiemrGZVKAAAD6G6ig (envelope-from ); Fri, 02 Aug 2024 09:25:59 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 7C7C7A08CB; Fri, 2 Aug 2024 11:25:58 +0200 (CEST) Date: Fri, 2 Aug 2024 11:25:58 +0200 From: Jan Kara To: Wang Long Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, tj@kernel.org, cl@linux.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] percpu-rwsem: remove the unused parameter 'read' Message-ID: <20240802092558.3dcvf72dguodjxkg@quack3> References: <20240802091901.2546797-1-w@laoqinren.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240802091901.2546797-1-w@laoqinren.net> X-Rspam-User: X-Stat-Signature: qf5jkgm8ex1fpqznj8uaodz6wmqehyo3 X-Rspamd-Queue-Id: 0109140018 X-Rspamd-Server: rspam11 X-HE-Tag: 1722590762-252770 X-HE-Meta: U2FsdGVkX1/dgXc6sijk8N6ZZaGcvuiMM6OegSm9ZmuytIxRtiqAJZMpISrieifhgb4LrU8hUbJboyeTMjpa4Rzce1MTulGNwCPIBpTqlcjg666LVqOrPQBXx0fe8NVCe0qSwOsKM8TaUveM0cvA0Hm0ieAIzfFsF+v1gyAYk9AB9S6dzXwP0U2O851g2/T3wJri9pjN9Vn3Z0c8LfUagtUJqD1m/ZUkwDiuE5UD3gKc8OH4Z94iYetDesHE0kHkcg3kAnvWBZ3vLjXSeWf3zvQve+avPKadkFUHc/78vX84QTISxvv9Zx/5OZ9rwLv2m4Tl/MZqWsOauUU+c27lWhzKfPqxFanoa8vgedkjUfumx72bNlDMeeAMk+xMB0PSKp4WmMrDA9BDY7HHpLKbkIbLg1/hdHyX8/uR7o6DPDgAReBho25bGVeAve5Slv1ljcg/+hH40bY3BExzMxKMpSLFpK3uaUxGNhldSeZN4DQpc+U68na4VZcN3XlLh8n48XwEpK3iKVWNticaYHLyEOMvj0PL/Q9NuNnw6A+/OkDX1W87UDaepFMPLYMm9NDWsHCSLk0vaOIOFZ8svm6P3InW0HOgD9huX0RL8lTMUfjdxSyCaropHSjvPSfLxUeB1JHBend7rzma37hpAnFmx08+Xjqwe9i1xmx92fHiy1nZHvitRitYsgK6R+sRkZH+3o2WJWR78adYoiOaST0tVOK65icVAh2Fbxq963iX3024NgTPWlxn9/v19qgKfSwx/8q0b1j0LTPAJvLO6lig0AIZCZNsx0Pxm32xHYJa5/v6ixzhx06awhK9hzStQnQFhX1THO9H1wAaahGdw8BOp7jJuv6y1h9/MZZrea8fEp/Act7ru1a9C6xjJwvZV6sFXjmudrN9Q/3pIwEdzsC1bZnIXiH/9xw2TdrhhFsK3Mdofy84VwTqnXtmJAdyzHfzQz3pQtL2MHPp12qJtyr i3Kk84Qs hxcZFeYeehLsXw+pmgkR8lQSgHXLS8gsONi9je/lHF7ZExM/7vfbH7sBbkVgmgmdpY0W1mMncsSBMmtAv6Nbzzjyf2D5E0GxU84cur55mNXK0F7eGE1PwEGUgpWi6rXwkCK7niz819mfv7CDk1o95/kLhbDRIuvgGAG/fl75B6K9z6hYBauD+lUox+LC6JRf18aWFAdWQIJ8mMUZyaBKztwxN1qZQU23wL0h5bwGSZVDoRxlbhW/N8G3UZieJnaI0QexFTyaSjETD7L9zbazS8ar4bhfAyXBWh4Jhwx7HENOE/dmf7rxmXHIKs794cG5sB9FP9h+AcESeiJxXFcoQcfkKB637vfzh2pUy+9ateaBxtoy4wdMB9puCQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 02-08-24 17:19:01, Wang Long wrote: > In the function percpu_rwsem_release, the parameter `read` > is unused, so remove it. > > Signed-off-by: Wang Long Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/super.c | 2 +- > include/linux/fs.h | 2 +- > include/linux/percpu-rwsem.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/super.c b/fs/super.c > index 38d72a3cf6fc..216c0d2b7927 100644 > --- a/fs/super.c > +++ b/fs/super.c > @@ -1905,7 +1905,7 @@ static void lockdep_sb_freeze_release(struct super_block *sb) > int level; > > for (level = SB_FREEZE_LEVELS - 1; level >= 0; level--) > - percpu_rwsem_release(sb->s_writers.rw_sem + level, 0, _THIS_IP_); > + percpu_rwsem_release(sb->s_writers.rw_sem + level, _THIS_IP_); > } > > /* > diff --git a/include/linux/fs.h b/include/linux/fs.h > index fd34b5755c0b..d63809e7ea54 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1683,7 +1683,7 @@ static inline bool __sb_start_write_trylock(struct super_block *sb, int level) > #define __sb_writers_acquired(sb, lev) \ > percpu_rwsem_acquire(&(sb)->s_writers.rw_sem[(lev)-1], 1, _THIS_IP_) > #define __sb_writers_release(sb, lev) \ > - percpu_rwsem_release(&(sb)->s_writers.rw_sem[(lev)-1], 1, _THIS_IP_) > + percpu_rwsem_release(&(sb)->s_writers.rw_sem[(lev)-1], _THIS_IP_) > > /** > * __sb_write_started - check if sb freeze level is held > diff --git a/include/linux/percpu-rwsem.h b/include/linux/percpu-rwsem.h > index 36b942b67b7d..c012df33a9f0 100644 > --- a/include/linux/percpu-rwsem.h > +++ b/include/linux/percpu-rwsem.h > @@ -145,7 +145,7 @@ extern void percpu_free_rwsem(struct percpu_rw_semaphore *); > #define percpu_rwsem_assert_held(sem) lockdep_assert_held(sem) > > static inline void percpu_rwsem_release(struct percpu_rw_semaphore *sem, > - bool read, unsigned long ip) > + unsigned long ip) > { > lock_release(&sem->dep_map, ip); > } > -- > 2.33.0 > -- Jan Kara SUSE Labs, CR