From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47474C3DA64 for ; Fri, 2 Aug 2024 01:31:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A13926B0085; Thu, 1 Aug 2024 21:31:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C51A6B0088; Thu, 1 Aug 2024 21:31:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88B226B0089; Thu, 1 Aug 2024 21:31:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6450F6B0085 for ; Thu, 1 Aug 2024 21:31:21 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 16BE01A0625 for ; Fri, 2 Aug 2024 01:31:21 +0000 (UTC) X-FDA: 82405577562.26.A74C83E Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) by imf22.hostedemail.com (Postfix) with ESMTP id 4EBDAC0012 for ; Fri, 2 Aug 2024 01:31:19 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=ouLwXSGR; spf=pass (imf22.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.43 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722562222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oS4HT00YZzdrQrCyP+cjqCnQbi7cCNJD8Qkn7dxIU7w=; b=LJQ25e2Bjhu7RTMo5iKIGPjk2NMU1rixbKqtZ38Zc8ro0tDIBQul9Hx1+tt4tAeKiRbKmh Y91APRSeKV1FOkvF1rLEmCoGl0S9jQyAjJ020RJN3gZ17Bab34lEIMFl+kmFst2mV6oMZe CAB8ekUH0YS5ci01OqbzCCuozBWvjqQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722562222; a=rsa-sha256; cv=none; b=d53JBQ2mZJL8eMkB/zFgi5AvNPSc29m8RQ+vrfDBlvULzLCjUg75guygMfskItZvIKLcZ2 bpSGiz0uVWB/B8qPlsd7Wfvm388fHNe1ICkd9UsEVr5SD3cT2nvtNsp+OgXZw6r3jxtBX7 Wgmc4a0Zr0P0N6JnDu4M5PLLZn1KeTo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=ouLwXSGR; spf=pass (imf22.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.43 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-6b795574f9dso41483646d6.0 for ; Thu, 01 Aug 2024 18:31:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1722562278; x=1723167078; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oS4HT00YZzdrQrCyP+cjqCnQbi7cCNJD8Qkn7dxIU7w=; b=ouLwXSGRkLC/61SOuecjq8Hr7cmZcXsHQKGNVNDneXIFJjqkFQdhrGGBJfecvEHHW4 4nER2Oawd0axEqdKuAeKqWejmCyhMd+3ngDLkk++OUaKaL0NV9eSckPlBh/zn/8a7Ett tt3rd+Y+4OhAH6lhyRK2wUsqjbi9Ox6/j/1N8CR3IDoQbWKUNEgE6qkfLGZzTiGQRug1 fc9ma+Btf9bfLnz5nIsL9RCGiHcqHBZjuWWHnuHqhNb3N30iVBw6GItYyjqlB5JkmckT IDhHUEh5xf3fjMmrBRSa3O7p1QHEgLNPZgpQ7Yu/f2AkiPDmhuRf6PQqE6+Yy3Pc7oI8 ygpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722562278; x=1723167078; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oS4HT00YZzdrQrCyP+cjqCnQbi7cCNJD8Qkn7dxIU7w=; b=IxesECzmw6/C5ODHWcw/ofa3gteZxTN4zAdF95nZxdtSpTAvbM19nW4SlrwRhupVJw vgOZo8nCEL2UmNJ3WwzZ3C2WRj7RZ+YV28hMeAf8g854Gf+GXTZyG9OxuoipvQ67O357 HWlK6sKuTU7s7Rq4GfvEYox5MM4+tjUiD8YSOuCbAdl8KoleHdy9AUiD3W2USYLXWxbA T08+9QykEaC52kanFGGt2X0jELE715fm1nq2eRMHExT1Jnq+JxyvKsCXdonvPX3yyfTd 7Y7R52d8cVIbelqN3oW8wpE/XLj5F7Emza3ibexmA8LDkK7cQJfYSK6xmR6MC9JWQNOc qAIw== X-Forwarded-Encrypted: i=1; AJvYcCVLQHtGu7mhhyg35QoSvz0YlRbANj/Dprr6CVRQ+r1wjTyGWmktWLUA1PoBNgTOhbk+rd9m7lL5PTuBYDxTIxaZsGY= X-Gm-Message-State: AOJu0YzAIdFLhZzjh/IL45aOX+15Md7KZMqnx2V4gC2qZ6gJMuj8lUwY Key3pci4g3ouRpBY6fRSjN1yRfV4HQ5AmxAftybkW0/xzcoTCRA8FX2lwPkugOo= X-Google-Smtp-Source: AGHT+IGCwePuJX2jJAy/H+vPlTZz/ZV1Rj7r9ibS2VL3/krSSEgLKVQ01YmYZZELjkLJGo9V3B9MQw== X-Received: by 2002:a05:6214:3b86:b0:6b7:a2c2:6121 with SMTP id 6a1803df08f44-6bb98371dbemr23383596d6.30.1722562278346; Thu, 01 Aug 2024 18:31:18 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bb9c87d415sm2139406d6.133.2024.08.01.18.31.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Aug 2024 18:31:17 -0700 (PDT) Date: Thu, 1 Aug 2024 21:31:17 -0400 From: Johannes Weiner To: Andrew Morton Cc: kaiyang2@cs.cmu.edu, linux-mm@kvack.org Subject: Re: [PATCH v2 1/2] mm: create promo_wmark_pages and clean up open-coded sites Message-ID: <20240802013117.GI3365290@cmpxchg.org> References: <20240801232548.36604-1-kaiyang2@cs.cmu.edu> <20240801232548.36604-2-kaiyang2@cs.cmu.edu> <20240801170302.0d233169e708bca1e88a65c9@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240801170302.0d233169e708bca1e88a65c9@linux-foundation.org> X-Rspamd-Queue-Id: 4EBDAC0012 X-Stat-Signature: j6u3n3r5j5qg9ceb8ww8s46d5oomhhj3 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722562279-268332 X-HE-Meta: U2FsdGVkX19yemvoGGpz8Oc/BKots+Kp9LN0ZT/W8CC/u3ZQXlUJCTTqsxj/MVWLdgLX5EsQQgrl9yNiZDLfPipGSbyuOvm/K+3jlqg9XmCZH3Joq4PXZf7E4NFzXRZcqS5I4HFuM433f/gF6c3MT4s6yek+SwzuMIPKtMFCnm5qSAE5Fk/IprWWfO1YouAiTbDE+Y0ZFTW/SohrcPwablThcuusWYU+2rGyf/bA7LwbxcRR6whSCYJmfFVkPHcihWsS58rss1erP+3siTiE9DepXDuK/j1s0QXjVw9uMK7qU4gsXJfB15hSQPjoPWXK7FgWo0R9BnZYQsc3TDpk3J9yd8KS1Kbfv14soaajQUeGKxiv8ari2zAxzrqdOMG2/Rn6XH21INvCXrxaI1ECjlYTF89BOmw/GbYrfzBpzpJQk4xUlwcOZTInzjqCChhpyCU+mmmCkstAXQIOJ/FI8wIcmmguDczRvpLIErdUlqjyZdxA3Vw6Du96YYpS6ol7l7a3qnr7vhalxgWy+slp6HqzjTrauTI0+Md3VspN61xL/APQ3Z7KsPdGwnKzuXQCGwztA5qGVyGzSSfKaDLAFmo/XsVwzsxL1U8WQ3dmKtJ2pPvHpThW/huHiCytUje9x1OHPhsVfUMUObseFOPXwFSgG9xBNFWlYPzab58WyK3nNurGu7OiSvrWYd5fBdPU7QbzZl+XmJFQcRuAnjRmEgEoWpVLvDht/Gh9bniH5AXw2Ye94GyiInOX6ao6rRwxT4IT3UsmkzARd71DBJl6E12F/MhSlJwS45WZltEJjoZoPGC1xVyeMsq2szK4fHoL2ACNXRh/5CzsWaJlKg/MwTdN1FYDk/wol0FvOo5WPRGscNpasaka9GTjlfKw46e1h+PB0g/ud+gk4mdCSI95hgrr+AUQGcCEq2aLGjYhfV4mXtNTx9vGweBkHzDjaOpsExBsq2Oi1raEuMJnDMP GQis6gpM Jzwy0j0o4tNJxCI8MMYiCdlkSfk25BgckUhvO4g38cccwxQP5qAGeg8O7b+WMLlQsDbj72WBGS11Pi2bOn0K5fcvvjzW1qEX9wOfo8Cww++Od5bPX4E1WppqVTmIcFrl1PKYMU6WfA3B10EXPk7+BeH42Dk7ZhXz+VmWopvVXB7T1YKlsBX73OekpmDVvqkFdtTHomcINAq4FnS+BATvCuXGMuLGHwXtOuji52z5ZqG4LdcrthGI0x8NF2q66d5e2mnPCo9pmiLFFv6UU6WKo1G7e0RvqlcY5tvPzSkLA+asdyNuMNO++9OyJUT7s8iFw/lMr+LwNyNLJUY7FymSBHOQg0V7fFweraK7pqRcdvOT8vQnSbQvaZMo46xzyPL8j16Yx8hsFfkvj/R0FJ28pVwaGRUOE5K+/W4ROPV00briOKvsWInuDgd7fmwJ3CpfXJthww8DBUA85Yd10ScaCYs71HQRqsDNkQm4FCMYIbvqFwMnP5uKYv/x/SiXv9Wsq5yE7US9hKgsLVsVCllYY/6dNy9KYcBdJzcC9l9vUaes9yEk0FzcR7KzaIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.008188, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 01, 2024 at 05:03:02PM -0700, Andrew Morton wrote: > On Thu, 1 Aug 2024 23:25:47 +0000 kaiyang2@cs.cmu.edu wrote: > > > Define promo_wmark_pages and convert current call sites of wmark_pages > > with fixed WMARK_PROMO to using it instead. > > Fair enough. I did a thing. > > From: Andrew Morton > Subject: include/linux/mmzone.h: clean up watermark accessors > Date: Thu Aug 1 04:50:05 PM PDT 2024 > > - we have a helper wmark_pages(). Teach min_wmark_pages(), > low_wmark_pages(), high_wmark_pages() and promo_wmark_pages() to use > it instead of open-coding its implementation. > > - there's no reason to implement all these things as macros. Redo them > in C. > > Cc: Johannes Weiner > Cc: Kaiyang Zhao > Signed-off-by: Andrew Morton Acked-by: Johannes Weiner