From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kaiyang2@cs.cmu.edu, linux-mm@kvack.org
Subject: Re: [PATCH v2 1/2] mm: create promo_wmark_pages and clean up open-coded sites
Date: Thu, 1 Aug 2024 21:31:17 -0400 [thread overview]
Message-ID: <20240802013117.GI3365290@cmpxchg.org> (raw)
In-Reply-To: <20240801170302.0d233169e708bca1e88a65c9@linux-foundation.org>
On Thu, Aug 01, 2024 at 05:03:02PM -0700, Andrew Morton wrote:
> On Thu, 1 Aug 2024 23:25:47 +0000 kaiyang2@cs.cmu.edu wrote:
>
> > Define promo_wmark_pages and convert current call sites of wmark_pages
> > with fixed WMARK_PROMO to using it instead.
>
> Fair enough. I did a thing.
>
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: include/linux/mmzone.h: clean up watermark accessors
> Date: Thu Aug 1 04:50:05 PM PDT 2024
>
> - we have a helper wmark_pages(). Teach min_wmark_pages(),
> low_wmark_pages(), high_wmark_pages() and promo_wmark_pages() to use
> it instead of open-coding its implementation.
>
> - there's no reason to implement all these things as macros. Redo them
> in C.
>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Kaiyang Zhao <kaiyang2@cs.cmu.edu>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2024-08-02 1:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 23:25 [PATCH v2 0/2] mm: print the promo watermark in zoneinfo kaiyang2
2024-08-01 23:25 ` [PATCH v2 1/2] mm: create promo_wmark_pages and clean up open-coded sites kaiyang2
2024-08-02 0:03 ` Andrew Morton
2024-08-02 1:31 ` Johannes Weiner [this message]
2024-08-01 23:25 ` [PATCH v2 2/2] mm: print the promo watermark in zoneinfo kaiyang2
2024-08-01 23:48 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240802013117.GI3365290@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=kaiyang2@cs.cmu.edu \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox