From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0673BC3DA4A for ; Fri, 2 Aug 2024 00:53:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 143FD6B007B; Thu, 1 Aug 2024 20:53:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F4EC6B0083; Thu, 1 Aug 2024 20:53:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFD666B0085; Thu, 1 Aug 2024 20:53:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D2A766B007B for ; Thu, 1 Aug 2024 20:53:58 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 771EA1603ED for ; Fri, 2 Aug 2024 00:53:58 +0000 (UTC) X-FDA: 82405483356.06.A0857A8 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf17.hostedemail.com (Postfix) with ESMTP id 826D240014 for ; Fri, 2 Aug 2024 00:53:56 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=naqEIFCI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722559989; a=rsa-sha256; cv=none; b=d4pqKRk2OCE0VeEvhwdyZVUtHy7FavpQNo7r/Ct+0iEmoydD0oItnAIJniNaf+pXLu8RtC F03HOLI5q44f3NjAdz9lJBTB8NXzeHS418N5wE4184x7vFvfKQVlA4cz+dOBTqV55IqcOh R9N8pTFTDZ3AKJDZe15esSSp1CQgfZQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=naqEIFCI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722559989; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4tYvGp3U084S5c0hwzIWZhuijp7wwubaQOMFSuTVGIg=; b=oa9RVAOgTuKIrdTffffEE3tc9WWumihV92WyA6iIaQP5c1KGZ/9sXbIth5Chb51OUGQaqk jZrFIoVPIcP69f79bQltltNhyOx0Vb+vNM+LIO/zSk94VbrsWXwCVbj6G+/Ye0PlwzPfKn N88I3LqWsOWFL/YPZbKwfzdXow4Oc68= Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a7aac70e30dso75356266b.1 for ; Thu, 01 Aug 2024 17:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722560035; x=1723164835; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=4tYvGp3U084S5c0hwzIWZhuijp7wwubaQOMFSuTVGIg=; b=naqEIFCIa1rwReK9eMJcc5ckHKFzVXd/8DDskJVs7lFWqBuAF6afcYzQ1fS2JyFffv HT4L7ONFytPUmN5sJa5nZO3Y83tq58ANfBifcqvcCm/oj7UzI72iAu4qwuzxISDuAGZe O7YWQii6ut3JHkk7kvIjJucY0ZNhjpTW6xflIu5CYb8c4R0RQW493rxaUpfPIoVdWsmJ IyFLWA2yLHVeDd6km1bf7+x9pC2rIRWjAE10h7TKpZ5bp/c7EQZSgt8pDveNIM7UPxGX pKco40zmOeBZBf0Z9dD1uMCRn4dcDerdRxiA7h7/nVmeduKwi7vI3Tk5/jrG3Tv0Girv Pc7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722560035; x=1723164835; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4tYvGp3U084S5c0hwzIWZhuijp7wwubaQOMFSuTVGIg=; b=dU1IpHClpgJt1qoDrHn8Qg9mArx1ylIiCjJRbzg/mdxBhm/vyuy1o59ASTwP+DbNam X7YpM527bnYmsAzg2FB+y/ADEVncr55jLWtxT5UkSlhWXeWLgGpl9FPohFWqNMFi1LiW bZTEbZmLg/Mrn7MDaJX/Y9QHPsDsqxBA7/eMnibN0x56HZ/6qFaFkPWUNJDKiYyKxps9 W6FwjuZeXdHFQo7iBJQdd2b42iYgKupIA0rA4Zh/FfVbNxH08T9aXpqVjmTjNq727J6V auMOSZLA8XeJschSEWg9135c5+DDh1daAlFkHKtebxXpVfUIf/T6Iw1h7rBoh+keNHMg I6xA== X-Forwarded-Encrypted: i=1; AJvYcCVcrRWcGZP90X91GzQ8blrLEXHibOc8pg7TGQnrFVHDe8E5QgeHLBMmgoVAZTwG4JyeU/UNcdh0Ya2ZeHAyKyM/dBU= X-Gm-Message-State: AOJu0YxLUcap0sDB18AbjUV1b4TmvfjQsqU0xZnC74CV4bMnSd/p4oSR 9PE3ombzaTwh8uEkt76AO1Eg74MgIQDKrhGeWM+ehPS1Povr2iIk X-Google-Smtp-Source: AGHT+IF4tf6695GDpsy8xbRd11nySQO0xjTnJX/MqzvH3aiV3HGyFCmSIjM55oiSMTRDLvGjPvwtuA== X-Received: by 2002:a17:907:7f8f:b0:a7a:adac:57cd with SMTP id a640c23a62f3a-a7dc50800b3mr126699166b.36.1722560034449; Thu, 01 Aug 2024 17:53:54 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9bc9d7dsm36716166b.9.2024.08.01.17.53.53 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Aug 2024 17:53:53 -0700 (PDT) Date: Fri, 2 Aug 2024 00:53:53 +0000 From: Wei Yang To: Mike Rapoport Cc: Wei Yang , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 1/5] memblock test: fix implicit declaration of function 'virt_to_phys' Message-ID: <20240802005353.z6udm2tw45i7phqy@master> Reply-To: Wei Yang References: <20240729014725.29839-1-richard.weiyang@gmail.com> <20240801000739.lrgmokbbgvikrlkw@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 826D240014 X-Stat-Signature: dcxq76yctxwin1ju54nphg47xydb36j7 X-Rspam-User: X-HE-Tag: 1722560036-946839 X-HE-Meta: U2FsdGVkX18TNPI4468EswBPMuofRk2BolGRV2TxIg94vKbn11TQ9rCM1qUbE4ogFYL6Dfrc9vKqgwWOi9btC6/itsNHH4FkLAoyAie/jOGfK2dt4luNjQkmEXbCMfnI0fXJN98NbHFpLLXLPlqejWogRVlQnoWV+CsQPVjjcxfhOnNXEB3QuU/8aRvChA8dDOScxJqTmG/ft7753rCNd5No32BRuzXN0g8q4gTY1xl9PaNgaWbwWQsAgo4WUAV+ja/x66XmurgT9tofySxkgSkTOLtZ3KI5/SBLmV0f1SVVii+OJGyOFOtBEvjYf9lLCgdJdGEoLE6fxDob7uRzlxBT9cQPWhFjpYmEkkZ6yZkvNsBzvBk65u872J+UB+qlNQS0U7gjcgruuJPokWG10SeXBr3nzN8WqAhz7bCQ7+zwwGDYgBdwXaVbfjkTC8hceqq4yh0/jEyPNRrA05vVNDBFV0d0jNcbnrBmbbJjvrz26JL8mc4K8/5kmDAkZFisoyeSb5HxF2XOR9xEO3uungahZJm6KdQP+bFHk/QOi7i4QUBkH/fQa9bWqI/L/HljYqSVN6rQQcWDIkKg3sk1tOa8aCF2Tf0NuKuvP2LHdY+NnZo11VbRVZRm+ikJqFuzLw0b0+NGgQ3tNjbeueM6DWapxfJZGzQ1nzx65V67ECKvhdvPrKpFOdLcAK26b+qxmiUkh2qhtJ+hzdgzzmad9zc79Y9nnHqW/diBCmgXUgAd2j1G/EOh5xblPnAdXSAih9CVM/Rr7wwZdEXRwLBMWaC1pePrYBlpo4g04OQppvuHHqgDeMfjsnuzT3CWjS22WV+36PA+g/aqqCxssswLnvh9PXsT3gIJ6Bu/gtgbj6VdnzKoVfkIhWRnipiV0aIvVUmyRCvzYBW8Hq9OLrl9apVItrBmFy3IIRzUeKU6SB0taGV+/IXZV1BPTfzlIFJdtX5T+nhs9TKFKwufEl2 79SicNkp K4dkeHVxksFqZdvGsSy+/Y/OAXWtt6uvJD7VuFFz0W/+oLShRxHbOY0gSbVFtXLQ9o5IdYKSN7SwnO93/25nWlOF/3Pmg17nJs5dbVeyslQpvbtOIZC5Spd+JXETZFuUO/x4Ar9gwyCQlgoGbLyOsbhr3jUOnogVdhFUk9NvAkiL1Au4LtvzGphoRmypapvTpAQE9F3pl3D47iPqdkgKcNQg00DALoPYxD0nw31E3mMF6dNCCZI5PGGPCKLBrkuYAoKIMlYkLvHrbxElDaaHvGcqS0cemkLDFRODZKWflA6v8wKZRhdpzQgWDbPqgY59qobnedj5lKn2fTs0pup6C6MsZc3jzlwSJphd7brBBXmGUCHg9O91cnBSCutX7kc1OcyjAaLsq2ep6S4sNuZUoqoIDpVr4G8IrcwkNPyNTtvWd9nlBFpeROl5GXqdbySRWpxOptEplT087k/nXxXjHS2VYXE6KFdbNZqVpHd+tRRm4bw32Pr8rU7UxvQFSEbVgLUCEX7/QCSct9nhlROzG4n3itKX6WGehFp0VlblKa+2tPl+WUW10TsT724GA0f0RJ5amkKVE4Meigyn32x3EIKXv2eA/8x3NorfLkNLhqHbS+6k+8TiB4T9jSpUZi107uaYYzAZ6qpsm4Csg3JKUAW/F477tdd1RFm7A X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 01, 2024 at 09:09:14AM +0300, Mike Rapoport wrote: >On Thu, Aug 01, 2024 at 12:07:39AM +0000, Wei Yang wrote: >> On Mon, Jul 29, 2024 at 08:37:23AM +0300, Mike Rapoport wrote: >> >On Mon, Jul 29, 2024 at 01:47:21AM +0000, Wei Yang wrote: >> >> Commit 94ff46de4a73 ("memblock: Move late alloc warning down to phys >> >> alloc") introduce the usage of virt_to_phys(), which is not defined in >> >> memblock tests. >> >> >> >> Define it in mm.h to fix the build error. >> >> >> >> Signed-off-by: Wei Yang >> >> >> >> --- >> >> v2: move definition to mm.h >> >> --- >> >> tools/include/linux/mm.h | 2 ++ >> >> 1 file changed, 2 insertions(+) >> >> >> >> diff --git a/tools/include/linux/mm.h b/tools/include/linux/mm.h >> >> index cad4f2927983..9db45c5d00fc 100644 >> >> --- a/tools/include/linux/mm.h >> >> +++ b/tools/include/linux/mm.h >> >> @@ -20,6 +20,8 @@ >> >> #define pfn_to_page(pfn) ((void *)((pfn) * PAGE_SIZE)) >> >> >> >> #define phys_to_virt phys_to_virt >> >> +#define virt_to_phys(p) ((unsigned long)p) >> >> + >> > >> >Please don't break #define of phys_to_virt from the static inline >> >implementation. >> > >> >> I don't touch the definition of phys_to_virt, so you are willing me to adjust >> it? >> >> The macro here will be expanded to code at preprocessing stage. I don't get >> how static inline would help here. Do I miss something? > >static inline allows type checking of the parameters and #define with the >same name as of the static inline allows catching other defines with the >same name. > >So it's common practice to use this combination, line phys_to_virt does. > Thanks, I finally get why we write code like this. >> >And please make virt_to_phys a static inline similarly to phys_to_virt. >> > >> >> static inline void *phys_to_virt(unsigned long address) >> >> { >> >> return __va(address); >> >> -- >> >> 2.34.1 >> >> >> > >> >-- >> >Sincerely yours, >> >Mike. >> >> -- >> Wei Yang >> Help you, Help me > >-- >Sincerely yours, >Mike. -- Wei Yang Help you, Help me