From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EEE5C3DA64 for ; Thu, 1 Aug 2024 19:04:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E714C6B007B; Thu, 1 Aug 2024 15:04:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E22F76B0082; Thu, 1 Aug 2024 15:04:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC2AC6B0083; Thu, 1 Aug 2024 15:04:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B6DBE6B007B for ; Thu, 1 Aug 2024 15:04:48 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 590921C43FC for ; Thu, 1 Aug 2024 19:04:48 +0000 (UTC) X-FDA: 82404603456.13.F8E6365 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) by imf20.hostedemail.com (Postfix) with ESMTP id 67FA21C0010 for ; Thu, 1 Aug 2024 19:04:46 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=aPxseMoy; spf=pass (imf20.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.54 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722539041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z7NY6WJlLWSbTfpX37bQ1gwtcF7PiR8RtE7LJx3zf6Y=; b=Dd2j6fsXYHf1MVHeKijZnSzdCkcI4SjqlpsArqRzrVQ+gqLiri6l6zliP8wBuqUeeJeT72 s8rYtJpem9spDWp4dhjRsd4RwUir/LvmkfegjTs2nSWYNrsU0k4JFcWsNTWasJRpz3Ccf8 xJ3+fIa5lmqzIY9cYCJmzXs91YCREBA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=aPxseMoy; spf=pass (imf20.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.54 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722539041; a=rsa-sha256; cv=none; b=nD07OIqm2Wp0Q7evuPAVraRsaMlFaEQX85EogOFgZXnPhscslNzzV6sr9o1zAgBil1sSnF DKHdqFnFb0kvkSDXPhJnurBI88SoDounsjL7lPU9LJL0uzoRtHMgzvwpXbF2todmfkJrr/ K3zaQHilr6GcHuKDPzR+4SDRF1+sJPU= Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-260f1664fdfso4061715fac.1 for ; Thu, 01 Aug 2024 12:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1722539085; x=1723143885; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Z7NY6WJlLWSbTfpX37bQ1gwtcF7PiR8RtE7LJx3zf6Y=; b=aPxseMoyCuI+biaTKNpOkzzyD3IVjLjaX/ggQIRiWoAtq1iywroy0koH1FFckICDP8 eVHX8BGHeuDT3098uwds5hYsx5a6+v5fvj9k69b5tfx4ju+MVm4oIMMP3ocJT6WokBs0 ofDGwQgoUnKwVFqkdOzDVxzI1FHrTHUQeKItd9RWLi3UeugSfAezxIsFTNLZLahei/FG MgeM36RCFrrURwjEXFwT/qkvnpiEoV+yeMm8PxgghXtYKVq94XqxXU/EIWQ3i+9ihEFz AfY6AxxhWgry+tWXyHPtY5p2p1CZjLoIrq/2VjnjEZ0gIjd1jTES937yrsLI2AVQIytb eoVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722539085; x=1723143885; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z7NY6WJlLWSbTfpX37bQ1gwtcF7PiR8RtE7LJx3zf6Y=; b=bk8RF4xDwuAVjWeheBxPQDPHInba7ZHHcFnWtj0aCMuqdkWyqocxh9mhrDeh7egwd6 BoHpN308iGpTipHqFEaw0uBAX0N3JsmIDCdYBbXiCj3rYTQGkXJRFAjzFUGzv5p3g8Jo LS7hMQm6OFm8ntr6E1w20CZLaWxxtVV3x3/fKp5nXAk0XPJDyhSNJgHmpLf4a5mhuann 7XaxGNwBKPmFIlceg8gcm4Lfs+lXkPPj0ukPULyGNt3EwcOLfPal0MMrtJfvMMQ0Yewg eXWBpb9qtOLIhbTbM+meMHl+50mJzq3IMG6j9mRrlv5x5C0XD0bltGTSVjxGn0wXFcqz 0lBA== X-Gm-Message-State: AOJu0Yxaq8npL0kl2Ui8YCGDxtp2DotL+k/ovPrOwL2zmA6I2PUe8Uw6 fPuQXwegWolXRPKUKy5RYF3SwDhzwmiq9RwbKCXQafhg8OzVc6NE/J/fVpXeqVuflq4idQbW10U O X-Google-Smtp-Source: AGHT+IERsmoagSjDI19R6lOladgRWSNxS911KNAkiiQ4fPpjjsTusPlxX2X2GDKlfDZ4b4W1Wti+ng== X-Received: by 2002:a05:6871:113:b0:261:575:5384 with SMTP id 586e51a60fabf-26891aecef4mr1338431fac.16.1722539085167; Thu, 01 Aug 2024 12:04:45 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a34f6d800dsm18340385a.8.2024.08.01.12.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Aug 2024 12:04:44 -0700 (PDT) Date: Thu, 1 Aug 2024 15:04:43 -0400 From: Johannes Weiner To: kaiyang2@cs.cmu.edu Cc: linux-mm@kvack.org, akpm@linux-foundation.org Subject: Re: [PATCH] mm: consider CMA pages in watermark check for NUMA balancing target node Message-ID: <20240801190443.GD3365290@cmpxchg.org> References: <20240801180456.25927-1-kaiyang2@cs.cmu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240801180456.25927-1-kaiyang2@cs.cmu.edu> X-Stat-Signature: rx9p3ezwp3iysnpw665k91k3xabwo9cq X-Rspam-User: X-Rspamd-Queue-Id: 67FA21C0010 X-Rspamd-Server: rspam02 X-HE-Tag: 1722539086-921450 X-HE-Meta: U2FsdGVkX1+NXy1ygFBqACKLJZJ1CJL6/8zkHxHyVwoHkrdyK79KIscsOX+dETreVoAOe6T0kR+npmeWgaub4irxS/+APA7vJJ1rvn9dLGsezaTRdFcu80VZ89/BfQ3fhDFtoHf46PoXlJ50iUu1qAro9pm1CiZ8yO9Lor9knQ2q2D8cvqXyIui+kLUF0Dl4OoDlammJ1fnTLhKMAEQ5uDUhcw4iVdXicCr5SQwjiA65q3CLWN/2KOE4LaVdZZXhb1seZu8Q2rzBS+lo2ssVC+ZBM4WrTMJNkK3SPy+IQxcsCLYyJ3uJzdt5f4WQ7H+Z6lDfIIr7vh4yPbWjPKAb62jdxk1PLdp3w85HJ/YzhCejIrXkrP1YTakK23CLAGOKAmN1UFFJvNA+n8eM/ThH3oet0xigMCbqN/BzDgkzvkjkfvIQdIOOSHbz6IFL7q6hCH1uPw4eHP0XXeG5AJOFGcK24pqEJgaT7fU5R9xpVJgnSx04zLiGV92ZUbtKBVJTmczRVt3RuGycyoKk6n9pU2l3Fcl6GDqi4LvUTKwp5VrLkRSO8HVtvAiH8BSzhnz881gI8iaPwdBT7ysN14LDd5NraU4WXRdKIlU+HafzvDpC0Y2/KG2tlYYN8F2vf5Yzu6b3Ros21qcrvQaKpyICDRr1Rp6XnyATb5vRme2IJPnFYcOri0Ku6rMKJDN/0R4xx+dnV+liLRsyHqSey2WO/8j9BOdfNis2jInSLJfWTbbvYBThO3iMI90F6fteiRNedLeIGEWYBUppxQ9QFwV5VGVR5hSriSDjQOEPjDcxyf9tFHWE66MPWFkscXlDEyAa+Q2z/g9laL/Jtilqjib4VsgZbWR1aC8k825RFCfjZh++OR4q/3OMjhxX7Mgt6644vpOzxNuCVYvijLwGBT11+QjYlwkrcgPusRGizMQgjpfhnICyUuBBOE2rZj0Gyjit0qPEGjJi85kFoHv8hJv QKxH8yza YpdKQVEfJr0obYZkSd6YbRZV7b5Hwr48XBk1GoxoiFWN3yDI6DQD3zweGYcHtH5sWePZczJeRckoTZahE6bwvpIZkTxXJIknYqwQ7TZ6oofGZ07Q1pl5mKzoKiVt0kVQqo7Y6ECXrX9Cc9LKHFMOVQV6VXYrEsyGMEnfwOzMq3KwG+K/61RqB/LzJ9GtJchlp1j3xlWBpBpKCntBdEmq6gd4WqlWGVXnsCHYAMNLsbTBNvd/mmFaESIjITtPXURka73MpDQmBgzv7WAyirB6PGRwF4Y8zUwahN9hiFH3I0GlEZisA0BFvo7r2paGFbGfJXkYaV6IXCIK2vNGW3hEB2j/JwLMyYVsEZAcjHhjEaokFJfk9Ajd4euZyFlkZ1gAGcD+yEMn43O6qfCa8CW3UQ6gJgSM53eOZEkxeJj2Pj8GmzEZR9iAmQ9j1TZnUQIyqOPeBSFTlgWjiS0EZL8N5q+jik+4P6d9yuhaV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 01, 2024 at 06:04:56PM +0000, kaiyang2@cs.cmu.edu wrote: > From: Kaiyang Zhao > > Currently in migrate_balanced_pgdat(), ALLOC_CMA flag is not passed > when checking watermark on the migration target node. This does not > match the gfp in alloc_misplaced_dst_folio() which allows allocation > from CMA. > > This causes promotion failures when there are a lot of available CMA > memory in the system. > > Therefore, we change the alloc_flags passed to zone_watermark_ok() in > migrate_balanced_pgdat(). > > Signed-off-by: Kaiyang Zhao Acked-by: Johannes Weiner