From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5B02C3DA64 for ; Thu, 1 Aug 2024 17:47:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 672346B0093; Thu, 1 Aug 2024 13:47:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FB056B0095; Thu, 1 Aug 2024 13:47:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 475256B0096; Thu, 1 Aug 2024 13:47:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 270876B0093 for ; Thu, 1 Aug 2024 13:47:45 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 77D24140F36 for ; Thu, 1 Aug 2024 17:47:44 +0000 (UTC) X-FDA: 82404409248.26.E7106F9 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf19.hostedemail.com (Postfix) with ESMTP id 34B091A002A for ; Thu, 1 Aug 2024 17:47:41 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722534457; a=rsa-sha256; cv=none; b=VT8RjEofhBQn6Y86NKJIhE1j86ODgh6Unl5fcyBDYe0dn3U6tLMjnFboT8edCGonZ6INw6 3GKWDknLWQEe2zq3ftIb4jn2PNqVUkaI6dnpWC+CvBOc+cWSCBLT6GBzoRPBnR0tPWT3UX 238B6G1gHF4vGo68eQxOnGRLIL1DN88= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722534457; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A/pGB8CPFMxkatBosLBj4Yyq2m9GZhAMAQ3JjJn7/ng=; b=OyPm5ySNJdnWdKYnKM264dyBTS4ip7hkj3DRsQgYM7EFo2yYDxBQf2zu4Kf6k++vJrXXgo 82Zhd1gVRFTg+q4NAxHRBL4XDbWb9QtAgpn91SQuTWsRLoTvi6u/ELwcOaP0FVvRQVqLZK fI020Th0B539IHe4rI/439khK0hjtto= Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WZbvg4GP6z6K91N; Fri, 2 Aug 2024 01:45:03 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id DD56C140B55; Fri, 2 Aug 2024 01:47:39 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 1 Aug 2024 18:47:38 +0100 Date: Thu, 1 Aug 2024 18:47:38 +0100 From: Jonathan Cameron To: Mike Rapoport CC: , Alexander Gordeev , Andreas Larsson , "Andrew Morton" , Arnd Bergmann , "Borislav Petkov" , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , David Hildenbrand , "David S. Miller" , Davidlohr Bueso , "Greg Kroah-Hartman" , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , "John Paul Adrian Glaubitz" , Jonathan Corbet , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Samuel Holland , Thomas Bogendoerfer , Thomas Gleixner , "Vasily Gorbik" , Will Deacon , Zi Yan , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 06/26] MIPS: loongson64: drop HAVE_ARCH_NODEDATA_EXTENSION Message-ID: <20240801184738.00003e6e@Huawei.com> In-Reply-To: <20240801060826.559858-7-rppt@kernel.org> References: <20240801060826.559858-1-rppt@kernel.org> <20240801060826.559858-7-rppt@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To lhrpeml500005.china.huawei.com (7.191.163.240) X-Rspam-User: X-Rspamd-Queue-Id: 34B091A002A X-Rspamd-Server: rspam01 X-Stat-Signature: 3x3iccd4o8kstcdm33yo8wfranx3uje6 X-HE-Tag: 1722534461-917411 X-HE-Meta: U2FsdGVkX191/r5Im5EXQ0ZnJqkmWCkMXXl1Co4SwcKJ6dyzYWA7ldSLVZhhxO6uJM9gNdqvxSYGtEgucH+AJy7hFybFSApjQ4GNY9WSR8YZ+crNhlgNRPc1o0Lu9mH5K1Gbt/9tAhb1TCIWDQD8jsfHf6VmeDdkxfw449Vhrnnuib8dN/yxxOMhzeERSrj3qvoj8MMcxNTByXu7m21BNV07BfpCKXUOQ+B2lSEHSRYs0/0oJ8omXtILUxj2GXc0TIspXeEfdxHABW/jZfNByJtiihZ0UywyNY0GPHU4kIeqrSTPIDIjccAjDQuNi2YsQ3HDxHx6h8dBbf1SaIQp1PRoTANmTyX+F/WoxaPZ3PeKeNSDxE9NiYIIRzVi4odXuLkWWfe6yi00LwqGxBiz6hUjQtzDk5iKsZoQBLII9ZtVGoRmHaB520Mssj9B0+dwRBpwO7brfWBrWz6UOcL+jaiDFkyX7lE9Y6BEUwNmmXJgjEfTYZ1s3SdyFUFGIQQqxCrT/xmUQCmQGvgufe56Wouq4czyCMZENxikKJjnFn9PZWkt3TP4tQ704URtheVOEYgkomidSyNuo8CqQXOJfWmdTQiSitf5Sz00eRAM1H9quzssktCIQ87OdNOLHGwgw1LzKnR5oNy3iPQmalFhrfqdTShGQLB0Nj1S+z3RPVumSG1IfBkMLlfyQXCjWchBFrDNIw3fdXqgSCLM+jqK2b/4zYrt/tNKmjU9RdZB/zz92mXZssvB8nEVjENK8RJZDPUdmm712eT75ony1H+s6kLGd1DRQ3cpo3U7G+Myw1+X6gfGqyqntMH7L5h5iC5LZRt3m78VBPC38mz0rAIK3nmAJYksWXs5s/q1KGHWBcQY1PkHH7IP00r5HLrFTvmZunFmwWftRCNHxA8FcspUPURnI9Ao7LUSs6O6421OJA8H2+OnG4pjnXhbYvNTwTJZtqm7jnNBKnh0/ceAHnU Hvw68eDb bFICCYUpRuxW+U/xPFdxl82WCs+mFT6Z0wN+//5fZI//MmEZgb9q7WMJKls5UAet+uzHhMFxVZEHy3rqxUrEq0Hi9ti4/sfG1b8I/4qGVHgoCQQW+UkTa4uWyZzHVyyNCJ1Oc90knt87gOztp1daO6Dfds9zoWt1Pduogf3hxyoulnuRHjAPLMGSuuXj0emmPFzSClFGZjXekAMpHVuXI6xxs/A5nB2eNTpWba+t5R0hKH02ETobvOmWKcmLxsnyRQGZTBt3GSJQZLGmrlYi2/tN5UY9Dhf9BQFhJtpy5rcVsqiIBwtF0nv72mlc7INZ4LU8/MBmZElI09uIRe9+s/XLxgF+9o24563xZTGKUvWY1J+AY2+u9flqlSw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 1 Aug 2024 09:08:06 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Commit f8f9f21c7848 ("MIPS: Fix build error for loongson64 and > sgi-ip27") added HAVE_ARCH_NODEDATA_EXTENSION to loongson64 to silence a > compilation error that happened because loongson64 didn't define array > of pg_data_t as node_data like most other architectures did. > > After rename of __node_data to node_data arch_alloc_nodedata() and > HAVE_ARCH_NODEDATA_EXTENSION can be dropped from loongson64. > > Since it was the only user of HAVE_ARCH_NODEDATA_EXTENSION config option > also remove this option from arch/mips/Kconfig. > > Signed-off-by: Mike Rapoport (Microsoft) These are as you say now identical to the generic form, so don't need a special version for any reason I can see. Reviewed-by: Jonathan Cameron > --- > arch/mips/Kconfig | 4 ---- > arch/mips/loongson64/numa.c | 10 ---------- > 2 files changed, 14 deletions(-) > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index ea5f3c3c31f6..43da6d596e2b 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -502,7 +502,6 @@ config MACH_LOONGSON64 > select USE_OF > select BUILTIN_DTB > select PCI_HOST_GENERIC > - select HAVE_ARCH_NODEDATA_EXTENSION if NUMA > help > This enables the support of Loongson-2/3 family of machines. > > @@ -2612,9 +2611,6 @@ config NUMA > config SYS_SUPPORTS_NUMA > bool > > -config HAVE_ARCH_NODEDATA_EXTENSION > - bool > - > config RELOCATABLE > bool "Relocatable kernel" > depends on SYS_SUPPORTS_RELOCATABLE > diff --git a/arch/mips/loongson64/numa.c b/arch/mips/loongson64/numa.c > index b50ce28d2741..64fcfaa885b6 100644 > --- a/arch/mips/loongson64/numa.c > +++ b/arch/mips/loongson64/numa.c > @@ -198,13 +198,3 @@ void __init prom_init_numa_memory(void) > pr_info("CP0_PageGrain: CP0 5.1 (0x%x)\n", read_c0_pagegrain()); > prom_meminit(); > } > - > -pg_data_t * __init arch_alloc_nodedata(int nid) > -{ > - return memblock_alloc(sizeof(pg_data_t), SMP_CACHE_BYTES); > -} > - > -void arch_refresh_nodedata(int nid, pg_data_t *pgdat) > -{ > - node_data[nid] = pgdat; > -}