From: kaiyang2@cs.cmu.edu
To: linux-mm@kvack.org
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
Kaiyang Zhao <kaiyang2@cs.cmu.edu>
Subject: [PATCH] mm: consider CMA pages in watermark check for NUMA balancing target node
Date: Thu, 1 Aug 2024 18:04:56 +0000 [thread overview]
Message-ID: <20240801180456.25927-1-kaiyang2@cs.cmu.edu> (raw)
From: Kaiyang Zhao <kaiyang2@cs.cmu.edu>
Currently in migrate_balanced_pgdat(), ALLOC_CMA flag is not passed
when checking watermark on the migration target node. This does not
match the gfp in alloc_misplaced_dst_folio() which allows allocation
from CMA.
This causes promotion failures when there are a lot of available CMA
memory in the system.
Therefore, we change the alloc_flags passed to zone_watermark_ok() in
migrate_balanced_pgdat().
Signed-off-by: Kaiyang Zhao <kaiyang2@cs.cmu.edu>
---
mm/migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index 8578a930cad1..aa482c954cb0 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -2526,7 +2526,7 @@ static bool migrate_balanced_pgdat(struct pglist_data *pgdat,
if (!zone_watermark_ok(zone, 0,
high_wmark_pages(zone) +
nr_migrate_pages,
- ZONE_MOVABLE, 0))
+ ZONE_MOVABLE, ALLOC_CMA))
continue;
return true;
}
--
2.43.0
next reply other threads:[~2024-08-01 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 18:04 kaiyang2 [this message]
2024-08-01 19:04 ` Johannes Weiner
2024-08-02 2:40 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801180456.25927-1-kaiyang2@cs.cmu.edu \
--to=kaiyang2@cs.cmu.edu \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox