From: jeffxu@chromium.org
To: akpm@linux-foundation.org, keescook@chromium.org,
jannh@google.com, sroettger@google.com,
adhemerval.zanella@linaro.org, ojeda@kernel.org,
adobriyan@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
jorgelo@chromium.org, Jeff Xu <jeffxu@chromium.org>
Subject: [RFC PATCH v1 0/1] binfmt_elf: seal address zero
Date: Thu, 1 Aug 2024 17:08:32 +0000 [thread overview]
Message-ID: <20240801170838.356177-1-jeffxu@google.com> (raw)
From: Jeff Xu <jeffxu@chromium.org>
In load_elf_binary as part of the execve(), when the current
task’s personality has MMAP_PAGE_ZERO set, the kernel allocates
one page at address 0. According to the comment:
/* Why this, you ask??? Well SVr4 maps page 0 as read-only,
and some applications "depend" upon this behavior.
Since we do not have the power to recompile these, we
emulate the SVr4 behavior. Sigh. */
At one point, Linus suggested removing this [1].
Sealing this is probably safe, the comment doesn’t say
the app ever wanting to change the mapping to rwx. Sealing
also ensures that never happens.
[1] https://lore.kernel.org/lkml/CAHk-=whVa=nm_GW=NVfPHqcxDbWt4JjjK1YWb0cLjO4ZSGyiDA@mail.gmail.com/
Jeff Xu (1):
binfmt_elf: mseal address zero
fs/binfmt_elf.c | 4 ++++
include/linux/mm.h | 4 ++++
mm/mseal.c | 2 +-
3 files changed, 9 insertions(+), 1 deletion(-)
--
2.46.0.rc1.232.g9752f9e123-goog
next reply other threads:[~2024-08-01 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 17:08 jeffxu [this message]
2024-08-01 17:08 ` [RFC PATCH v1 1/1] binfmt_elf: mseal " jeffxu
2024-08-05 21:05 ` Kees Cook
2024-08-05 21:33 ` Jeff Xu
2024-08-05 21:01 ` [RFC PATCH v1 0/1] binfmt_elf: seal " Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801170838.356177-1-jeffxu@google.com \
--to=jeffxu@chromium.org \
--cc=adhemerval.zanella@linaro.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=jorgelo@chromium.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ojeda@kernel.org \
--cc=sroettger@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox