From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91918C3DA4A for ; Thu, 1 Aug 2024 23:48:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04ED46B007B; Thu, 1 Aug 2024 19:48:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F41AF6B0083; Thu, 1 Aug 2024 19:48:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2FD66B0085; Thu, 1 Aug 2024 19:48:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C4A406B007B for ; Thu, 1 Aug 2024 19:48:21 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 33D3E80AD9 for ; Thu, 1 Aug 2024 23:48:21 +0000 (UTC) X-FDA: 82405318002.14.D5BB1C0 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf10.hostedemail.com (Postfix) with ESMTP id B3C5BC0002 for ; Thu, 1 Aug 2024 23:48:18 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GlEnAuTC; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722556043; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GsrUF3MC4C6UeNbc2OBzz/F5HbRLmvvfecA056bwryk=; b=SSFfw0SrS0g7IhqhEj4F3gzsXogIhwUZWVUkYGWetS7TP2bx7n17ff0pGjRQ0cYVGPfJWc x789sQo1At7VqwYp4MZ3edIwjwd3TVb710XLMGT0u9K1945MqEggHw6oIEvFtjhPDJMz0O 55N1qHweGpBkMFu2AmfbOPgsjHm6hfE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722556043; a=rsa-sha256; cv=none; b=w0r3CqBuAfXZwbs4lmRCIylZ6QdyBveHB7d8O5us19eSWQkuWoq3W//F7uhbu55+ttXbBY mRBPWZActYtcWgvtIMjaT5bXa34Q3DORn9n7UVo9/2g4HYRJaA0DZg9krUHUqsjiUeUC7Z gX/8Y7TtVgX1FnZ6qm9TuaQAc6/aa/Q= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GlEnAuTC; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 08E7CCE188F; Thu, 1 Aug 2024 23:48:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 288EEC32786; Thu, 1 Aug 2024 23:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1722556093; bh=2ut1YPHJx6wq1KEXO8qrFRuk5NrrNOqjhdd/A23vCKI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GlEnAuTCcNZSDWHCJtni8PsBwmvjEcqRmr5exhTwyFyVLlL4zCjfpa6icbh8Spxt+ MrLoCTt+A88OGCGIh3wP/maXFE2goUtxgY98Mm0d5KKmvCIupFTnAYBqUPqxJZR+/3 31VeilUtu2/eIIWTqpqbNDvS/HfTVg7GeOLkQ/fk= Date: Thu, 1 Aug 2024 16:48:12 -0700 From: Andrew Morton To: kaiyang2@cs.cmu.edu Cc: linux-mm@kvack.org, hannes@cmpxchg.org Subject: Re: [PATCH v2 2/2] mm: print the promo watermark in zoneinfo Message-Id: <20240801164812.8b56ea0369bacf247caa463d@linux-foundation.org> In-Reply-To: <20240801232548.36604-3-kaiyang2@cs.cmu.edu> References: <20240801232548.36604-1-kaiyang2@cs.cmu.edu> <20240801232548.36604-3-kaiyang2@cs.cmu.edu> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B3C5BC0002 X-Stat-Signature: 4tux61pmo3piy9s9jwfp8yrqpu411oon X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722556098-878498 X-HE-Meta: U2FsdGVkX197If03WMN7O4WMWzkJ36OcnAQniRd8ebk3CtJ7+1k/bWCzabJmJB8t+mtNNL0zPfE7ejTashpm0mI7Zzu70HI+pKDtFogW0FfEwnT8Paiviycpf4PkbeEoLEqvnuXWeX0lo0XrddzkDbjrWUwalgZ6TQmgc7sXM3N7LVCAsHXbvlVSa4UGrqImGCsYcTYXVKJqEnjSGQI7iJv4jAZWbO86Pi4b2GL4WWW5J/x+QJFlCGh+brJ6ByQ7ZY6COR8SvCB3M+P/d1XNtKJiicOA/jHy5tozhecErluZwMckXJjEdCgkilUgtxL1BoE6z0o9hhiI6KmwRvrTqZaNfziP+O9jXHougV+FDvMI6B/V8ft44qx4cKJMGlOj1ixGLxxt2Wn76TmIzCIwFKIycYT6Zah1ehrbzgxnxfCQehH9F6+fXoNNJhUCZJiRuj0uzbmLXg4dpuC9y3UpfElEGCAfh7mCUNe9ZZiaQEfjkpo8m26zZztewWY4kYnrrEiBqfoVWo7xfzCpYtp30XH5yVPmlP5TSnBfxT8ODdnM9NleZuXtW9ZqunBzqWTZqeM2RWnfxUVpVH/wtaNdU+DE/H226x4GKDpJup44FpsF+JgtlZ3WQBe3U78Jvqs4GRs4EeltvljkQNMICQT8Ly8dGVyv1P4e3+6p8HwJw3PwtoIkNfLgiWk/fhDN2OWqDMzX/hMaLnqINpeCPzzsuInHDI+4ChJBu5xW9zhYaVhtLr+ZcMUfG3ahie4JNyDOEFi04D9azYsucCjCRr6mOuXUp1SUAIhfLiXg81+iwYich1PFnznwj6sVqLeY3L1DVJz+pgAuQh9ZdGJOBPjS282PPSHKgbBNnf1Orp4tNhL6j/QlxRhJnrrT+6XlQeaWzVsAX7Tw41zCFv+Po73BbbBIxWQL7145J7mUCPLMFrcwYMbTGiZq6vLd3//2I+vbWQv5bhbv8NOb0zIaT9Z IhBdxpAR 0JpEwlTV4Z8u9GMB5GPi/U8eVvOBSA2PeGvYKIDPmiXKQ+SQbHujb/T1ohhcvdHHvxxY3yU3PsktVSxSPykQi9YAqPnbKPz4fh2usWcjMphKt87sSC/6oJhrPoLDYJMcv3zKq7ImiycXRZ1UVPYxCdn7HOq91e96WnmJGGeA3iejaWoJRzgL/qhpu6EwSndc1SQ7K9T1DLpsGAJ3OEe9gRB5Y6UVincsrl+X6lxcNQTppaytqaEKF7WIIxg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 1 Aug 2024 23:25:48 +0000 kaiyang2@cs.cmu.edu wrote: > From: Kaiyang Zhao > > Printing the promo watermark in zoneinfo just like other watermarks. > This helps users check and verify all the watermarks are appropriate. > Well, I guess for a two-liner I'll let it go, but it would be better to tell us *why* it "helps users", rather than providing an unsupported assertion such as this. In what scenarios has this proven useful? Details, details, details - spare us none.