From: Andrew Morton <akpm@linux-foundation.org>
To: kaiyang2@cs.cmu.edu
Cc: linux-mm@kvack.org, hannes@cmpxchg.org
Subject: Re: [PATCH v2 2/2] mm: print the promo watermark in zoneinfo
Date: Thu, 1 Aug 2024 16:48:12 -0700 [thread overview]
Message-ID: <20240801164812.8b56ea0369bacf247caa463d@linux-foundation.org> (raw)
In-Reply-To: <20240801232548.36604-3-kaiyang2@cs.cmu.edu>
On Thu, 1 Aug 2024 23:25:48 +0000 kaiyang2@cs.cmu.edu wrote:
> From: Kaiyang Zhao <kaiyang2@cs.cmu.edu>
>
> Printing the promo watermark in zoneinfo just like other watermarks.
> This helps users check and verify all the watermarks are appropriate.
>
Well, I guess for a two-liner I'll let it go, but it would be better to
tell us *why* it "helps users", rather than providing an unsupported
assertion such as this. In what scenarios has this proven useful?
Details, details, details - spare us none.
prev parent reply other threads:[~2024-08-01 23:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 23:25 [PATCH v2 0/2] " kaiyang2
2024-08-01 23:25 ` [PATCH v2 1/2] mm: create promo_wmark_pages and clean up open-coded sites kaiyang2
2024-08-02 0:03 ` Andrew Morton
2024-08-02 1:31 ` Johannes Weiner
2024-08-01 23:25 ` [PATCH v2 2/2] mm: print the promo watermark in zoneinfo kaiyang2
2024-08-01 23:48 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801164812.8b56ea0369bacf247caa463d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kaiyang2@cs.cmu.edu \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox