From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 581ACC3DA4A for ; Thu, 1 Aug 2024 13:30:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEC708D0008; Thu, 1 Aug 2024 09:30:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9C9E8D0007; Thu, 1 Aug 2024 09:30:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A15AF8D0008; Thu, 1 Aug 2024 09:30:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7CED78D0007 for ; Thu, 1 Aug 2024 09:30:13 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2D19AA7769 for ; Thu, 1 Aug 2024 13:30:13 +0000 (UTC) X-FDA: 82403760306.11.A07E2B6 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf13.hostedemail.com (Postfix) with ESMTP id AE05E2001F for ; Thu, 1 Aug 2024 13:30:09 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qC7u8fjT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="tGk/d7ci"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qC7u8fjT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="tGk/d7ci"; spf=pass (imf13.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722518952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IXiIJTWZEIl7vR9DhU1w6IJRUW9JpFHNQs0JlIhUbAw=; b=I9MTz9L4a0L1eLMXprNV6iUBDoNf8Z+2h5fasimAowXrL327MgO3OlTx0bttE+WFy9YrJY 02AAican4ruXwjFy1vpH8fl6KOjFCBUwiIHHh5er1T/SS6Ze5QVrzXH70fETdocjPZlUEL pP2+dvVbhft2ZEyiVRH/nNgDtnfJyxM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722518952; a=rsa-sha256; cv=none; b=HBOyKYCppHqPNHkKBVdGQvRwI4jpW80jxZSuXzbzsUOTJLn1Kmm6Zv+vjX6pVj7HCoBD1m O61x8XKwUZwZ0JNcfpgBFY5fyeznCdqV9X6CJ8n2aVd7JwiQUcjngUxz8i7hNuGYEyCYHe I+3P19GKeSgY40IYSPsrpL0z5tL1GT4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qC7u8fjT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="tGk/d7ci"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qC7u8fjT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="tGk/d7ci"; spf=pass (imf13.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BCE1D219F9; Thu, 1 Aug 2024 13:30:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722519007; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IXiIJTWZEIl7vR9DhU1w6IJRUW9JpFHNQs0JlIhUbAw=; b=qC7u8fjTT+tFNUV6IUPCTYeN/02Z8SRsmzO75UaFsIvX/n+J11jfGHcBAP+C5ORbxKyr4Y cZeogKAZ+Jdo1pfojKN1bQ6p51MBE+oN0O6Kpt0iz1T6BGSxYp0ssseedtjzfqjqgiXHRs oZ9AU0X3yTxYVapFUqpAKPQruf7VEJw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722519007; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IXiIJTWZEIl7vR9DhU1w6IJRUW9JpFHNQs0JlIhUbAw=; b=tGk/d7ciKdZqLYFMNwapCmfu8/kphu5jgNGDM6VFlt+zhpJypGnv+l1wTlAIEorhP7MJUY iuWfMsiBhsWaHrDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722519007; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IXiIJTWZEIl7vR9DhU1w6IJRUW9JpFHNQs0JlIhUbAw=; b=qC7u8fjTT+tFNUV6IUPCTYeN/02Z8SRsmzO75UaFsIvX/n+J11jfGHcBAP+C5ORbxKyr4Y cZeogKAZ+Jdo1pfojKN1bQ6p51MBE+oN0O6Kpt0iz1T6BGSxYp0ssseedtjzfqjqgiXHRs oZ9AU0X3yTxYVapFUqpAKPQruf7VEJw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722519007; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IXiIJTWZEIl7vR9DhU1w6IJRUW9JpFHNQs0JlIhUbAw=; b=tGk/d7ciKdZqLYFMNwapCmfu8/kphu5jgNGDM6VFlt+zhpJypGnv+l1wTlAIEorhP7MJUY iuWfMsiBhsWaHrDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9FE8F136CF; Thu, 1 Aug 2024 13:30:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id HLmaJt+Nq2Z9cAAAD6G6ig (envelope-from ); Thu, 01 Aug 2024 13:30:07 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 41728A08CB; Thu, 1 Aug 2024 15:30:07 +0200 (CEST) Date: Thu, 1 Aug 2024 15:30:07 +0200 From: Jan Kara To: yangerkun Cc: Christian Brauner , chuck.lever@oracle.com, jack@suse.cz, yangerkun , hughd@google.com, zlang@kernel.org, fdmanana@suse.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@infradead.org, viro@zeniv.linux.org.uk Subject: Re: [PATCH] libfs: fix infinite directory reads for offset dir Message-ID: <20240801133007.jf6m223mszye66e5@quack3> References: <20240731043835.1828697-1-yangerkun@huawei.com> <20240731-pfeifen-gingen-4f8635e6ffcb@brauner> <9107aa4d-c888-3a73-0a07-a9d49f5ec558@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9107aa4d-c888-3a73-0a07-a9d49f5ec558@huaweicloud.com> X-Rspamd-Action: no action X-Stat-Signature: ye5wa1dzk93cokpk8pob9s5u5jq5pqm8 X-Rspamd-Queue-Id: AE05E2001F X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1722519009-313208 X-HE-Meta: U2FsdGVkX1/oE23Aofvo2GetD4U3CmQGJDrDr0qSmaDRJUOXHu8Z9MwJnMwIkmV7P9djBieVU38rWTpjRatLtWiqHp6zrnGgZ2Jg/ocAwWJNahSvHqiQVSIDF4b+3WgpWRmxw+YOYy1VCtQTEZ3TlIYuhzm6u3U+hxf0qre3kQ6ZPYxNgAfrWqVbZsPLZWXdH3q4i7vW7o/ZgO0umOGHKc40RweNC5MY6zpFzFkLh/7MB3DiWvrg+K4N8QQqqdxpefUxOfv3I/VRU7HrJhzo94yvpCMdP1L9lG0sF9ggRjvO7eMLHcviptJoMkadI3oQgRhOFPrnZNs8Oe2Tx875qpotelFJxWoe2CaTDi3pilHeS/7W+DQx7Q1mr1JG4Ch/4xJDuUi/0RxTtXKYtLD2rA/nPaeKi2Yd06kLzXoxNg7TwJ6vUMnEdmMVjS8wL6Nu6dVJ0hJkN3+/YrRrJbdTeceUQOLnt32/A4voQqpLWQpW4bgX9SptGmLjyLaW91+ARHhyLukcvD9rT099PAqkVxo9YRWT+x/6B+Y0Hd7h7kuRyYvBRctIKZVFyd4PdaFGh7MtMuxE+fdACk5AFoQ7ws6zpoJzKmWh1pMLp2lMQ+GrSegYfO+Ipkv1SYDLJhTzB+uj6eF1sHu/ggJC2q2Sw/qgHttY1/ex+BQF8NltGmv3XncjTPPRAwmCf8LhF4z8xHh86nZ7cX7A/2xSt9aSeezTOY37B/a7w4O00Psv2iaJy8zMiWAjjvt68PmqR6EbSd5Jo7ihshCIWCjGL8Xtjx7+x0ZUxFWiE2IqGa5KGlYkKhlWo9364vhlY36uPln1Xk2SPhbIQVEA8nQupBVDmGvMIoFHVv20bH8D1oX1y+YGN63W8WLBlVATbZeZGPIP2h3kzj+7Z3nopB3lZSA4nEmTw6bkCBMFJlXWU+1Ne5ugZVfniqOVQfYjAO6bnx/uKZzCeTaY73kug7JsI+p hLnz+YLK z2zOooFdORZm4jd9bKNUcbDUHsSp3Yjn0mT+msLX/PdkyELSCzej5gtB5vMolywxNfAWznqjeuIEF9LwHm8NecKsTl8nAtvr3SHXy7GLbNOGD3rvlZJnBx3XmdXB+jKgBjTC1MmYK05CWhZMhf9kEpgC6A4f0f77daQJ1xPMnigLh0mGTGM719EiGZQyXElaQh8588qXTOv118wywe1BMsqgb14BKtuRqNZOaJrvgXBiOThxyGepeGI/iM6jzvwr6azxkv95LY8GHe6vLL54Es13Gp1IUJo+T8gk/5gebMAEWD9S+2XN1tAYqex9mIfo3K008Gb0wwoTcbOPXGXW2aaKMrvRrS7RhBNpvEAu2g4Cn058= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000532, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 01-08-24 11:32:25, yangerkun wrote: > Hi! > > 在 2024/7/31 22:16, Christian Brauner 写道: > > On Wed, 31 Jul 2024 12:38:35 +0800, yangerkun wrote: > > > After we switch tmpfs dir operations from simple_dir_operations to > > > simple_offset_dir_operations, every rename happened will fill new dentry > > > to dest dir's maple tree(&SHMEM_I(inode)->dir_offsets->mt) with a free > > > key starting with octx->newx_offset, and then set newx_offset equals to > > > free key + 1. This will lead to infinite readdir combine with rename > > > happened at the same time, which fail generic/736 in xfstests(detail show > > > as below). > > > > > > [...] > > > > @Chuck, @Jan I did the requested change directly. Please check! > > Thanks for applied this patch, the suggestions from Jan and Chuck will > be a separates patch! Christian already updated the patch as I've suggested so no need for you to send anything. Honza -- Jan Kara SUSE Labs, CR