From: Jan Kara <jack@suse.cz>
To: yangerkun <yangerkun@huaweicloud.com>
Cc: Christian Brauner <brauner@kernel.org>,
chuck.lever@oracle.com, jack@suse.cz,
yangerkun <yangerkun@huawei.com>,
hughd@google.com, zlang@kernel.org, fdmanana@suse.com,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
hch@infradead.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH] libfs: fix infinite directory reads for offset dir
Date: Thu, 1 Aug 2024 15:30:07 +0200 [thread overview]
Message-ID: <20240801133007.jf6m223mszye66e5@quack3> (raw)
In-Reply-To: <9107aa4d-c888-3a73-0a07-a9d49f5ec558@huaweicloud.com>
On Thu 01-08-24 11:32:25, yangerkun wrote:
> Hi!
>
> 在 2024/7/31 22:16, Christian Brauner 写道:
> > On Wed, 31 Jul 2024 12:38:35 +0800, yangerkun wrote:
> > > After we switch tmpfs dir operations from simple_dir_operations to
> > > simple_offset_dir_operations, every rename happened will fill new dentry
> > > to dest dir's maple tree(&SHMEM_I(inode)->dir_offsets->mt) with a free
> > > key starting with octx->newx_offset, and then set newx_offset equals to
> > > free key + 1. This will lead to infinite readdir combine with rename
> > > happened at the same time, which fail generic/736 in xfstests(detail show
> > > as below).
> > >
> > > [...]
> >
> > @Chuck, @Jan I did the requested change directly. Please check!
>
> Thanks for applied this patch, the suggestions from Jan and Chuck will
> be a separates patch!
Christian already updated the patch as I've suggested so no need for you
to send anything.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2024-08-01 13:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 4:38 yangerkun
2024-07-31 11:51 ` Jan Kara
2024-07-31 12:51 ` yangerkun
2024-07-31 13:04 ` Jan Kara
2024-07-31 13:10 ` Filipe Manana
2024-08-01 3:15 ` yangerkun
2024-07-31 13:44 ` Chuck Lever
2024-07-31 14:16 ` Christian Brauner
2024-07-31 15:37 ` Jan Kara
2024-08-01 3:32 ` yangerkun
2024-08-01 13:30 ` Jan Kara [this message]
2024-08-01 13:38 ` yangerkun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801133007.jf6m223mszye66e5@quack3 \
--to=jack@suse.cz \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=fdmanana@suse.com \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yangerkun@huawei.com \
--cc=yangerkun@huaweicloud.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox