From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B32FC3DA4A for ; Thu, 1 Aug 2024 18:54:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 062D36B0083; Thu, 1 Aug 2024 14:54:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 011966B0085; Thu, 1 Aug 2024 14:54:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF6516B0088; Thu, 1 Aug 2024 14:54:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C05D56B0083 for ; Thu, 1 Aug 2024 14:54:22 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 68D6FA779B for ; Thu, 1 Aug 2024 18:54:22 +0000 (UTC) X-FDA: 82404577164.22.617DC47 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf02.hostedemail.com (Postfix) with ESMTP id 8394580018 for ; Thu, 1 Aug 2024 18:54:18 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=xcvAmll0; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722538454; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HseMBjzZU5j28nPpbrrnSqLOzwILWzOlLByDjQ2gtiM=; b=5ql/YzF9cwVHl58KUWQI7Co9p2gGNf5UBgiVRl+lPX5JAuOFz/b4lfBRHezrrIiHtlzXFx dBI6yGFtzKb5ZdE2+sTiSkmN+i6QpbpEos89cuu65NUvm92Vr2JOyu9/1M7Fwk83IFHFlT RMWxo0VWsSgyP+R1GaxeSkfkedSWZuU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=xcvAmll0; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722538454; a=rsa-sha256; cv=none; b=LGZu6rLBWMPi3iHWYsr/Py6YNEAYJ1yIQWFIuAP9SWY71qIF5ZJdLjQO3NLdP2rIw/OHjk DzS2KguupDHrVTCKfhxwXy2Foj+/4aFVU1jZMBJ5jBvvH3Cj1CiSM73aQYS1LuORV0Fdwr XU2Bd1/vHNfG8vb/G+gb7tRVHBgVVkA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 0AA87CE1A88; Thu, 1 Aug 2024 18:54:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E74AC32786; Thu, 1 Aug 2024 18:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1722538454; bh=kX23Ts+APj5QFabJ/6nsItYUqKHVuFqELNBUUTLwprc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=xcvAmll0IjsPUx+M31/b24lqvJBGxwGIQqDYpjrwxB74N2EehE+5yP4pTt63ipFbp 2W9AIajgbmbfs4f+bkLnigdqCi/OBnpd+wNX1EBmmmPKasKe8/aLQwI4345TmEH3aI cZJAUwcE4b9IGgjoGkb93DbcGoknr3viGN3xS+nM= Date: Thu, 1 Aug 2024 11:54:13 -0700 From: Andrew Morton To: kaiyang2@cs.cmu.edu Cc: linux-mm@kvack.org, hannes@cmpxchg.org Subject: Re: [PATCH] mm: print the promo watermark in zoneinfo Message-Id: <20240801115413.996ebfdc3598e761abc67e44@linux-foundation.org> In-Reply-To: <20240801182203.27848-1-kaiyang2@cs.cmu.edu> References: <20240801182203.27848-1-kaiyang2@cs.cmu.edu> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: up584gjcts9tr5u7mgh9ir5rhay6dmnb X-Rspamd-Queue-Id: 8394580018 X-Rspamd-Server: rspam11 X-HE-Tag: 1722538458-67152 X-HE-Meta: U2FsdGVkX18ytHvbEda+mrQ7au7np4cCUK/PPmAKM37aGPBI6VuVER8TQf8ojt79uo71MI3dL4AzzyY+aON2HrIRugLlkPMaTcGiv1qGSMu/mv/JQVuhXG7woxGep5J8+/HlSwD8Ts4RAtapXi5CBME+1gcTZJY+Sh2FvvMU85qje1C94YNJP3585E2sPFPjpiaKQeXuSOmp0Gt3fn319y2OXYd4FFjnk7a/0S8u3qCvmIyUZEHKP+idBe1IKej0YVBlfJ3vZM7ktO/Rck2N6fiXpsbpKnRmmKTn2PIaF6bRpxPbprjdaAGKJZBGRQ9fQLijH8bxudDBnQ8Iel0R9E8F8dL7O0ROFpWOxo+oLGzupn1BktBzuE+1BmobA3fgqtlOTA0z3K4OmJ0Wsv2pD4zqy0ZOmlIYgjZeG0tPCQWRKo3N2bYHF4H6f99m2wWGpTuM5K3ARSiEKNcrjGhwDMkRu65D3JeOkeGgBeWHK7ytvxmBxMZwCHZYzPClicVycHKEVKzHMtLrvPUEF5yrzIjdO/CZJ7UShbh8mJgwI1CBDl5WM5oR3jPlOX01IynVHNKhsTd45udhH+h/TqiobqzmV2WkLuCPpd+9+El9z8kpPucA1w4ens/vnGqppG6GwvFsoFFHYNV3eX07dYq2c40zQyB2ykBoouDSls9zofXglvjt7YmmN62D/o+TARcvMH56NDWq5Z+ki0Xuu4g+U6q0tIz+btSry4e2lNV02oqRAATL9hJChKglVUUDWZXjbKHZRGHGxArzQDQc0hEZ1BrEuaeRwK+CDV2X00rnEBWZlQwytO7xrQEaavoll/kLntDD7WfFA1IaCqEGhjVJGVPRkaXmfkKiiBUCDsFSjFYZr+qdX7zNCNkFXh/4X155HHRa0L5fjnQ1D7eY81a8Zgtkg4J/DJ6d+LUu0bSB1rmEtN40ihYm4fbycUqvccigGEOYBO99m02sm+/ab0M c8GouRO1 BI6rt97Ll4GJ/bVmc0LtWg7vihR/bApWcy5hD8aH+twH0lfIEO8E/RvRcv3XSQFss0MVQQ9L/tFS+A5cnoFxZ6NbaYj/Opiy6yEp7vZm5xdVYT21NLRtjS699y5+8xZgrlX+INznJMOoab4V7C1UWXqtIi0LDuCytwTyJqFDTYPdZCS7cLbtHRHfC29sX/TX75RFUPON+UhBExS/MAQGfdTBjpekDO34tCuzO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 1 Aug 2024 18:22:03 +0000 kaiyang2@cs.cmu.edu wrote: > From: Kaiyang Zhao > > Printing the promo watermark in zoneinfo just like other watermarks. > This helps users check and verify all the watermarks are appropriate. > > ... > > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1725,6 +1725,7 @@ static void zoneinfo_show_print(struct seq_file *m, pg_data_t *pgdat, > "\n min %lu" > "\n low %lu" > "\n high %lu" > + "\n promo %lu" > "\n spanned %lu" > "\n present %lu" > "\n managed %lu" > @@ -1734,6 +1735,7 @@ static void zoneinfo_show_print(struct seq_file *m, pg_data_t *pgdat, > min_wmark_pages(zone), > low_wmark_pages(zone), > high_wmark_pages(zone), > + wmark_pages(zone, WMARK_PROMO), > zone->spanned_pages, > zone->present_pages, > zone_managed_pages(zone), Maybe. I'll let others opine about the desirability of this. But you made me look at include/linux/mmzone.h #define min_wmark_pages(z) (z->_watermark[WMARK_MIN] + z->watermark_boost) #define low_wmark_pages(z) (z->_watermark[WMARK_LOW] + z->watermark_boost) #define high_wmark_pages(z) (z->_watermark[WMARK_HIGH] + z->watermark_boost) #define wmark_pages(z, i) (z->_watermark[i] + z->watermark_boost) a) how dumb is it that we open-code wmark_pages() three times and then define it! b) For symmetry at least, I guess your patch should add and use promo_wmark_pages(). c) all the above could (and hence should) be static inline C functions.