From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B082FC52D1D for ; Thu, 1 Aug 2024 00:07:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41A596B00A5; Wed, 31 Jul 2024 20:07:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37D3D6B00A4; Wed, 31 Jul 2024 20:07:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CDCC6B00A5; Wed, 31 Jul 2024 20:07:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EDE676B00A3 for ; Wed, 31 Jul 2024 20:07:47 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9FA70A0801 for ; Thu, 1 Aug 2024 00:07:47 +0000 (UTC) X-FDA: 82401738174.20.46DB538 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf10.hostedemail.com (Postfix) with ESMTP id 9CE86C0025 for ; Thu, 1 Aug 2024 00:07:45 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aOcHCSRA; spf=pass (imf10.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722470821; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zSn5iYZ3XPPt6Vm0cC+2jgi08W20+j2x54YW4tsdYTE=; b=J5M3o+VthvaZratnxdU6nrpzVOCIhJyhyTcBTZvt/kGYsXgAfdyYleLMAGudTNOz3gyfhT JvC0iAClyDOTxVC/4sHYxc91L9cPNSoDrpxFTwhhNZUXejlcT50kTdTlb5eNtMoHnyFQHy mXpt20u9VKNwbvbX/lMkNuQsV9pplI0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aOcHCSRA; spf=pass (imf10.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722470821; a=rsa-sha256; cv=none; b=G++uimf0Y7oL0NIEc3gMqQObpHSoLuRXT3PTVOKay/BD03WMfUUd1XvucUJrhAcELDSZ8r l1NBFELd9qtnY9BkHioRl5mqY7MAJeVTAXllkfj5WtvWPXEwT5to6uzahwJ/XVDN7qM03r D9qDG2JOHmo1cd2KQhJl3O73LKATRhA= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a7a94aa5080so751215966b.3 for ; Wed, 31 Jul 2024 17:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722470864; x=1723075664; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zSn5iYZ3XPPt6Vm0cC+2jgi08W20+j2x54YW4tsdYTE=; b=aOcHCSRAMASfIj7M92B/RHsbsMV/af/MvyaGMbIwuIE+XIShJ2c5q+GGkdBHVUReIw GmLbMCl3Iqw8ZXbXsnnOhRTVXNvLpUoL7Fd5WdLvI8qKsRiYGF7BCc+9xrI9m3xcVTpY QA7I2qPks1W6GHpHxSFDhd6Cv/2ljPsECJczy6fBZuaawd54JVcFRP8XpQfP2xf8MYmT Jgyy6Nvi5+/gpUZbBvIZ2OqPNwI4lcY4+JbJ2XnSNBWPKTUx1UVCZVnRm6DMOV62T9Wf yWZn4gRlkoY+jDeeco3ifCxPnJ7OotLbNtoksW0UV31YM3tq9KDpJl9MJeSsbHHS/+Oq ZXTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722470864; x=1723075664; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zSn5iYZ3XPPt6Vm0cC+2jgi08W20+j2x54YW4tsdYTE=; b=UmMKeb0a4J/Fe/CvKhn4ZeXGFNwbpgk2tIEAzviCKAWIdrgTumc1cd2OtgnantPKae yW8ZNdmInvqBMqvf5wNEq+S/yMGERilaQjB9tQs5RsJKWDNta1QxazCEAtGlt5y7LuLt +MtQzQ5FmxmqCIMT+4hIKdHpOlq9azOhAB7rlTsb8/o4YxTGmLccs8KHh3pIjj5OH3uk ZB1ZdYpT377UER6ci9yl9FCSErsV++lMQLegOAdn+XBmg1xVFXPqjZjGEGUJC2ZURq9z poeUrBgt85juVZKahvlDa4tljBynEhJhdsT/ReTA5GnZbw2sx5InUE8luA2Wm/Nx8Qu3 f3SA== X-Forwarded-Encrypted: i=1; AJvYcCUAY6G5dbQt/Z+C9D6x8Je3aAyIZDz00go69pG0Nd0spkk6dQEd7XpfyQPYqXaVQ7h3GcPyZOkVrQ==@kvack.org X-Gm-Message-State: AOJu0Yx3rN9MmV6Sia4Ws1yWnygELzmzDwJ66GgElblxhi0LpaNCUgO0 3rxwhM8SLk2AaiOkrAnqyECGvgvwvMiq+s+CZ1rbGlMsdhFnZgEQ X-Google-Smtp-Source: AGHT+IEJmMdZpxTUR4SqcCLTsphnTuppYKhH6EhhyPRrTD+adMLVFclhOxowV6t9RUOkeu3X9FoqXQ== X-Received: by 2002:a17:907:2d92:b0:a72:af8e:15af with SMTP id a640c23a62f3a-a7daf657bffmr56104366b.49.1722470863643; Wed, 31 Jul 2024 17:07:43 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acad411a6sm813676666b.117.2024.07.31.17.07.40 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 Jul 2024 17:07:41 -0700 (PDT) Date: Thu, 1 Aug 2024 00:07:39 +0000 From: Wei Yang To: Mike Rapoport Cc: Wei Yang , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 1/5] memblock test: fix implicit declaration of function 'virt_to_phys' Message-ID: <20240801000739.lrgmokbbgvikrlkw@master> Reply-To: Wei Yang References: <20240729014725.29839-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: 8atr3qs61z3cytccck8rx19y43y8i89d X-Rspam-User: X-Rspamd-Queue-Id: 9CE86C0025 X-Rspamd-Server: rspam02 X-HE-Tag: 1722470865-829959 X-HE-Meta: U2FsdGVkX19MS8y/QuhKkLN5x6LK9UMn92K2Om1Dy0K/kDrMHA2Gw79L89wduPGSk3nBOHeABRIS3yU0DQUTa3dRgdypRGsny1+/t+1j+OzGAJ5ClKVL1AYEwH9AZjycWz+W/7vokBEb0e1wY+FI2Dx7aEjxDvadDIAcVWksrLRenxNRV0OG1Ja+ITzx96gd32wPcClKBOYxdTl7pJeVqoX9rrC15y/z2tT+DX7izKQuRwLjVBtbUZXOTsmImw822XR2UXx0ndYbhZei74ECnRJ6T1RfI+b9Ld6IpUA2KdNH9tsmnv6yh94gmW/Fsai1h3NRLlfSDnBm9MWXBVsoe+8mDQ7JzjMRJbpd8y4n9xQqC+u8InbQzBTXGOars8UH1txE0fvfFN50cjdNgmL6RzfNf8P6PrCPcPZpMbsVDGo67XpnKE0dh4IbaguJ+dafNdwvf4muEOpc/VUQJcTL4CuefblbifEqBwSV6qW8eD9AjLz+oVAZe1Fg+lgwbQNCg/SYedz2Dd7mbwDsToqkYf1k1qTBd20U65YcinOOawsIWSzg4H+xO3TZOc9jnYd4LwZKADPgJXj5ixB1htwRaEt3IJXI4qyx+ygJTPFF6LwfRJyM6EveZivB4eV18mZskYzKBlIw4yi3oB1e4YXUSL7SXcyhGi+0sdNjT/9tALHvtab7hmGh/ppRgENFBUz4AI0kB60sbaV7n4QXvSz0Amy3gH4bnf6VCF4YvzLjE4wqpbWbTJvclbIUi60Tz2v6wVcT+CgmoGBQTyFFuRume9G2MzBBKNdbs5/4LG/mEBs0VHLBLP+x6qjXdDBZj2S8fp/x4SHbDZwz1RX+Md0TCKwf+Z/nnLRbtiCJd8c8qA8cBOkiuoLaXmLoehrM2r9+v1/KRkXTszJcRURnaGZSX6NjcHYdSeV0grDi77HU/ws9EVbAl3EK2YD9T9oKvI95sfhpnVGKSLp0qFha/51 SX0xI+Gf qWHrYAKtQtHfxveiwU9P354WqN4Kyk9iwsl4b9jtRsy+rOGdRH3CJwkAEsGD266/wWzfliC+jQ3dqs1X6Mms9iQkfz4rWv6efEV3FU0+0P5NmxbI1vi5CJ/0A3hHakTze1rZXw5WUJYFb86IeHter/OsovPC+YN7UarGj0e4oQrBRfOMzHZgMYLb99ZGiA9xVbmUp6sFnRkn8P+CustWN2z6MDNOQGPdD6z+9yJ4V35R4JoCOqQJjaVaKr9/S1aG4+/FGFDt8BchGzPpidHYzsaLJXXEjJ+d3NTnu1sELUj4lVSeU7trdqLtLhfQoSTk7MllURJytmjAQnRWk23VidfkQPYBANekr9vDrjyUH2Fw4snVG4tmmeMPs/Y+QSyooHQHFtznVAh8Ni5Za2GlFu2RAhhED+4JoKnZofWfA3YATHwemzjXUgOXOLXpDgu2BDBCmioDn1FNYZqMBxNbu9oqevBXIk4Pqe9XdHc9kXx1q1xBeWJ9ur458MsqPZkmnemfKBz3cnjQ16jlUKmSxmsGwFY62TGa/6WgGOFDId9v10HYKasGzIFBQgj6YUtfTxdYD74pL1ibPkAOvfAZDs6DUXH00UXSX3GWbcu6nQalZSGJ2GvjtgWLn4VhirafB+0txJ38MK1TqwkucmFwLH8aX5+PADjT+LiAI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 29, 2024 at 08:37:23AM +0300, Mike Rapoport wrote: >On Mon, Jul 29, 2024 at 01:47:21AM +0000, Wei Yang wrote: >> Commit 94ff46de4a73 ("memblock: Move late alloc warning down to phys >> alloc") introduce the usage of virt_to_phys(), which is not defined in >> memblock tests. >> >> Define it in mm.h to fix the build error. >> >> Signed-off-by: Wei Yang >> >> --- >> v2: move definition to mm.h >> --- >> tools/include/linux/mm.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tools/include/linux/mm.h b/tools/include/linux/mm.h >> index cad4f2927983..9db45c5d00fc 100644 >> --- a/tools/include/linux/mm.h >> +++ b/tools/include/linux/mm.h >> @@ -20,6 +20,8 @@ >> #define pfn_to_page(pfn) ((void *)((pfn) * PAGE_SIZE)) >> >> #define phys_to_virt phys_to_virt >> +#define virt_to_phys(p) ((unsigned long)p) >> + > >Please don't break #define of phys_to_virt from the static inline >implementation. > I don't touch the definition of phys_to_virt, so you are willing me to adjust it? The macro here will be expanded to code at preprocessing stage. I don't get how static inline would help here. Do I miss something? >And please make virt_to_phys a static inline similarly to phys_to_virt. > >> static inline void *phys_to_virt(unsigned long address) >> { >> return __va(address); >> -- >> 2.34.1 >> > >-- >Sincerely yours, >Mike. -- Wei Yang Help you, Help me