From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0959DC3DA7F for ; Wed, 31 Jul 2024 15:37:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97BA36B0085; Wed, 31 Jul 2024 11:37:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92B926B0088; Wed, 31 Jul 2024 11:37:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F3BE6B0089; Wed, 31 Jul 2024 11:37:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5F8B46B0085 for ; Wed, 31 Jul 2024 11:37:27 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1C7B61C1BCF for ; Wed, 31 Jul 2024 15:37:27 +0000 (UTC) X-FDA: 82400452134.29.C7ECD1A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf01.hostedemail.com (Postfix) with ESMTP id 938914002F for ; Wed, 31 Jul 2024 15:37:24 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tjDYWkLA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fym+rblO; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ODJxQCDH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0xVv1I9u; dmarc=none; spf=pass (imf01.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722440182; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vVlHZeoYX/BfvHEo1VZe4Eq3M2SonCjsjbDkdUEeMMM=; b=qH/ZYpC5quWJ4i/ueSXQ5PLVkxd6uql4KmMChqQCvyKPVMINHboSVWtLacYnYmgEHXCfhb I6QvVmMMkUOwzr4y8uUNH1HQCogL8dL0npldwDwbR/jiNVyxTt47EhlJDlc46Ny6GDpeTf mdsJW7LTA33WR7Fw9u9k8aoOP743OiQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722440182; a=rsa-sha256; cv=none; b=JbwfZVrR5xrJ+zg3SCTbX9cK6RDbsvcegid6tRFjKaTrj6rSTcSgW8/ZskOij9JoBNkByK GM10fX0n++6/QkJEAAezQ1xda4szZ5PMIYmk/VxpSxJ5i/A+kyRqjSR7360vEraWDBUFh0 fyv1a/TRH91qw//qUkBvyiyn7wBy/Qw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tjDYWkLA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fym+rblO; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ODJxQCDH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0xVv1I9u; dmarc=none; spf=pass (imf01.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C50651F6E6; Wed, 31 Jul 2024 15:37:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722440243; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vVlHZeoYX/BfvHEo1VZe4Eq3M2SonCjsjbDkdUEeMMM=; b=tjDYWkLApLTUmv0gYrXMdTzO4J9Z5/K2SatGd1niSlxCUJmZ7yNofYtCx+SgRyWMPfSckE E1qMSN33Kv1qmZVRJB5JGNkNYn7j5BhInu0Y1HKBy6Frw4LzCupH4RVfwlK44v3PnqL8DE 1JcfnPDaZOVC1wpnA+7IbCatvdCVi1k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722440243; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vVlHZeoYX/BfvHEo1VZe4Eq3M2SonCjsjbDkdUEeMMM=; b=fym+rblOxnnzpke4E/xmQeEr1RMq8JTIQL1kYyJXwwi+0ufKcs1YAfcq3j/hIMKd619u7W SMjRa9hE+EpkOnBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722440242; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vVlHZeoYX/BfvHEo1VZe4Eq3M2SonCjsjbDkdUEeMMM=; b=ODJxQCDHIC/rcHtZXRF5BNZkAzq8DlRPF1Uj2+INw3xKFFlckEjV6wrPWl5tJhVye+nkCQ O3rck6T+0VQcSli+JqWnW7JAxSaFBZkGfutMA8djrsx5ZCeZe8ZvTrcvN+TOdEwXJTZ5nB elug8lX8vLnGip6bw8rj9No5VpMkzCU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722440242; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vVlHZeoYX/BfvHEo1VZe4Eq3M2SonCjsjbDkdUEeMMM=; b=0xVv1I9uDcO7HcyGijEH7XwVCALCI9yzXUWVEwvgFkb3k7SEosFG5h9K7268X1zRm54tSY mJIDfUKyi8acYICA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3E1DE1368F; Wed, 31 Jul 2024 15:37:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yQTmDjJaqmZUCgAAD6G6ig (envelope-from ); Wed, 31 Jul 2024 15:37:22 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 1F60FA099C; Wed, 31 Jul 2024 17:37:12 +0200 (CEST) Date: Wed, 31 Jul 2024 17:37:12 +0200 From: Jan Kara To: Christian Brauner Cc: chuck.lever@oracle.com, jack@suse.cz, yangerkun , hughd@google.com, zlang@kernel.org, fdmanana@suse.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, yangerkun@huaweicloud.com, hch@infradead.org, viro@zeniv.linux.org.uk Subject: Re: [PATCH] libfs: fix infinite directory reads for offset dir Message-ID: <20240731153712.hffmznoujzrck2t6@quack3> References: <20240731043835.1828697-1-yangerkun@huawei.com> <20240731-pfeifen-gingen-4f8635e6ffcb@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240731-pfeifen-gingen-4f8635e6ffcb@brauner> X-Spamd-Bar: / X-Rspamd-Action: no action X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 938914002F X-Stat-Signature: ijjzuwxsppu8qh5w3aguecq5oodcj6su X-Rspam-User: X-HE-Tag: 1722440244-66022 X-HE-Meta: U2FsdGVkX1/8WbO/iGurEAMcxDQoWDEbvul4gO4pzZy7nu0oJ0TSHHuwyfOPnSb+k/wbXmU890yuHXEmplbvez24e+x2LxVXnswLPMVwkf04Qi9boSDUra9/dMnsP5agXlq5+uuAuWcbrxvYPuCSwehKgpTj/CdUreL6M0VAfvUqgyz5xJBW8I/l1Sn5A8PCK7VaJ6AsqnOsw4twMNYahBrmp+OoxZK+MrlFlZJyH+gAYJmtyWIi5DCCvw0OxK+weBv9l4mARkK1ik2K7A1zhlL301OhNUctXTGOTJEA7FwYrsoBuGsRH4eDUpJ9rBd4UEF6mbhywlxWVcEm2+E2ZLhJ+xQMzsA/k0ivD3QUr8djonYt9jv5SSDl8wvFqJkn6M1RE4AQvuVuDb4WSUBW8CSGE00um2DfXcuD6nWraTNiaVh+mN2D8OVVLqPLTZFzgsLUZp9wxPzBexP+w72anKJxkkNWhdtQVmggvBfeUEsM4/revK6I+/q0XPlQ8Ti8rp9A43QEtjp2Rg83+TtqvvzT8YX75qqHwomjEURbCDC8wxE1E8cDlqZU+cdLL2CcQGx1OaLZd+5ztICVMlwQhV6fE9XNs3YGTFg4lPqg7sxjw223xTK1ScnKJANFFHmuZM1B/dKKuo3lnnAIN7vMSKF7Pb6pmR9v42i2kUI1hRhPfgiBycIERyeww5qhmWHNOIBoUzZK+vjvZDSdpVUlzJCOprGrr5amDt/kEyFFlAKx7c2mYF4PS6757IaqhxIl5RtHXJFp7CqEha+nrjUaN9YmuV1DJ8R08q+cgRYa8Ji0C8Z+IAOMYe1x7j1hl8okilNbqbwev/vihZD3b30tmpZXHYQ1BvL4EnUBiT1u/InWohjt+IYJd67wN4OrVUzrW3JoKYu3Fd9VfmoG5eN/+L/MkAEE4XZq6APQSADr3XGhrRwwos01+xl/KiU0npEADzfLcj1Jru3piSchNIh ZbKyF9Q9 u4Y4EzkpazaApRlmf7UXrxfD+MIwQFxn0aCmryJMnaBxX2Q6w52xjjgB9W5E2fImUBlezVVFA8wlyzcEwKxOxGWS+/sXxPo5Bg68CkA1p0u/bzzYoLUEtEdOWhM6xG1OJnPJqehb9VDWCKh+VIuzXg6fLN9/bk7E9b/k0yLaT99MKoAlDjbPfYu3LquQ+sYwifpuFonXwRsmCCtBtOixNjO2liTrYdOtv/XQ9ffwbl5zsPt49cV2CPo977Vzqo4bZkRPvY8x25Fd3JNLuGWo+aZ+tkZQ2u1WCgUREgJt5n8s264Ffa821LkWU4y6sLWEzJcgX2UIOg5dU3tNu/NxUAPujeQ6UGwMteoFP3+PJ3CQwahSw9SK99/odMQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 31-07-24 16:16:42, Christian Brauner wrote: > On Wed, 31 Jul 2024 12:38:35 +0800, yangerkun wrote: > > After we switch tmpfs dir operations from simple_dir_operations to > > simple_offset_dir_operations, every rename happened will fill new dentry > > to dest dir's maple tree(&SHMEM_I(inode)->dir_offsets->mt) with a free > > key starting with octx->newx_offset, and then set newx_offset equals to > > free key + 1. This will lead to infinite readdir combine with rename > > happened at the same time, which fail generic/736 in xfstests(detail show > > as below). > > > > [...] > > @Chuck, @Jan I did the requested change directly. Please check! Thanks! Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > > --- > > Applied to the vfs.fixes branch of the vfs/vfs.git tree. > Patches in the vfs.fixes branch should appear in linux-next soon. > > Please report any outstanding bugs that were missed during review in a > new review to the original patch series allowing us to drop it. > > It's encouraged to provide Acked-bys and Reviewed-bys even though the > patch has now been applied. If possible patch trailers will be updated. > > Note that commit hashes shown below are subject to change due to rebase, > trailer updates or similar. If in doubt, please check the listed branch. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git > branch: vfs.fixes > > [1/1] libfs: fix infinite directory reads for offset dir > https://git.kernel.org/vfs/vfs/c/fad90bfe412e > -- Jan Kara SUSE Labs, CR