Re: [PATCH] libfs: fix infinite directory reads for offset dir

[Jan Kara <jack@suse.cz>]

On Wed 31-07-24 16:16:42, Christian Brauner wrote:
> On Wed, 31 Jul 2024 12:38:35 +0800, yangerkun wrote:
> > After we switch tmpfs dir operations from simple_dir_operations to
> > simple_offset_dir_operations, every rename happened will fill new dentry
> > to dest dir's maple tree(&SHMEM_I(inode)->dir_offsets->mt) with a free
> > key starting with octx->newx_offset, and then set newx_offset equals to
> > free key + 1. This will lead to infinite readdir combine with rename
> > happened at the same time, which fail generic/736 in xfstests(detail show
> > as below).
> > 
> > [...]
> 
> @Chuck, @Jan I did the requested change directly. Please check!

Thanks! Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> 
> ---
> 
> Applied to the vfs.fixes branch of the vfs/vfs.git tree.
> Patches in the vfs.fixes branch should appear in linux-next soon.
> 
> Please report any outstanding bugs that were missed during review in a
> new review to the original patch series allowing us to drop it.
> 
> It's encouraged to provide Acked-bys and Reviewed-bys even though the
> patch has now been applied. If possible patch trailers will be updated.
> 
> Note that commit hashes shown below are subject to change due to rebase,
> trailer updates or similar. If in doubt, please check the listed branch.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
> branch: vfs.fixes
> 
> [1/1] libfs: fix infinite directory reads for offset dir
>       https://git.kernel.org/vfs/vfs/c/fad90bfe412e
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR