From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C31CBC3DA64 for ; Wed, 31 Jul 2024 20:28:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 179EE6B007B; Wed, 31 Jul 2024 16:28:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12AA76B0083; Wed, 31 Jul 2024 16:28:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F340C6B0085; Wed, 31 Jul 2024 16:28:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D622B6B007B for ; Wed, 31 Jul 2024 16:28:33 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 372071A03F6 for ; Wed, 31 Jul 2024 20:28:33 +0000 (UTC) X-FDA: 82401185706.19.6E1C900 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf18.hostedemail.com (Postfix) with ESMTP id ED1B11C000E for ; Wed, 31 Jul 2024 20:28:30 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="puEscK9/"; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722457637; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bSRBFxQdGJw2OcGxPXcq8yY5YlpUzow9h8B6jtGxQbA=; b=KNzct3E+RXv8JluN3qxM/nnv/gPgVRcvSP1I6cFltUOKOJ2xeKIzydWPPN+3gX73ZWOAuZ rOvyBBjiNftKjK6XB4KprHrGqvB4Kl6CEeR0xbRdn3yHx0BysDRXvglBbc9w3RStwucaw+ zlFNLEbW8izk7pjSaOqOiys/h6+Vk50= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="puEscK9/"; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722457637; a=rsa-sha256; cv=none; b=7KlZ/gUhitIS2OyyM4e7SgGb4hBKo49KOGv619d2fUH68hZgX7cdsNDGHF/7rUsfgAtXU6 0EEvKR0bDN7trrSthKivzm1Be2QGHjOFF57zOXQZ+EhihnfooRlpv1gneNAb6zZHXF/Z2Z ptVokrutM4fsbSM8UwGalaWwYbxKpDw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C13C1CE13C0; Wed, 31 Jul 2024 20:28:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC61CC116B1; Wed, 31 Jul 2024 20:28:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1722457706; bh=sjfnzrIaOBEDmgDxDGYx/ikjnMnZq3as0W+ndBUgLes=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=puEscK9/cc6dAhH5b46Y1zJJ4ujkuYILWwYuUEymnaYmaStTnpfl8QREXkgGWBlSt PeEIUmnvh00G61c2G8lYsRso6mYFXLFCrMHqvVPKg5+SiNp7mEC9LQTpW04QY7AkcB cUa0QkzxqwVK8W6CBcLOY2o6BTHKbbNWhUHzWyhE= Date: Wed, 31 Jul 2024 13:28:25 -0700 From: Andrew Morton To: Muchun Song Cc: hannes@cmpxchg.org, muchun.song@linux.dev, nphamcs@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , shakeel.butt@linux.dev Subject: Re: [PATCH] mm: list_lru: fix UAF for memory cgroup Message-Id: <20240731132825.1fb29122d35997a425368b32@linux-foundation.org> In-Reply-To: <20240718083607.42068-1-songmuchun@bytedance.com> References: <20240718083607.42068-1-songmuchun@bytedance.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: ED1B11C000E X-Stat-Signature: b78qsofqw6xnpy37j9azuhadkwrk3aep X-Rspam-User: X-HE-Tag: 1722457710-613574 X-HE-Meta: U2FsdGVkX19BmzG1QRlQ7UfDJu8VZfwVlvo1qNHUwrvFCTyMpb8aIIJA3dS5YGHPbdtEY9VnJADMSwowSTxbUCNuuWwfPAO5uYPOmn1HeNsGVyTLUrDG5Gp7bFinXCM7WHSHslbw93pyAbnLczPdRn+0jG8r1a4vzIXWTBo0KKZequ2XYPYeM1MLGKGrmezEuLC5Y0Fx/0grrNhTVXK5aZPoDke0cSUuIaWfIYbYZ3ycKKmMavmQqY34uHKdZv5AZPVzwVC8PMS0wedoMr7Kyp37kpFGyXi+MtmLA8LaMGWauHBEs9MyjKozGc57rRC3znWhfj0NkJxn52t1FyY2TbzwLG4sDb8T+e8f1qmJ8vY9yW6NxlR9rCwYdblvqgA/BLb3BTGi/bCuW/IdN43tAMkLAnfzgM+8W/Uio5JUzWYwprAGzfHjBsgmkqsj+NQFbDa5Jx8l7CXWw4mOSYOZNnfV8IY+d9veWzKAhhk8fjHJxvlGtNmzPLk5fIn8oRDfDUMBGRhIE+206boPpCnchRsD0HOANxD6gB5mQM91ynK5EmiVMs1VsRFB9jTJ4mNBCINyoZWm+aXeAProifrr2ZK4Ot8CFfMKqrvBaShgfnaaGpoShV5UIbk9vjPaxyM6qF2Pgs/gBgcJU2BaW2OODQFKTskPHIOrs/j18hP8e8xk0juX6OwOQYyzP7Cjb6zd5UarvNU5dmbuk1WLaGtHhOeN9V/26/MRXzahvPbGtkyZeMHIiQWkoOEjj84rHuHTJCRvayLKGKzVtq3igEc1OgYw+FsRAX2S41ntGSb9GoBO8ULqSdurdCi+Z3Ld7WN+auIKQ3Yhslj7ysdTAkUELrjiZG3TIL+1eAN4lY6YSCCFRzsMpQ/+lV7vp6tqozoNaYXrXsZLYH3OoMGI6+lIGEkLpjloAZK39Kay2xSbKt5sehswoM1fpZ0vWlDbc6dFPjrk3z8D8YeZ0A8lxqv XjR1oPPk iVZrEQCRBTUohWi7/N0sEMZv6BCZ8Kf3pi1PjVLRqRV+twN8ioyoy+2+TeWwggYWRvgz4SqvmFFWUfQ3pm932TQ20neInX1mYft9pAVBZ1wIXt2aGfvX7yvmepyqwmJIH3fP2r4kykZcQ1JuuRWD4OJcPbwwkwrm1hsjq3lOquoIAYoEVjgmXVovm34mIM2cTQm5cm42MLuMy1oZFm9x3wH9XLBvNH7fPxCWqmFgaIBhYW+Lg9bXVBGde6Q0XFmG9RtodQSx6331dtjSpnr17TDbIxYq08dzy2xX5uNkM2T2Pz92TVGJeUSxw45dUd4juDgtph/9DBWBrf2Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 18 Jul 2024 16:36:07 +0800 Muchun Song wrote: > The mem_cgroup_from_slab_obj() is supposed to be called under rcu > lock or cgroup_mutex or others which could prevent returned memcg > from being freed. Fix it by adding missing rcu read lock. > Well I grabbed this, but the review led me to expect a v2. Should it have cc:stable?