From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DDA5C3DA49 for ; Wed, 31 Jul 2024 02:16:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1054E6B0088; Tue, 30 Jul 2024 22:16:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B6366B0089; Tue, 30 Jul 2024 22:16:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBFFD6B008A; Tue, 30 Jul 2024 22:16:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CD1556B0088 for ; Tue, 30 Jul 2024 22:16:28 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 55E211201AE for ; Wed, 31 Jul 2024 02:16:28 +0000 (UTC) X-FDA: 82398433656.13.CBD5412 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf12.hostedemail.com (Postfix) with ESMTP id 67E1F40018 for ; Wed, 31 Jul 2024 02:16:26 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=n0fLroia; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf12.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722392145; a=rsa-sha256; cv=none; b=6hGP83yzCkRFkUB80xLKpRThdjP/wnmwwVFmNBEXcK48Boc/XUrkqvVDcKkqo2l/kGEymW 8RUKR0aKiU73ZWwbhHjBoHvom9gjvZET1JHfBv130TWSokhCy4zZukfOt5jfCrgOuU8PWc 6Flrm5iNgJRvHhEGuPkF6MwgZPeJKHQ= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=n0fLroia; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf12.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722392145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pm24eBOf5RouWLkBrgSLmesZOwTzNnb44rrW9Pz95Ps=; b=vCjftggC8x//28j9wpUS0oTi9GX1n6VaOMn/XzGcezy+9SEeBEuZW2aAYMQBBHbiKuIIF6 GKxVIScZ8Hy26BiT4XHsrCFlrUC6/r8tNmnOaXHovtiwmCKRDZcR6ko5im27Sk7cb0OAJY PlP/FeIdz53NDSeLly0HogUdc7V0lbo= Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-7104f939aaaso49839b3a.1 for ; Tue, 30 Jul 2024 19:16:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1722392185; x=1722996985; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pm24eBOf5RouWLkBrgSLmesZOwTzNnb44rrW9Pz95Ps=; b=n0fLroiaXL9Vp8IGijZEZitmy2TsmVo8hB0y6gjYF2e+yl53oZkrYTpMuJ39fyX1sC TBmxn+6yVyrgnowLBCGhtFAk5hAUd19nANpyVlavZrId47bI5rw8uPpIvh21Wu1rOLXA 2zF9iXu/XAR8V70otAS4SAqckI//5hJ0v4eNM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722392185; x=1722996985; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pm24eBOf5RouWLkBrgSLmesZOwTzNnb44rrW9Pz95Ps=; b=jcs7KmXRq3LA/N+LN+jUdUfa4Ffkt0njTeApNIdHiIx3bwOBWZ5wuENF1EP9J8jIUs pyHHkNyufezGO8ZbNqTxp/Mj8hvBQChoiE0jkYaOgeKXpSr7eVc2w+Oj82SrJRSm8lJG L1yozW4L5TogFBnMSVGNwnytO17oDh/dZsfgpd+5bTrRq29fEmxC1mgECX2Du7Pt32KT 2SjohCXdZddq19JFJ/CFJUZWyQCgA1pQugy0n0oMFcWxmpUHEpzR9MF5/gaKDFaRNXYM omZ5YgVePsImwX03R9etHOx9hRdYxp7yuWNIDlTd5AwaAF7rLJooSNIoeYInbPvAfdyu UIkA== X-Forwarded-Encrypted: i=1; AJvYcCUh/9ZCP7lh81m2Y+BbSFoh9974JEqhrJv+wLZKv1f2U3CeHYjXcjQ8oBUCrOrehTJtKy4JSIvs79nhy3kobgGcm28= X-Gm-Message-State: AOJu0YyLjdELjQySSZCg8Ruvzr59SPHXE1dLBtHOKcb2lPsygmT1I4Ad fhoqQM0yb+AR/OnmdqCNHcD+yOcCoujNtLg+x66xolXPis/K/Xxbn9dCLqlLTA== X-Google-Smtp-Source: AGHT+IHvRHiupRzDSjcjS5k2okMhnlosHol4XJ/6pHV7OZKZTQwMTSSIaRFUYw18t2u9L3IpHM3MjQ== X-Received: by 2002:a05:6a00:4fd2:b0:70b:3175:1f4f with SMTP id d2e1a72fcca58-70ecea40e8amr11579240b3a.16.1722392184908; Tue, 30 Jul 2024 19:16:24 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:a51d:b844:f0ff:3c91]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead874619sm9051234b3a.164.2024.07.30.19.16.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jul 2024 19:16:24 -0700 (PDT) Date: Wed, 31 Jul 2024 11:16:19 +0900 From: Sergey Senozhatsky To: Alex Shi Cc: Sergey Senozhatsky , alexs@kernel.org, Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, david@redhat.com, 42.hyeyoo@gmail.com, Yosry Ahmed , nphamcs@gmail.com Subject: Re: [PATCH v4 22/22] mm/zsmalloc: update comments for page->zpdesc changes Message-ID: <20240731021619.GD16599@google.com> References: <20240729112534.3416707-1-alexs@kernel.org> <20240729112534.3416707-23-alexs@kernel.org> <20240730093726.GB16599@google.com> <8fc7939b-416a-4328-9df2-488f17783543@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8fc7939b-416a-4328-9df2-488f17783543@gmail.com> X-Rspamd-Queue-Id: 67E1F40018 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 8drdgi8ioxwhu7r6gzi5ahoty1t9g3f8 X-HE-Tag: 1722392186-65947 X-HE-Meta: U2FsdGVkX1/ZAJzBPFEkKLC2xEmCaiYQ+pw6pepo6SGB1caDcctGhyIGZDWifPnRo007DfFN3LU80+iidLNrZ2jhydLzYM8i0DiEVt76Pub6OZ+mvHbKsmgzKCA0g8/bfT7XvAeHOO3qmWfVd9L2PbCJQtpVMciHi6263aL545XbBmBxjURN7TbF6rghnvnKpvfm/qkozcLqtYAw/PZ8tAR1HeVXT45swRGScO6KnOolsCtGZ/CO5MSZF2iUD2gz0I89pFw7xKe0nbd3nfzvk06ln0FxX9l7dbvBrzppfa4Ujp/hobnWcLtBMhciRzZydv+rVXpk6gk1NnDJvn9PQgoWzwhtV8Zi0yFiH+dfHD/GQgXm0Vycovluj65rPBPf9RR8lvoa9VpbDj0DEO5Aux505A5fMVA11ThU3kksV8SBEqQ0el0JpQlhyXy5PPwndMOZwl17asPc9J0WlZg2ojqvEbTzDE7ylpOpbXMYWWsVCoRlETo/vrYOfkGHj2nbODj+U4Vd+JDZxFIBczPXagM6H/F5leJaT8GJB7e3C+L0/W4WmPw0P6bBzV+7Jp93Ew6DGwq7cNj7XqI8cWoXupa6ol3s96tsCTk+ifSrYmO79SS9qGCeJUZHjIlDRzyEmgPx8rtTSWWsyE4JROcrjfGPJ1R4xzEmxhOEgb68DAciQ6f3vPle1wMN8WEENs3CecvlnVZCqtQlGv0hFTS2pDmtpIzWejrzKJpabjrM9tPH6KW2pPcMe0IcVjgOZDcOG4NW+3+GNB72zmiQKYjQbJFJ0JwK870fJN8EUlCAf8XiEREs/krU8uHFb+ENcDAiyuAOgxgVb2o2t1CD+VUM6E6iGFyhk9eEHK5y9PqO6m9r3wmh5Wfp1p8ueNaM+1PBp6QutT+xw7erN3oVus9B0eXchGKFGKhcR/Q6Vn+3+oJWxqIBuNkCaKU2ExeNIAnpjvKTNc5qtQpR5GvbAxX eCRB9tFV MJ4XZmwg/xO8ILIISKdJEeo81hplrOvUYa1rdyUuyf8UAu+6pHn3J/3ip8ChcbUFV87Vo/UnpIAaO42RMOy9YyGjMI0tdxzu1pXOxcAdfoUWZnb43+vLCeE7D0cx6wvshy8i9k1U91qTu14V/mwxikpKKVVT14/ZZS6wS2j5FUD/gEtKcaQeQmIeYPii0nRwxXawv1WqH5DJfwzWoYVi4cMbj+t9R5s9zpX+qz2+yuApEmTb65STItiP8uK6X6GRMFPr2A/mC24izZv6d+ukf/cyIncxgyyVfgqVYUtf4I18yrXX5057nDXZKro5Wa14TOfYCV2FjNvOGWa3bIOiayD8dzpOdB9HcqGojAQVRSLC3utNEsqDh8Jas8RCcTa1fDGu9+x2343VTsW0cJYxn7Y3oj0tSm9kvGvGph9QOQW7A7wiQIDCephW7o1+W4TnqrYoQTEv2i/dE2zoitRCw9RyA6A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/07/30 19:45), Alex Shi wrote: > On 7/30/24 5:37 PM, Sergey Senozhatsky wrote: > > On (24/07/29 19:25), alexs@kernel.org wrote: > >> > >> From: Alex Shi > >> > > > > Usually some simple commit message is still expected. > > Uh, my fault. Just forgive this part, is the following log fine? > > After the page to zpdesc conversion, there still left few comments or > function named with page not zpdesc, let's update the comments and > rename function create_page_chain() as create_zpdesc_chain(). A bit of a different thing, still documentation related tho: do we want to do something about comments that mention page_lock in zsmalloc.c?