From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12241C3DA64 for ; Wed, 31 Jul 2024 14:16:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89E086B0082; Wed, 31 Jul 2024 10:16:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84E766B0083; Wed, 31 Jul 2024 10:16:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 716426B0089; Wed, 31 Jul 2024 10:16:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5396B6B0082 for ; Wed, 31 Jul 2024 10:16:58 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C0853402A5 for ; Wed, 31 Jul 2024 14:16:57 +0000 (UTC) X-FDA: 82400249274.27.5136298 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf19.hostedemail.com (Postfix) with ESMTP id 961CE1A001B for ; Wed, 31 Jul 2024 14:16:55 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qAFWlT38; spf=pass (imf19.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722435360; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nb+4y4QToanV+gfdV5wN1BJud+UBQfSmMiysfU8CUdc=; b=tKPx9QagvIs1QSjuQvEFyVWzceAStIIeYGkWDrBV08YLyEoWk9o8u6uGfi8xNNG/sf2XIp kK5+b32VabrvbH5zwR3utncSYBenL2i5qKif8vcOfeXFZFuvzxSwSWsNOtfrL1eaKnfH+l RR6xmSPXn+rOmFLVOar7wEZnfPt5H3I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722435360; a=rsa-sha256; cv=none; b=JpIGbeip7Ypn0mEtxVaFklGshBZikSxMVDvT1/CcwsP0W2Zos6QnYgCIbtgBumCuRQWBpT EfRNnJjv5qAf6UR3Bl/sc0KwMJFU1iu9XYMmsyqwgVMX6V2l7IbIzzk1/g6WZOWftOPx87 3bnr2Dnn+1JlH24FA7cpcuRgSPeGBDw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qAFWlT38; spf=pass (imf19.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 34EB8CE16B5; Wed, 31 Jul 2024 14:16:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F1DAC116B1; Wed, 31 Jul 2024 14:16:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722435411; bh=DU6S62z+u1Pn9/P/RJpE2/No5dTMVYRqd+P4mbPQmcU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qAFWlT38h0aoE8K+kg8hQgeZShue2N2s3C1trQ4Eg4BHb6+e6n2XDDFTA5ujxdnYU jZwuZJT948BJN409ctKPiQGJhBtxTU75DaFzLcOte3zYs3Kk4OIava/RbGpTfYcbZY eTLoBki+4fTFZCbbsR2ju+3rMRDBWGEPNtO6dSDBwJyIuc4dBGS9klAsU1QWnFUtR0 6p7osFEb//+DgZ1C5U0/sVv7MRuE0ZExbDiGsLKRr+0NsEHFB6+yp1+OvLusPHA0v/ FjCE6b7UWQTYVbqFxysHPOL8gmhkPMmtUux+vtoP1TFys8EUWcOgkCYRtUKyTkcupV zCjGIhzwI2L+Q== From: Christian Brauner To: chuck.lever@oracle.com, jack@suse.cz, yangerkun Cc: Christian Brauner , hughd@google.com, zlang@kernel.org, fdmanana@suse.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, yangerkun@huaweicloud.com, hch@infradead.org, viro@zeniv.linux.org.uk Subject: Re: [PATCH] libfs: fix infinite directory reads for offset dir Date: Wed, 31 Jul 2024 16:16:42 +0200 Message-ID: <20240731-pfeifen-gingen-4f8635e6ffcb@brauner> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240731043835.1828697-1-yangerkun@huawei.com> References: <20240731043835.1828697-1-yangerkun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1364; i=brauner@kernel.org; h=from:subject:message-id; bh=DU6S62z+u1Pn9/P/RJpE2/No5dTMVYRqd+P4mbPQmcU=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaStcvf2nVW3JPtUpgv7Hff7u2b7Cri/Fjtp63t7tbvup prlZ7LvdZSyMIhxMciKKbI4tJuEyy3nqdhslKkBM4eVCWQIAxenAEzkii7DX1mz8JCwm7f4TuyU 0l57mGFmWfXnjc9/rbv659ku/T1L1vMzMhxQuMa3M+z8j6vM1j+t/j5Q1uV7XPnl9G8Trx7W6iM 5K3kB X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Stat-Signature: dy9hnz36uj5hqddakn4wymra5bek9uoi X-Rspamd-Queue-Id: 961CE1A001B X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1722435415-888239 X-HE-Meta: U2FsdGVkX19jurGhrYxm+XTZ2mLX3TuhvLbUP8/HHuvlvICWnUBF3e5EVrdA7jDYC7kQrO5qOHYnB9xGugq8KUNDpUIH0qXLnUqeJH+GnqACWONJWWrbfu1dBtVl4txbEmTiyFRze49Lmn84Y+gn1pEDuRfpNeUUyTQPF/uI4g0iDEcrnYizjsGjQYKCu2KoqrRJeW3T7laFWLWDRKw/zZ0rpNEzb28AiSvdGKyE5kWl3MX/2k3uHEB5h8zWCWdLUcU0QBdkzfni2LJO43OhyeS00Q6ZyFNbE3L+nNxoOi3Z2R2Ag7a+cwvE8AeZoQjuK4LL9r0AloPfia50HdUv4/oaXYhyCpw8r+HubgsOef2/LuTScdfOJMe/6wGgvZVf3LPLX6iv9jh300jGROVxQIOGnSk3z2wC7067Zk/x5y+fdFYgkkPCS+p55tDSqdnNgRAQpkL0fj6zO/RY0UPe1ac52s0dYX/OVdfBY/rKpHyoTnYF2hoiMTDaxepEcYjwBxYxVeyTPyv5hgr525xT7MPsRGeQwcp+ZFYYQfiho35/0qZXWdoM+pdlyunwo2FF78ZOSjpkDLlzLVHvgrgM/kFeX+wzyVhFH+WaUUTqtZtUh8H4Beus5FsPcgVq7i2mnZEE9TY8n5Gs0bGKxcq3kTpknLUYE3Kn7P/PgI/ViVEO9n1oucMUV+pxjujp1wj8q0nmHkeIeqdmTR+V/asJ1/kJdpqWRmSli7jKaYV3snipJBAHBJwLEIuXJ9q4BncSITYvw0gzhIFZiVCeBZ9+WJ/jke/X+VQQYmSzwOcohdBNkZb1WjgFShaLOe08D6Fx703xpE3lJJgThwoMe3jLXP/hWTV288vM07qzfIFB1lNN/W8nR7JdgZJ1qG4o3tSptE8oAx+uPrs1xPz9nihylG0l055yDoXTF5So1EaiG86fsWTGGyxqsR1O4aIueSDLY7URkVw8q/9FN3c8kxo c/j6ij4L 4ly3j7NIvQjQyYwstj9GBqIq/5+EWvMMCXdywOOL8NyhRsJ+XyH1WIKP38zFV5VVmf/pkwuw9SPb8Gnd1qsvOyiIXD3OO300lw+PWMU2+zlogIpKWYRMeYh/eoQdlzq2vTQxEYcdaBPWki9EvJcbUWJGKPGdCsoRRh714bW1j1qMWIyQHTTac/bN/lURFCJEkHBh7QVnMKWRRznE7Tcix6e6j64VgAjwlGLWXPstPdLl+sqvbakmwrlPzf5EyNiKALSGwkh594Yc06zpFXaAtaJngV95JhleCY5vt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 31 Jul 2024 12:38:35 +0800, yangerkun wrote: > After we switch tmpfs dir operations from simple_dir_operations to > simple_offset_dir_operations, every rename happened will fill new dentry > to dest dir's maple tree(&SHMEM_I(inode)->dir_offsets->mt) with a free > key starting with octx->newx_offset, and then set newx_offset equals to > free key + 1. This will lead to infinite readdir combine with rename > happened at the same time, which fail generic/736 in xfstests(detail show > as below). > > [...] @Chuck, @Jan I did the requested change directly. Please check! --- Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes [1/1] libfs: fix infinite directory reads for offset dir https://git.kernel.org/vfs/vfs/c/fad90bfe412e