From: Christian Brauner <brauner@kernel.org>
To: chuck.lever@oracle.com, jack@suse.cz, yangerkun <yangerkun@huawei.com>
Cc: Christian Brauner <brauner@kernel.org>,
hughd@google.com, zlang@kernel.org, fdmanana@suse.com,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
yangerkun@huaweicloud.com, hch@infradead.org,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH] libfs: fix infinite directory reads for offset dir
Date: Wed, 31 Jul 2024 16:16:42 +0200 [thread overview]
Message-ID: <20240731-pfeifen-gingen-4f8635e6ffcb@brauner> (raw)
In-Reply-To: <20240731043835.1828697-1-yangerkun@huawei.com>
On Wed, 31 Jul 2024 12:38:35 +0800, yangerkun wrote:
> After we switch tmpfs dir operations from simple_dir_operations to
> simple_offset_dir_operations, every rename happened will fill new dentry
> to dest dir's maple tree(&SHMEM_I(inode)->dir_offsets->mt) with a free
> key starting with octx->newx_offset, and then set newx_offset equals to
> free key + 1. This will lead to infinite readdir combine with rename
> happened at the same time, which fail generic/736 in xfstests(detail show
> as below).
>
> [...]
@Chuck, @Jan I did the requested change directly. Please check!
---
Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes
[1/1] libfs: fix infinite directory reads for offset dir
https://git.kernel.org/vfs/vfs/c/fad90bfe412e
next prev parent reply other threads:[~2024-07-31 14:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 4:38 yangerkun
2024-07-31 11:51 ` Jan Kara
2024-07-31 12:51 ` yangerkun
2024-07-31 13:04 ` Jan Kara
2024-07-31 13:10 ` Filipe Manana
2024-08-01 3:15 ` yangerkun
2024-07-31 13:44 ` Chuck Lever
2024-07-31 14:16 ` Christian Brauner [this message]
2024-07-31 15:37 ` Jan Kara
2024-08-01 3:32 ` yangerkun
2024-08-01 13:30 ` Jan Kara
2024-08-01 13:38 ` yangerkun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731-pfeifen-gingen-4f8635e6ffcb@brauner \
--to=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=fdmanana@suse.com \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yangerkun@huawei.com \
--cc=yangerkun@huaweicloud.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox