From: Nhat Pham <nphamcs@gmail.com>
To: akpm@linux-foundation.org
Cc: hannes@cmpxchg.org, yosryahmed@google.com,
shakeel.butt@linux.dev, linux-mm@kvack.org, kernel-team@meta.com,
linux-kernel@vger.kernel.org, flintglass@gmail.com,
chengming.zhou@linux.dev
Subject: [PATCH v2 1/2] zswap: implement a second chance algorithm for dynamic zswap shrinker (fix)
Date: Tue, 30 Jul 2024 15:47:16 -0700 [thread overview]
Message-ID: <20240730224716.2392068-1-nphamcs@gmail.com> (raw)
In-Reply-To: <20240730222707.2324536-2-nphamcs@gmail.com>
I put the referenced bit documentation in the wrong order. Fix this.
Signed-off-by: Nhat Pham <nphamcs@gmail.com>
---
mm/zswap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/zswap.c b/mm/zswap.c
index f4e001c9e7e0..f7f6bbb400c4 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -184,13 +184,13 @@ static struct shrinker *zswap_shrinker;
* page within zswap.
*
* swpentry - associated swap entry, the offset indexes into the red-black tree
+ * length - the length in bytes of the compressed page data. Needed during
+ * decompression. For a same value filled page length is 0, and both
+ * pool and lru are invalid and must be ignored.
* referenced - true if the entry recently entered the zswap pool. Unset by the
* dynamic shrinker. The entry is only reclaimed by the dynamic
* shrinker if referenced is unset. See comments in the shrinker
* section for context.
- * length - the length in bytes of the compressed page data. Needed during
- * decompression. For a same value filled page length is 0, and both
- * pool and lru are invalid and must be ignored.
* pool - the zswap_pool the entry's data is in
* handle - zpool allocation handle that stores the compressed page data
* value - value of the same-value filled pages which have same content
--
2.43.0
next prev parent reply other threads:[~2024-07-30 22:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 22:27 [PATCH v2 0/2] improving dynamic zswap shrinker protection scheme Nhat Pham
2024-07-30 22:27 ` [PATCH v2 1/2] zswap: implement a second chance algorithm for dynamic zswap shrinker Nhat Pham
2024-07-30 22:47 ` Nhat Pham [this message]
2024-08-01 19:57 ` Yosry Ahmed
2024-08-05 23:11 ` Nhat Pham
2024-08-05 23:58 ` Yosry Ahmed
2024-07-30 22:27 ` [PATCH v2 2/2] zswap: increment swapin count for non-pivot swapped in pages Nhat Pham
2024-08-01 20:02 ` Yosry Ahmed
2024-08-02 23:46 ` Nhat Pham
2024-08-03 3:22 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730224716.2392068-1-nphamcs@gmail.com \
--to=nphamcs@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=flintglass@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shakeel.butt@linux.dev \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox