From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 561A2C3DA49 for ; Tue, 30 Jul 2024 21:20:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E56C76B0095; Tue, 30 Jul 2024 17:20:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E06776B0098; Tue, 30 Jul 2024 17:20:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF4E46B0099; Tue, 30 Jul 2024 17:20:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AF9986B0095 for ; Tue, 30 Jul 2024 17:20:00 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 636D780465 for ; Tue, 30 Jul 2024 21:20:00 +0000 (UTC) X-FDA: 82397686560.12.627B2BA Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf21.hostedemail.com (Postfix) with ESMTP id 23D201C0004 for ; Tue, 30 Jul 2024 21:19:57 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="0mBU/RFJ"; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722374344; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xv2lZNytY13uwTLJru+8qyQXdAzshxDniY0T1yzzaO8=; b=ZBccB+UuhyldnA3wR426Z6M34giByOxBraWvYlEcsYcf6EWw93Xv/WcjdpfdOfWt4kVSfD AAD1pFOuAG9uX4y8G/w0VC5MrV2ETOWLlgDYWOvBZnX3jYoaL/tqQcecuOptzYi3pP2N9h +SNJaJkdzKHEOJ2h3x5sdRB+VkEnxsI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722374344; a=rsa-sha256; cv=none; b=cD7OIpB68A/6Eocf7+Pp5lVaQuBXbRmAWrCnBNieGPr6oGaO2lY8/jxRX13UmRvtjEDC5d yHXLRgpsGnEkvKLY2Vc1wPHp7u9v7uIp/2sXhvIZTUAnxB20l5rPMM/oXNutvvzGXKS+Vy Tm1NRPwcLsgQieKnN/IdWOy09hwpPys= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="0mBU/RFJ"; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 274B5CE11E9; Tue, 30 Jul 2024 21:19:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 315E3C4AF0E; Tue, 30 Jul 2024 21:19:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1722374394; bh=VIL8V4Dxo0yjcmnSwRFlMLvzimF70V5iQDwIq7P/EeM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0mBU/RFJFGrNITFEv4Da4/QOn31OgQpT+2B4njf/V4CIb6q3RXZkXEOG0Oga6uf4I IPmUzKEZ0EF5v6jieCyuEbZSARliOBzQ+v3XPwcbxJAbFbxanJDwTKNReGHAqWrNYO FM/JMa+u0RPQpr3PGoCbcr/5I52Chg8yfzS8tUSw= Date: Tue, 30 Jul 2024 14:19:53 -0700 From: Andrew Morton To: Danilo Krummrich Cc: urezki@gmail.com, hch@infradead.org, vbabka@suse.cz, mhocko@suse.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/4] mm: vrealloc: properly document __GFP_ZERO behavior Message-Id: <20240730141953.a30fa50c0ba060fe0a765730@linux-foundation.org> In-Reply-To: <20240730185049.6244-4-dakr@kernel.org> References: <20240730185049.6244-1-dakr@kernel.org> <20240730185049.6244-4-dakr@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 23D201C0004 X-Stat-Signature: 3c1ax96p63a7udw4eiz89pdxorkdo6b9 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722374397-698054 X-HE-Meta: U2FsdGVkX1+lTesXH23Gl1stc5d4Q/aZEdnB6kuBlHRJ5N1UqFoQ8VpXra+AoUh45EZcPFufqFCgNBSiQevw7k01V9fthRGFdBlNz4mzRHe9kzID9WJg05zdhRwUfebYv3d09zlRDRYZwjVY+NCCEQGCcMLkdImtcXrac6tBrBrOG2DXdWUWzJZuJ79pxhYYL60UbPorC5l8jNr+lCWnRG6NjEmwNQOdqff/oHn4MfSKlCzGstKs4fo91hABVQqVgUiVMx/YeC8cteXY3HSLm2NS2zjS4NxMyNUpbwWosGPgpkh7SsljSeyUFrHxD1BW9Y0Y67YYcsVkMsHqxCTZtaQgVD7n4aJptHODxv/HS2Gwq4iBaJ2recuyyeByi5nqt0+ag+tGeiL0R6rPqg78HWpH00Cd1pWgPkjmdInmx4MRRKLBzvCgkjGYecJvvvbyOoXHzvhBoAPNEX1oUzLr8qaK1JV9sjRnt+dnfngBE2cIi4jqeqix76Qsq4MhtMmbFS8F9uGxjfJ/UCMEBlcpjEGDs16OfBf+aWuhaWMw4ODKOe8QsnElzpE2KjjQLKknqFf3N/to+6S112vGn2Zkb0cZmVj883ZG+1kHADOnxHNwVZQON8vP1PNIrzy0T5tiBGVh+gyr5BH6xGU04PelJm7BqU20Yic2IYDGGvzi3HxR6lWYmycd421cCftEnCnIUFD1hCWcmWNccd/rlZ1UFse3rJuF0K95jKX2DCllZC1xFCdL8+Ep3REWVUe4eldMpZX29tfkJxWoEUBUQ/veF2Ahia6pAdts7ViBas7XedffViQ2Ufs1GaUcG9mYGvS2LJKpv59JwjlTHVEgxShKR+lXZVpYJvVIXy/qrYIBJq394rnXiNEhnhGCiXup4e9Hu5eAEqVqwL01iANGU6lLX1oXM/+B2BQDilvG6tblzQvqg6IEW5nOcqOKIpshYD4hxNStZLnEiuzxCSFHx72 s1VzjSD0 io3EoCAv4G/CggTPeNcgMD6C25+zEP9nfQtVqJX4wdKbdLXrL5rH9cIx8iETqlBca1a+IV36tE4E8PW2UnfJyH1V0m8zBvrTelBKiRnSPQIfvr5CzXMbCMGMAB3yxa5SQZy/7wKKWr0vk4WBvNwvTHNfJ1rueGhMuomUVBG21r3AaE76dPhxIAfnFKYxVPMaLPhAtMJzvt9vbDrhucP8MsdKj08xf3tTmsdyfTR+9KMmxAnukQ+rFudILuAYsOcqFV0sYlZUAqDIdfBYyAieP2y538NgS/4zRGVoTlRjicmFT+fgRzxt05eqkkYIIMRua4GhkU4a1ydjVLraWsCNTrmlP8pkEqQKUN1LG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 30 Jul 2024 20:49:43 +0200 Danilo Krummrich wrote: > Properly document that if __GFP_ZERO logic is requested, callers must > ensure that, starting with the initial memory allocation, every > subsequent call to this API for the same memory allocation is flagged > with __GFP_ZERO. Otherwise, it is possible that __GFP_ZERO is not fully > honored by this API. I appear to have just seen this, in a separate mailing. Please, slow down. We have two months. Await reviewer feedback, spend time over those changelogs, value clarity and accuracy and completeness over hastiness. The only reason for rushing things is if a patch is disrupting ongoing testing of the linux-next tree.