From: Andrew Morton <akpm@linux-foundation.org>
To: Danilo Krummrich <dakr@kernel.org>
Cc: urezki@gmail.com, hch@infradead.org, vbabka@suse.cz,
mhocko@suse.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 3/4] mm: vrealloc: properly document __GFP_ZERO behavior
Date: Tue, 30 Jul 2024 14:19:53 -0700 [thread overview]
Message-ID: <20240730141953.a30fa50c0ba060fe0a765730@linux-foundation.org> (raw)
In-Reply-To: <20240730185049.6244-4-dakr@kernel.org>
On Tue, 30 Jul 2024 20:49:43 +0200 Danilo Krummrich <dakr@kernel.org> wrote:
> Properly document that if __GFP_ZERO logic is requested, callers must
> ensure that, starting with the initial memory allocation, every
> subsequent call to this API for the same memory allocation is flagged
> with __GFP_ZERO. Otherwise, it is possible that __GFP_ZERO is not fully
> honored by this API.
I appear to have just seen this, in a separate mailing.
Please, slow down. We have two months. Await reviewer feedback, spend
time over those changelogs, value clarity and accuracy and completeness
over hastiness. The only reason for rushing things is if a patch is
disrupting ongoing testing of the linux-next tree.
next prev parent reply other threads:[~2024-07-30 21:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 18:49 [PATCH 0/4] (k)vrealloc (__GFP_ZERO) fixes Danilo Krummrich
2024-07-30 18:49 ` [PATCH 1/4] mm: kvrealloc: disable KASAN when switching to vmalloc Danilo Krummrich
2024-07-30 21:15 ` Andrew Morton
2024-07-30 22:47 ` Danilo Krummrich
2024-07-30 18:49 ` [PATCH 2/4] mm: vrealloc: consider spare memory for __GFP_ZERO Danilo Krummrich
2024-07-30 21:15 ` Andrew Morton
2024-07-30 18:49 ` [PATCH 3/4] mm: vrealloc: properly document __GFP_ZERO behavior Danilo Krummrich
2024-07-30 21:19 ` Andrew Morton [this message]
2024-07-30 22:43 ` Danilo Krummrich
2024-07-31 14:43 ` Vlastimil Babka
2024-07-31 15:10 ` Danilo Krummrich
2024-07-30 18:49 ` [PATCH 4/4] mm: kvrealloc: " Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730141953.a30fa50c0ba060fe0a765730@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dakr@kernel.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox