From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BACEC3DA49 for ; Tue, 30 Jul 2024 13:17:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B19016B0085; Tue, 30 Jul 2024 09:17:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC87C6B0089; Tue, 30 Jul 2024 09:17:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91C196B008C; Tue, 30 Jul 2024 09:17:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 736FE6B0085 for ; Tue, 30 Jul 2024 09:17:12 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 22A08A02D9 for ; Tue, 30 Jul 2024 13:17:12 +0000 (UTC) X-FDA: 82396469904.01.345E883 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf24.hostedemail.com (Postfix) with ESMTP id F149818000C for ; Tue, 30 Jul 2024 13:17:08 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b="SFbNY/iz"; spf=pass (imf24.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722345374; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3mmWlxNZdjshKUX8r4jOpJ3VKzvjNoDxxlHvf6e8xD8=; b=lvpWH6wkXHi8IykXlB4aJ0tJzOQ87K+L+OkxZGDGa/Ro9NIJ5EJOuzHxy7iXSh66iXrs8j WJ0DLatCsLGuOZRUcMAHLFMUA70bDFjsXSYPh9XtjoKsUkV2tY3IN401f0HLcs/RcP296P FQIzgL8EJUSPpgRtJeaJqojWGNlZnao= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722345374; a=rsa-sha256; cv=none; b=r3D7cGs1BfqGmLeIfQroC+S8kZKhS4PGcz0pqyuOV+DLOU82U1jjka/LMrfHVLiFeKZ2Wf Rugnk+GM6eDxlNN3KC5n7sofojeVa5rV/yBpBglhOZxuYCA+BwRq9bWwWL/A3GQR+9Sh2s +QGZuf7blissyPij5dapIpkfw5nHYuo= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b="SFbNY/iz"; spf=pass (imf24.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id A4B1940E01CD; Tue, 30 Jul 2024 13:17:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id t4KCJeA0thJX; Tue, 30 Jul 2024 13:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1722345421; bh=3mmWlxNZdjshKUX8r4jOpJ3VKzvjNoDxxlHvf6e8xD8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SFbNY/iz5BcDMeQbxp+X3vfPiEdb2t4PxqUSRoXozRWhAmaBtlRDGuE08MO8YNiHd 0kWk3d4kQ/jr9kIeS6dQJXMe5sWFb8iuXKz0+Wj0F9/iv63K5PmspTFI8gzv32bKeX G4NZNegTN3fny0rb7f/4VXsAzxTCriaoLrIFj+97x0hkLjB/LYxiwju7zwiR6+Anp4 3TZYTkAeB1pArVh3DaSjjIK+pUuiAsHAvA+7Br2lJT1DCdMOAyjKZnwIhx6DzxcPDQ rXUVdcyDcYBHJCuduN7ee6Q21ZTKrh+eODkc7zm60TqMNWa4ygLVjpLgCnxz+Cqo5o mlNHN1sQ6B7IvLFGQ3vEdwIdWROgKr/ojk87Vf7/PW9a3ScLuYhU+D6BadXeJr1RNx 7//S/hoxIa9wg6ng3iAxCcdwF+Sep8dyJEEzietrnQgH1E8GlngfVhkbpwtkJYNpGO yaxScn/BQtyomvosHryIu6U0RFg9TtoCMyfcRal5cUIk72/6Y6xpHKne7Bq+kH3Xxy 164Zd9i193avNZ1IsrsL1Vbo8QrNYKfktbGsQjg7ym1U193nMYcqeGo7U69xU3dLXC Oatzf5Oq8aqMAzWOR0rnvLY6E63LmKMrPj7oSi0EdjRzJt3h+Kd2dIIdUAfH0IqvwJ tXYi7emc/bZwNzvSN1hU2JXU= Received: from zn.tnic (p5de8ee85.dip0.t-ipconnect.de [93.232.238.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id BAD0840E01A8; Tue, 30 Jul 2024 13:16:16 +0000 (UTC) Date: Tue, 30 Jul 2024 15:16:11 +0200 From: Borislav Petkov To: shiju.jose@huawei.com Cc: linux-edac@vger.kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, mike.malvestuto@intel.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v10 01/11] EDAC: Add generic EDAC RAS control feature driver Message-ID: <20240730131611.GAZqjnm9D4ZJoGBIuZ@fat_crate.local> References: <20240726160556.2079-1-shiju.jose@huawei.com> <20240726160556.2079-2-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240726160556.2079-2-shiju.jose@huawei.com> X-Stat-Signature: ho3tbfdx11ocn3bm8et9acpumpq3rcie X-Rspamd-Queue-Id: F149818000C X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1722345428-798722 X-HE-Meta: U2FsdGVkX1+3XRYRWBr+aqcNJRQplnLETFTUtCuRvKBtnfRVkJ7yn8W5Kq++fLNJMCs5PXb1GXObgIHFpbbOW+Fi3jUT/j2HaeP0enCh+OEwDdX+pAwSv08SVJJpCPGUjfJNg+OkQMcEcabTKKP3wfN/+ucO+4pxMHcyZDhLzZgRbFx9oI+OAn1jio1VyBoGHrtod0rHEiiRip/h/f2aMGFR630eQnbzfDPnGLKVjI0fZJuxOzFTQSb+hTw6PiHUM5e3DSjWfRNnIv+ob9+/RTdxsXkuOS5k/Yer94i9feruFcWlPVLoynMnvGJ5RuYXYZCFRzAZ236J5kHEm6GyDX7W8nLUAdeKXhjaxa6lA1dWAYhLP53Ba2FjZwT4VAnRyvSsJiityapV8+dRqiFuI99k43uc4Wq1Mvodh7ANhSnTg0XWBYSq6o6a3yWqzSDF3cwTqbkrDJDencvq2hPQADEse/9Yjz8sCkAKKbPCPmbzBGgY4uThMrm583/mR4eEusyIPxQLQPOQl2XE2av9n05AhiQ9lmkVwcgTsbNfBJXUmCvtllHTnlJlXJi8NjMRrMJT0AQiCtUawM8673iniRZBaSo3WWlouiW0jhQJlXJFZBB2ykNFlzYDvuJWWmW51bF1m9s0dnHnyR0PUeemcnzK02dSWGRXPJJe/SZxk5/oEP/h1igZMNJ3FgbowCblaI2jF+NPyVIl1UHZMbhcS+onyU6UZc0L6Vdxn9BBGImv9iIesyQVcdyHE26+6zZWri3aXqQd2oC7IvxWQFWbpZMcjmbN0t1rE1fTmFuQ4vQP3e5l3P3QS79VIVUNqYDhREMG6Sd6/ARVJFV64YBNRTfCrkxI5YMmiZvbgG2Xq53OdcJBwGUPvQsrU30QazA1fx/S6zqTVbhVRi4Etfnwh6g77lGWBjYtPcfjhU3WMecBpCgpxba0Bd23SFjzMToKxHg80QKBSclsGW1W68Y 4w6NhiaK J6MNHdkzbZ45zxsz9aKL0HwgUb5c4I30At196cgDaH+jjtJuTFZl+psh+IMiCw4Agjtct3EFkmV52zWdu9Z2SD9e+UG/lA9cdlK/lgtzTZTx+Z6gSMtck1rnYjxrKU3v/qXrxBo9mv6UNqsbo4TrRH1Sa70/z6b7jWwVrmmwh1GrtEKo397+td5gW3tuhGrOIXQEbIY9IrG/9c+1mYlv1gex3lj3I8AEsbxDXJa4Y6kHQmSCdFO1i5lOh6lEcU9NOzoIT7f6JfCtX6G6giqmCTws++ffZQaF6hZiCmbugCfCEbdrUuvgKSB6kCdP1/bVHH4N8YrHGOwPqvUw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 26, 2024 at 05:05:45PM +0100, shiju.jose@huawei.com wrote: > From: Shiju Jose > > Add generic EDAC driver supports registering RAS features supported > in the system. The driver exposes feature's control attributes to the > userspace in /sys/bus/edac/devices/// > > Co-developed-by: Jonathan Cameron > Signed-off-by: Jonathan Cameron > Signed-off-by: Shiju Jose > --- > drivers/edac/Makefile | 1 + > drivers/edac/edac_ras_feature.c | 181 +++++++++++++++++++++++++++++++ > include/linux/edac_ras_feature.h | 66 +++++++++++ > 3 files changed, 248 insertions(+) > create mode 100755 drivers/edac/edac_ras_feature.c > create mode 100755 include/linux/edac_ras_feature.h > > diff --git a/drivers/edac/Makefile b/drivers/edac/Makefile > index 9c09893695b7..c532b57a6d8a 100644 > --- a/drivers/edac/Makefile > +++ b/drivers/edac/Makefile > @@ -10,6 +10,7 @@ obj-$(CONFIG_EDAC) := edac_core.o > > edac_core-y := edac_mc.o edac_device.o edac_mc_sysfs.o > edac_core-y += edac_module.o edac_device_sysfs.o wq.o > +edac_core-y += edac_ras_feature.o EDAC and RAS and feature?! Oh boy. EDAC == RAS. "feature" is silly. Looking at the code below, you're registering an EDAC device. - edac_ras_dev_register(). So why isn't this thing in edac_device.c? > diff --git a/include/linux/edac_ras_feature.h b/include/linux/edac_ras_feature.h > new file mode 100755 > index 000000000000..8f0e0c47a617 > --- /dev/null > +++ b/include/linux/edac_ras_feature.h > @@ -0,0 +1,66 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * EDAC RAS control features. > + * > + * Copyright (c) 2024 HiSilicon Limited. > + */ > + > +#ifndef __EDAC_RAS_FEAT_H > +#define __EDAC_RAS_FEAT_H > + > +#include > +#include > + > +#define EDAC_RAS_NAME_LEN 128 > + > +enum edac_ras_feat { > + RAS_FEAT_SCRUB, > + RAS_FEAT_ECS, > + RAS_FEAT_MAX > +}; > + > +struct edac_ecs_ex_info { > + u16 num_media_frus; > +}; > + > +/* > + * EDAC RAS feature information structure > + */ > +struct edac_scrub_data { > + const struct edac_scrub_ops *ops; > + void *private; > +}; > + > +struct edac_ecs_data { > + const struct edac_ecs_ops *ops; > + void *private; > +}; So each "feature" would require a separate struct type? Why don't you define a *single* struct which accomodates any RAS functionality? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette