From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 418FAC3DA49 for ; Mon, 29 Jul 2024 01:37:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 660366B007B; Sun, 28 Jul 2024 21:37:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60FFF6B0083; Sun, 28 Jul 2024 21:37:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D7376B0085; Sun, 28 Jul 2024 21:37:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3033E6B007B for ; Sun, 28 Jul 2024 21:37:43 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8813280195 for ; Mon, 29 Jul 2024 01:37:42 +0000 (UTC) X-FDA: 82391078364.13.F2467D0 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf29.hostedemail.com (Postfix) with ESMTP id 9A8C1120005 for ; Mon, 29 Jul 2024 01:37:40 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QgHfG7Ho; spf=pass (imf29.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722217033; a=rsa-sha256; cv=none; b=ySFBt0HBeMM4kR1radWyQCwhMAkoaF478niKH2s56k/g+Vibol2lwIOTXuqOZ8VumYQWaC oH0ApjjuOHqCmw6EJYPK0GpsXj1blTD0CkEXp9lejI5IMmd9oPaCKH9w60QP0ULCCez8wL 4FV5+DgJJfokbHz3Q6O2GRmjHbWeL+s= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QgHfG7Ho; spf=pass (imf29.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722217033; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=laihnHn0tEWhiMwgpFPbHKhBIJSPYc/4lHmU8vF732k=; b=5S9yYVqlFU8iqGc5p0ZVE+W4u7/MSP27wEoLTZHVlgWK/beb29DHLXp3CEQKbt5pw1Lk1L 6F7oTUia5WMD6ZpKcAEPJyXOXcqYL2xdh6SOCsfnNl8/L0p5kQ9X+G81vqUZMwlXUFp4jx US/u7u1Y9nmk5xaCabS/iis6gKVIeJg= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1fc4fccdd78so13988315ad.2 for ; Sun, 28 Jul 2024 18:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722217059; x=1722821859; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=laihnHn0tEWhiMwgpFPbHKhBIJSPYc/4lHmU8vF732k=; b=QgHfG7HodUEIt/9CJRZpRiGEpRNb4RBNI8tgxq78Hyiy5jcMGdUaB7xnt6TDUI+xtX nvP7tPawzfS+21KvD66bjckcuk8KQWbo0nfJ6ZfsYKsx8iQCB6vaOoFjg2+N4u414CB3 zeznDnruI3Qrj3iMXm/TzWdxvU9UvtoLe7YKFZA1ce21DpuDN55hRtmD8LkNwJ/sJlBE K+nUHjbbi9BkeQvY0cct0E/GnJO0K1j1WDd336gvu6rEyBYGsDMMpm28gArauuPzgazn 1So4pMoh5l7qoeTivtamPy6CQREWMmkXoIM2PT5Im4+Nysb2DNtQxCmyQ5JzSfcIccS2 kjlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722217059; x=1722821859; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=laihnHn0tEWhiMwgpFPbHKhBIJSPYc/4lHmU8vF732k=; b=XfWJQ+/nCNQ/I6RjFeuk+0CQrIbHGBJTqsiY1Sn+saw7g6Xtyw5sS9uytDIZWwWUr7 P0IVjQrF32AMRqbHoYLUia1B6srj0SML1FkvkD/NyEpyF0wVC1bB+sbq2iIf7shKSkJQ Q0K0kpGKa9TVs3/gHe7FS8zd8jVX3xdtXym3FO8ASn/DLzbg/jzrQ9xHPRnf2+yZmUS1 ntckBdprBjmm3Z82YoatVpksZeMGd9yrAmPcIOySx8JO9zVvUllZjNzfB+11oaaM7d46 DEcxPMug5y+geLNp3IglbBWC5L58T2IpQ3R4n2euu6q+xy4JcYZS0ODy4c8sy38pq/sV 1NAw== X-Forwarded-Encrypted: i=1; AJvYcCV0oJwTcr5/tg+sTetZKAAhjCgpa9R1mud5Hs3WYujrRKalXUIk2yrGtHuUlUHebMmYtFlg9j11dg==@kvack.org X-Gm-Message-State: AOJu0YyLo7jH7227HFeGRwH/7RAUOzAg5qdfyU3xqK1QV0atRor7wqMx cG5iuZGYpboZVqm5JTrPG4llvI2m/AwsTCOTzLAvm9xp3czC5lf6 X-Google-Smtp-Source: AGHT+IFQdjRDbsHHZ4F9XyP8gJxPgF26gezLPByuD4QowAXZQtzR3gQYVihGWbncvmz8YnJvRgq63Q== X-Received: by 2002:a17:902:c994:b0:1fc:4bdc:d413 with SMTP id d9443c01a7336-1ff0493be42mr35839175ad.60.1722217059162; Sun, 28 Jul 2024 18:37:39 -0700 (PDT) Received: from localhost.localdomain ([2407:7000:8942:5500:aaa1:59ff:fe57:eb97]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fed7ee6a1esm70873795ad.164.2024.07.28.18.37.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jul 2024 18:37:38 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: lkp@intel.com Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com, oe-kbuild-all@lists.linux.dev, ryan.roberts@arm.com, senozhatsky@chromium.org, shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yosryahmed@google.com Subject: Re: [PATCH v5 4/4] mm: Introduce per-thpsize swapin control policy Date: Mon, 29 Jul 2024 13:37:18 +1200 Message-Id: <20240729013718.13901-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <202407271351.ffZPMT6W-lkp@intel.com> References: <202407271351.ffZPMT6W-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: 31myi5kof6zxyhgzr7akr6ojycohabo4 X-Rspamd-Queue-Id: 9A8C1120005 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1722217060-640192 X-HE-Meta: U2FsdGVkX18N0ejSjImic5kP+ssT1a3vj1x7eQcLQgviU4cRjbPqbimY/YumwK9++l0jbFCnuJnGSB6p+CBDjC0zw/fNH3fDgNZfMGW7pKJeI4IMjnCIAh5rrDTtWKHIKyR8dS5IW/9S23wz1n3rerty2aO57mo+ntICrGEI/TMxznsQTZ19a1abwP8lEpOKL+UgbovpEHKpOKOV+6Zdozg3qVEB+sGlE8PNHUGsWeAtgFb6kUx05PPscYGWq3vj1RxiIKYLX+DJ8ECHNI94+xvopSDIwF1qR6XKc+p2yWrK1A4QmMwPF7axR4DRbiPnHiqV6jfDBsNR4PVPaoCEXc3HIOUD/De9hzXGRm0+bcu/YNduQ+F2htjXV6QkU0DuMYtCD+CI2XYC1VWrADBB1yPxyHhRDI0LOv+Ck1Iy+mVnjurBZ/lBt0KRPhrFk1C1U9JEPLqfmADC+TzNGTQp3wvbLvrxBiZ2iMz+q0q+/gZPFY8d0IpRlYr8G48lXJeXqNUe8Z0tbH1D3y7FQJFPWEUQhr0vy7D3UQsWF7bdP76hoRn1qXihEjBdQMsSjlYvfm55flMMiQggBmemTKqxrGP7F8xp91+4HWVM/4LGszP/gsf3ivI0KiLJEH9s6UFtkD1Ynkn/uxvKxCYbz1yh+LvZf9/2cC2wr2jVoUa7HcHEzDnxa/q+XYEA8wNc6kmz/hyR3Mu9nrjKg66/zrRYRlcWdUa9tefL/alg0U2dyVmF4eApb5cvhTpRT+UMgabnj5we1sfUbBKeC2uBp+tIAA1XAjxOvJ+v5TRWOuhhom2wCRKw2yVraIA1PnGyEsHc7wPJ+CeDl59bkwPYG/Wm7kDT4CGBveBuLoWZ87taYQK1WwZ7bW1Inl2Q3MWKhe4+pyZzTmFQRudXVMadlKkvGJGyrxBnnZ5Kk3yO/r0JCeaqYfobR2yLEf31QQ4PhbZIWQOwVTxEiuT3+WD+wAm cuuOv8TS fM9MZcBvMEtMZyCl7QLnM1VxLjBSl+4bk34/ZEeH3SZhkLSRL1caWbgKk4N9Pmbw6hQcMLZbAThBeX4uQyldYgUyEb81JHa64nzB2/6KBYz0/x8825q/0uSpRjeob84uuFwFa3ZRwhhYoy9y8hwHE0zp4lvdRnn8DaS0wJdPrAUID1xCQzGBr24Psywk2YA3yAoG7hMcdg77L/wqOwdIu3hyW5TbQi+FFDIjMdy21ujaduzK32GdOuvuBDCeW4gmdq1G1LdXoS31s8N51YwbCdLJsdKDw4zrKqwGBQ6r0iVEjCmMpxCyLvx0QX8Yzj95GsSNgTLxrpMIueEQJoh+I+jzoE7ckO1Z28fiOw4qdJJuBSgfLtUnwOzISaGHsftRxuM7xkZOKMfvUYtQQLrqI9A5D5oiLO8yRtE7Ttf5+MPhtrIdbAhvri1GdQAdglr7uWyFeQAbIZxFiJrM65O26W+KJ5G5HZUMI1Gg/uOUWuKuF+AmAFjdLiYAMOHIAW6n8C+3hL+EhNxpGYVonZs0r66NFQwKzK1AFz0a+dinzsES14eG49nl3/Vavug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jul 27, 2024 at 5:58 PM kernel test robot wrote: > > Hi Barry, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on akpm-mm/mm-everything] Hi Thanks! Would you check if the below patch fixes the problem? diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 41460847988c..06984a325af7 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -80,7 +80,7 @@ unsigned long huge_zero_pfn __read_mostly = ~0UL; unsigned long huge_anon_orders_always __read_mostly; unsigned long huge_anon_orders_madvise __read_mostly; unsigned long huge_anon_orders_inherit __read_mostly; -unsigned long huge_anon_orders_swapin_always __read_mostly; +static unsigned long huge_anon_orders_swapin_always __read_mostly; unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma, unsigned long vm_flags, > > url:    https://github.com/intel-lab-lkp/linux/commits/Barry-Song/mm-swap-introduce-swapcache_prepare_nr-and-swapcache_clear_nr-for-large-folios-swap-in/20240726-181412 > base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link:    https://lore.kernel.org/r/20240726094618.401593-5-21cnbao%40gmail.com > patch subject: [PATCH v5 4/4] mm: Introduce per-thpsize swapin control policy > config: x86_64-randconfig-121-20240727 (https://download.01.org/0day-ci/archive/20240727/202407271351.ffZPMT6W-lkp@intel.com/config) > compiler: gcc-11 (Ubuntu 11.4.0-4ubuntu1) 11.4.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240727/202407271351.ffZPMT6W-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202407271351.ffZPMT6W-lkp@intel.com/ > > sparse warnings: (new ones prefixed by >>) > >> mm/huge_memory.c:83:15: sparse: sparse: symbol 'huge_anon_orders_swapin_always' was not declared. Should it be static? >    mm/huge_memory.c: note: in included file (through include/linux/smp.h, include/linux/lockdep.h, include/linux/spinlock.h, ...): >    include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true >    mm/huge_memory.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/mm.h): >    include/linux/page-flags.h:235:46: sparse: sparse: self-comparison always evaluates to false >    include/linux/page-flags.h:235:46: sparse: sparse: self-comparison always evaluates to false >    mm/huge_memory.c:1867:20: sparse: sparse: context imbalance in 'madvise_free_huge_pmd' - unexpected unlock >    include/linux/page-flags.h:235:46: sparse: sparse: self-comparison always evaluates to false >    mm/huge_memory.c:1905:28: sparse: sparse: context imbalance in 'zap_huge_pmd' - unexpected unlock >    mm/huge_memory.c:2016:28: sparse: sparse: context imbalance in 'move_huge_pmd' - unexpected unlock >    mm/huge_memory.c:2156:20: sparse: sparse: context imbalance in 'change_huge_pmd' - unexpected unlock >    mm/huge_memory.c:2306:12: sparse: sparse: context imbalance in '__pmd_trans_huge_lock' - wrong count at exit >    mm/huge_memory.c:2323:12: sparse: sparse: context imbalance in '__pud_trans_huge_lock' - wrong count at exit >    mm/huge_memory.c:2347:28: sparse: sparse: context imbalance in 'zap_huge_pud' - unexpected unlock >    mm/huge_memory.c:2426:18: sparse: sparse: context imbalance in '__split_huge_zero_page_pmd' - unexpected unlock >    mm/huge_memory.c:2640:18: sparse: sparse: context imbalance in '__split_huge_pmd_locked' - unexpected unlock >    include/linux/page-flags.h:235:46: sparse: sparse: self-comparison always evaluates to false >    mm/huge_memory.c: note: in included file (through include/linux/smp.h, include/linux/lockdep.h, include/linux/spinlock.h, ...): >    include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true >    include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true >    mm/huge_memory.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/mm.h): >    include/linux/page-flags.h:235:46: sparse: sparse: self-comparison always evaluates to false >    mm/huge_memory.c:3031:30: sparse: sparse: context imbalance in '__split_huge_page' - unexpected unlock >    mm/huge_memory.c:3306:17: sparse: sparse: context imbalance in 'split_huge_page_to_list_to_order' - different lock contexts for basic block >    mm/huge_memory.c: note: in included file (through include/linux/smp.h, include/linux/lockdep.h, include/linux/spinlock.h, ...): >    include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true >    mm/huge_memory.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/mm.h): >    include/linux/page-flags.h:235:46: sparse: sparse: self-comparison always evaluates to false >    mm/huge_memory.c: note: in included file (through include/linux/smp.h, include/linux/lockdep.h, include/linux/spinlock.h, ...): >    include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true >    mm/huge_memory.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/mm.h): >    include/linux/page-flags.h:235:46: sparse: sparse: self-comparison always evaluates to false >    include/linux/page-flags.h:235:46: sparse: sparse: self-comparison always evaluates to false > > vim +/huge_anon_orders_swapin_always +83 mm/huge_memory.c > >     51 >     52  /* >     53   * By default, transparent hugepage support is disabled in order to avoid >     54   * risking an increased memory footprint for applications that are not >     55   * guaranteed to benefit from it. When transparent hugepage support is >     56   * enabled, it is for all mappings, and khugepaged scans all mappings. >     57   * Defrag is invoked by khugepaged hugepage allocations and by page faults >     58   * for all hugepage allocations. >     59   */ >     60  unsigned long transparent_hugepage_flags __read_mostly = >     61  #ifdef CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS >     62          (1<     63  #endif >     64  #ifdef CONFIG_TRANSPARENT_HUGEPAGE_MADVISE >     65          (1<     66  #endif >     67          (1<     68          (1<     69          (1<     70 >     71  static struct shrinker *deferred_split_shrinker; >     72  static unsigned long deferred_split_count(struct shrinker *shrink, >     73                                            struct shrink_control *sc); >     74  static unsigned long deferred_split_scan(struct shrinker *shrink, >     75                                           struct shrink_control *sc); >     76 >     77  static atomic_t huge_zero_refcount; >     78  struct folio *huge_zero_folio __read_mostly; >     79  unsigned long huge_zero_pfn __read_mostly = ~0UL; >     80  unsigned long huge_anon_orders_always __read_mostly; >     81  unsigned long huge_anon_orders_madvise __read_mostly; >     82  unsigned long huge_anon_orders_inherit __read_mostly; >   > 83  unsigned long huge_anon_orders_swapin_always __read_mostly; >     84 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki Thanks Barry