From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D601C3DA49 for ; Fri, 26 Jul 2024 23:08:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 854916B0082; Fri, 26 Jul 2024 19:08:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DDAE6B0083; Fri, 26 Jul 2024 19:08:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67E5A6B0088; Fri, 26 Jul 2024 19:08:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 491246B0082 for ; Fri, 26 Jul 2024 19:08:14 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B93F11401C8 for ; Fri, 26 Jul 2024 23:08:13 +0000 (UTC) X-FDA: 82383444066.19.4FBB6A4 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by imf22.hostedemail.com (Postfix) with ESMTP id C53DAC0023 for ; Fri, 26 Jul 2024 23:08:10 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=wHfmMsL3; spf=pass (imf22.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722035289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XSaYzOa5POmQwT9zJXZdAuQLpg2xdRHWddGJ5wJg/4M=; b=ZPZQz2LxfSR4UD7fOnjkXTl1mWaaG9VzPBN6fdYOR73z7k/3PEj3jmXohtdisoRJl+Wh/8 rjOxXVC3rQvzVAV7bcSyj3B1AfGGoOmm3O4RHOEbDsSZvO30ayX1iVZsyooSS/sNUKfDxe UsW1eRNVxG2Bd0x+235a+gcZ5xSg51A= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=wHfmMsL3; spf=pass (imf22.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722035289; a=rsa-sha256; cv=none; b=nkyJMSU1SsZrEKdmSzXXkK7zTkAg9oeneC35b+qs9mEmQFfplkTnFkiFwZlL2+ValpAWSP quwe+FM86BvMnPZ7WXAud/EfF6LcrNiwWqPF5xkcYRLNMPR/n1iZ14zhyaESHQjrulCVV2 s3s7OvTtnKzITLWlFWHIE2ir7TtzPoQ= Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7a1d066a5daso79699885a.3 for ; Fri, 26 Jul 2024 16:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1722035290; x=1722640090; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XSaYzOa5POmQwT9zJXZdAuQLpg2xdRHWddGJ5wJg/4M=; b=wHfmMsL3n8bqV3mhas0pzPDs2rYRPzEl4xZClgyhjurWtJ9qaMU6LNnGE50yGqAXLw 64fMXMnjFzQwlwbCvFgA/z2ozRTUatdkhD3lh9J2vtTCo302A77BH5euYOM/2VOQMq+U I1ugkMrwj3bM7QyYYWZVx+zDXIJzxGGKMjgUF2XwmaHAWv0op9DArbZ1emjtLPWzRzvq Q8YVRU9r5kG4T+yiG1B2kywwcAe9J7s35ytFOC0YmRVPENgH7AcTDuUpeLfFtgC23b0z zLzOzVc9p6MsxBEsPSo0Kv0vP6t1/C9BomAoXf5ii0K8NDioOfDGDwc0Z4z6fEILVTQ3 uywQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722035290; x=1722640090; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XSaYzOa5POmQwT9zJXZdAuQLpg2xdRHWddGJ5wJg/4M=; b=N//5usrdnVaSz08t3ICgL2t650CFNYcIH9x3y/xQHegv05ynevmzdiww5V1wCI4KqZ kkOR+A3b8AXLDxwGtupyi/JLNfDLHAfXagsAimP/PpIZ3HYeiEBbpP4gXfU/mGGnscu1 zgvYKFfcAYCaj12eyRH4GCBRMhhaGxGV52vj6D/sMytLcJTuPL9XWGQU8i3YRxklLmLa niSaFD0nXpZfyw0y2L5SYloRZBmRX78DMEdHrQL0cCyaUGMe8QYuiBP0hc9wGdXLBWpx z3nDKAccEFGogczpAb7+Ex5PjVSyqtFjfI1Sh5YvIvJOUjcZXJDymMDXaOOwFnU3BlOG Rhqw== X-Forwarded-Encrypted: i=1; AJvYcCXTcrXhSr+yIv8g94oBehSdQMqF5Y5UllUGA5gIULH/jfQL57MvfQpiQjuFtnJiAaNDQXAbw/RZlvPN8w6pLKEBHt8= X-Gm-Message-State: AOJu0YzvhIVDBkhJXGWyMgwV4lXMC0xROAt+yvBUJwczRJWfq87Fa0ha btowofbMNszHH1SvB2oVLvfXsEgbzzXuYRPcXVZ7a57Dd6u+yRlY0A0q9J3L6rQ= X-Google-Smtp-Source: AGHT+IEjxjyck4ApqiiZqdFd4d9Hp90uhlrQwEC3C+q7nYeysVRvA1ovCvhDZ2YgLTQCoUj4UFK2JA== X-Received: by 2002:a05:620a:472b:b0:79f:913:8109 with SMTP id af79cd13be357-7a1e525bac3mr165143985a.36.1722035289783; Fri, 26 Jul 2024 16:08:09 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a1d7435582sm220426985a.85.2024.07.26.16.08.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jul 2024 16:08:09 -0700 (PDT) Date: Fri, 26 Jul 2024 19:08:08 -0400 From: Johannes Weiner To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Shakeel Butt , Muchun Song Subject: Re: [PATCH v3 1/3] mm: memcg: don't call propagate_protected_usage() needlessly Message-ID: <20240726230808.GD1702603@cmpxchg.org> References: <20240726203110.1577216-1-roman.gushchin@linux.dev> <20240726203110.1577216-2-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240726203110.1577216-2-roman.gushchin@linux.dev> X-Rspam-User: X-Stat-Signature: msqr8h8xd4n6kbqkh7jwur84htsgmr8q X-Rspamd-Queue-Id: C53DAC0023 X-Rspamd-Server: rspam11 X-HE-Tag: 1722035290-371250 X-HE-Meta: U2FsdGVkX192mHUz4bLToAbQUOtcQqwG5MS6YmX+RzElXOhHiSKfBsL77tpp1VQpTYSnP0/lhD0k3X35rFEvt9bXyjN+h3+lQhh1I+3tTwg6DwpY0xCZcV/1RPmQt7sFP+lvh7TrrNKoK0JARaI49JQjciZvuYrm7YdCDbyqjj0Fc8CMH/OBJNRpH9YajO0D2nUHwtedue+2t96/7yI2g3u6lKQMuyfsqBQYSFoCNNJ8ApjY73lyF6/qZHgPRlA+XLgiYA1tj9v8Gq9VOB+Ub/utXHHqsrP9nmwLlik9LxErfLgibvXhlAlPVad6gmhtuq/ZIpTfoAj76UQMGDOV+zvZpyaoQjHzKC01jjKqle5+DnU31SRug2dPbhFknHISJH+lkYfWVgZ4sCoGzr5jk0wttQnxpjmm9hXUVffmcKwsPD62Y1jYy0LfNID3i3smzWOg4TpTlgG2K9shT6GLiiu40p+y1ZtTlOXWMVacYNuoU61W8zM93EQkn2MKvRfYETv9zzlX9rtCudjCzUofJyR5I1sqMIdS2W3oeYN0NehSvWPOHX4ADK1zxUSM26+4qc8mcr9XyTfcyymonrToGH2VGGH19RxhqO+m/+XoGs7R0gRsNnDnI9PbDfVRXIGZzAqrRTkLWLd3QmXEbwjLuy51FPJIrOlYNwJLBoD5iB0AB1CLq6iRjIBP1jXe2dySPyP1SN9494VnQNxlfJbnkMLhrxaVjqCOdf7k8naOg+DW6vd5jHvKKEDA96vNRa4OtFwQOlBGR5LrLoBczcYmG4MMfiaCAoNvdj+vFuzsrwOfZqXXcotmZorXmyevKPStpZCh2ZWTnD/uG6H91+KllC1f/QpYP1Ff60uSFV9tCs63yTmwg3Es0qxqiVU2SRCYbE11MzbGQ5zL9cftrD9yN4W5EAYZU2pvvyqQIFbIROprYsbsazlUdlihSmvWKZ1AAR8E50HBOSRjqI6WcfH +xRNknyz S06tvDemBLx6I10OHUGa9O3chXP+i/6ib2awJVOT93OR6k0pDze8bVGJkYu5/a4b9ihGCNltLcQHcB+p6L6cmA4uFssAtYLJJhBnYhpO3l5NJXgFzyoANIZu2nEehZYivmV2komtNfeDYUyt3Y0RgNFHh+hFMTz5bFLWBjNEWJusL6xcCRaElkxOVLl5Qc8nZCSisBsYV/vM2I+jOVwN+/7AYKKR2zbxGE8NaQIdIK4hXQQIjk6h3NX5QKx5sxqEq/kJya7624vDYf2sedrwzoUIb3kfpzgzAeOabADWG9CgElqJhlJ1WiR4ohVjmcgLk5VTErruZazncLxIs5FcSLOsdu9ZK5WVciaB0VrmtIuc1+dediXqAoYeFDaDK/XzMmCG+l2f1hJPd365f+HAJId4bjaNwEjmTyPZjRn/y6QeWlDg2tpCce8FZdN7Sac240kgs/cbXzpMYf/5vXIpW+FAhma75SpYdJUdYspmD8KzLFqSTfHryxb8zpL0FzlsTZWXR89c0TQV7F33BDzADNesQh0tkYkuuZvvx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 26, 2024 at 08:31:08PM +0000, Roman Gushchin wrote: > Memory protection (min/low) requires a constant tracking of > protected memory usage. propagate_protected_usage() is called > on each page counters update and does a number of operations > even in cases when the actual memory protection functionality > is not supported (e.g. hugetlb cgroups or memcg swap counters). > > It's obviously inefficient and leads to a waste of CPU cycles. > It can be addressed by calling propagate_protected_usage() only > for the counters which do support memory guarantees. As of now > it's only memcg->memory - the unified memory memcg counter. > > Signed-off-by: Roman Gushchin > Acked-by: Shakeel Butt Makes perfect sense. Acked-by: Johannes Weiner > @@ -13,6 +13,11 @@ > #include > #include > > +static bool track_protection(struct page_counter *c) > +{ > + return c->protection_support; > +} IMO it's a bit easier to follow without this. page_counter.c should be able to access struct page_counter members directly :)